* [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
@ 2014-10-02 19:17 ` Mel Gorman
0 siblings, 0 replies; 6+ messages in thread
From: Mel Gorman @ 2014-10-02 19:17 UTC (permalink / raw)
To: Andrew Morton
Cc: Rik van Riel, Peter Zijlstra, Hugh Dickins, Linux Kernel, linux-mm
PROT_NUMA VMAs are skipped to avoid problems distinguishing between
present, prot_none and special entries. MPOL_MF_LAZY is not visible from
userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
same way task_numa_work does.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
---
mm/mempolicy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 8f5330d..a5877ce 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
}
if (flags & MPOL_MF_LAZY) {
- change_prot_numa(vma, start, endvma);
+ /* Similar to task_numa_work, skip inaccessible VMAs */
+ if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+ change_prot_numa(vma, start, endvma);
goto next;
}
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
@ 2014-10-02 19:17 ` Mel Gorman
0 siblings, 0 replies; 6+ messages in thread
From: Mel Gorman @ 2014-10-02 19:17 UTC (permalink / raw)
To: Andrew Morton
Cc: Rik van Riel, Peter Zijlstra, Hugh Dickins, Linux Kernel, linux-mm
PROT_NUMA VMAs are skipped to avoid problems distinguishing between
present, prot_none and special entries. MPOL_MF_LAZY is not visible from
userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
same way task_numa_work does.
Signed-off-by: Mel Gorman <mgorman@suse.de>
Acked-by: Rik van Riel <riel@redhat.com>
---
mm/mempolicy.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 8f5330d..a5877ce 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
}
if (flags & MPOL_MF_LAZY) {
- change_prot_numa(vma, start, endvma);
+ /* Similar to task_numa_work, skip inaccessible VMAs */
+ if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
+ change_prot_numa(vma, start, endvma);
goto next;
}
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
2014-10-02 19:17 ` Mel Gorman
@ 2014-10-02 19:41 ` Hugh Dickins
-1 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2014-10-02 19:41 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, Peter Zijlstra, Hugh Dickins,
Linux Kernel, linux-mm
On Thu, 2 Oct 2014, Mel Gorman wrote:
> PROT_NUMA VMAs are skipped to avoid problems distinguishing between
> present, prot_none and special entries. MPOL_MF_LAZY is not visible from
> userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
> MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
> same way task_numa_work does.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Yes, this is much the same as the patch I wrote for Linus two days ago,
then discovered that we don't need until MPOL_MF_LAZY gets brought back
into MPOL_MF_VALID. (As a bonus, my patch did also remove the currently
bogus paragraph of comment above change_prot_numa(); and I would prefer a
code comment to make clear that we never exercise this path at present.)
> ---
> mm/mempolicy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 8f5330d..a5877ce 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
> }
>
> if (flags & MPOL_MF_LAZY) {
> - change_prot_numa(vma, start, endvma);
> + /* Similar to task_numa_work, skip inaccessible VMAs */
> + if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
> + change_prot_numa(vma, start, endvma);
> goto next;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
@ 2014-10-02 19:41 ` Hugh Dickins
0 siblings, 0 replies; 6+ messages in thread
From: Hugh Dickins @ 2014-10-02 19:41 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, Peter Zijlstra, Hugh Dickins,
Linux Kernel, linux-mm
On Thu, 2 Oct 2014, Mel Gorman wrote:
> PROT_NUMA VMAs are skipped to avoid problems distinguishing between
> present, prot_none and special entries. MPOL_MF_LAZY is not visible from
> userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
> MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
> same way task_numa_work does.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Hugh Dickins <hughd@google.com>
Yes, this is much the same as the patch I wrote for Linus two days ago,
then discovered that we don't need until MPOL_MF_LAZY gets brought back
into MPOL_MF_VALID. (As a bonus, my patch did also remove the currently
bogus paragraph of comment above change_prot_numa(); and I would prefer a
code comment to make clear that we never exercise this path at present.)
> ---
> mm/mempolicy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 8f5330d..a5877ce 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
> }
>
> if (flags & MPOL_MF_LAZY) {
> - change_prot_numa(vma, start, endvma);
> + /* Similar to task_numa_work, skip inaccessible VMAs */
> + if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
> + change_prot_numa(vma, start, endvma);
> goto next;
> }
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
2014-10-02 19:17 ` Mel Gorman
@ 2014-10-02 19:59 ` Peter Zijlstra
-1 siblings, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2014-10-02 19:59 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, Hugh Dickins, Linux Kernel, linux-mm
On Thu, Oct 02, 2014 at 08:17:03PM +0100, Mel Gorman wrote:
> PROT_NUMA VMAs are skipped to avoid problems distinguishing between
> present, prot_none and special entries. MPOL_MF_LAZY is not visible from
> userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
> MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
> same way task_numa_work does.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
> ---
> mm/mempolicy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 8f5330d..a5877ce 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
> }
>
> if (flags & MPOL_MF_LAZY) {
> - change_prot_numa(vma, start, endvma);
> + /* Similar to task_numa_work, skip inaccessible VMAs */
> + if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
> + change_prot_numa(vma, start, endvma);
> goto next;
> }
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY
@ 2014-10-02 19:59 ` Peter Zijlstra
0 siblings, 0 replies; 6+ messages in thread
From: Peter Zijlstra @ 2014-10-02 19:59 UTC (permalink / raw)
To: Mel Gorman
Cc: Andrew Morton, Rik van Riel, Hugh Dickins, Linux Kernel, linux-mm
On Thu, Oct 02, 2014 at 08:17:03PM +0100, Mel Gorman wrote:
> PROT_NUMA VMAs are skipped to avoid problems distinguishing between
> present, prot_none and special entries. MPOL_MF_LAZY is not visible from
> userspace since commit a720094ded8c ("mm: mempolicy: Hide MPOL_NOOP and
> MPOL_MF_LAZY from userspace for now") but it should still skip VMAs the
> same way task_numa_work does.
>
> Signed-off-by: Mel Gorman <mgorman@suse.de>
> Acked-by: Rik van Riel <riel@redhat.com>
Acked-by: Peter Zijlstra <peterz@infradead.org>
> ---
> mm/mempolicy.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/mm/mempolicy.c b/mm/mempolicy.c
> index 8f5330d..a5877ce 100644
> --- a/mm/mempolicy.c
> +++ b/mm/mempolicy.c
> @@ -683,7 +683,9 @@ queue_pages_range(struct mm_struct *mm, unsigned long start, unsigned long end,
> }
>
> if (flags & MPOL_MF_LAZY) {
> - change_prot_numa(vma, start, endvma);
> + /* Similar to task_numa_work, skip inaccessible VMAs */
> + if (vma->vm_flags & (VM_READ | VM_EXEC | VM_WRITE))
> + change_prot_numa(vma, start, endvma);
> goto next;
> }
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-10-02 19:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-10-02 19:17 [PATCH] mm: mempolicy: Skip inaccessible VMAs when setting MPOL_MF_LAZY Mel Gorman
2014-10-02 19:17 ` Mel Gorman
2014-10-02 19:41 ` Hugh Dickins
2014-10-02 19:41 ` Hugh Dickins
2014-10-02 19:59 ` Peter Zijlstra
2014-10-02 19:59 ` Peter Zijlstra
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.