* [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"
@ 2020-06-25 15:52 Menno Lageman
2020-07-06 16:26 ` Laurent Vivier
2020-07-06 17:14 ` Laurent Vivier
0 siblings, 2 replies; 3+ messages in thread
From: Menno Lageman @ 2020-06-25 15:52 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
removed the "x-" prefix but but didn't update the error message
accordingly.
Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
---
hw/i386/intel_iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index df7ad254ac15..c56398e99177 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
/* Currently only address widths supported are 39 and 48 bits */
if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
(s->aw_bits != VTD_HOST_AW_48BIT)) {
- error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
+ error_setg(errp, "Supported values for aw-bits are: %d, %d",
VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
return false;
}
--
2.26.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"
2020-06-25 15:52 [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits" Menno Lageman
@ 2020-07-06 16:26 ` Laurent Vivier
2020-07-06 17:14 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-07-06 16:26 UTC (permalink / raw)
To: Menno Lageman, qemu-devel; +Cc: qemu-trivial
Le 25/06/2020 à 17:52, Menno Lageman a écrit :
> Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
> removed the "x-" prefix but but didn't update the error message
> accordingly.
>
> Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
> ---
> hw/i386/intel_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index df7ad254ac15..c56398e99177 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
> /* Currently only address widths supported are 39 and 48 bits */
> if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
> (s->aw_bits != VTD_HOST_AW_48BIT)) {
> - error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
> + error_setg(errp, "Supported values for aw-bits are: %d, %d",
> VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
> return false;
> }
>
Reviewed-by: Laurent Vivier <laurent@vivier.eu>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits"
2020-06-25 15:52 [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits" Menno Lageman
2020-07-06 16:26 ` Laurent Vivier
@ 2020-07-06 17:14 ` Laurent Vivier
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2020-07-06 17:14 UTC (permalink / raw)
To: Menno Lageman, qemu-devel; +Cc: qemu-trivial
Le 25/06/2020 à 17:52, Menno Lageman a écrit :
> Commit 4b49b586c4 ('intel_iommu: remove "x-" prefix for "aw-bits"')
> removed the "x-" prefix but but didn't update the error message
> accordingly.
>
> Signed-off-by: Menno Lageman <menno.lageman@oracle.com>
> ---
> hw/i386/intel_iommu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
> index df7ad254ac15..c56398e99177 100644
> --- a/hw/i386/intel_iommu.c
> +++ b/hw/i386/intel_iommu.c
> @@ -3758,7 +3758,7 @@ static bool vtd_decide_config(IntelIOMMUState *s, Error **errp)
> /* Currently only address widths supported are 39 and 48 bits */
> if ((s->aw_bits != VTD_HOST_AW_39BIT) &&
> (s->aw_bits != VTD_HOST_AW_48BIT)) {
> - error_setg(errp, "Supported values for x-aw-bits are: %d, %d",
> + error_setg(errp, "Supported values for aw-bits are: %d, %d",
> VTD_HOST_AW_39BIT, VTD_HOST_AW_48BIT);
> return false;
> }
>
Applied to my trivial-patches-for-5.1 branch.
Thanks,
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-06 17:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-25 15:52 [PATCH] intel_iommu: "aw-bits" error message still refers to "x-aw-bits" Menno Lageman
2020-07-06 16:26 ` Laurent Vivier
2020-07-06 17:14 ` Laurent Vivier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.