All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Arnd Bergmann" <arnd@kernel.org>, "Måns Rullgård" <mans@mansr.com>
Cc: Linux ARM <linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>
Subject: Re: [PATCH 4/5] watchdog: remove tango driver
Date: Thu, 21 Jan 2021 08:33:30 -0800	[thread overview]
Message-ID: <b57e94ac-85a2-8aa6-5400-400ead370848@roeck-us.net> (raw)
In-Reply-To: <CAK8P3a2QFewbxz+HEo9MCE3+RuZBT=yM3Bd2pGhtvN0=-9sj_g@mail.gmail.com>

On 1/21/21 7:18 AM, Arnd Bergmann wrote:
> On Thu, Jan 21, 2021 at 3:01 PM Måns Rullgård <mans@mansr.com> wrote:
>> Arnd Bergmann <arnd@kernel.org> writes:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> The tango platform is getting removed, so the driver is no
>>> longer needed.
>>>
>>> Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>
>>> Cc: Mans Rullgard <mans@mansr.com>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>  drivers/watchdog/Kconfig      |  11 --
>>>  drivers/watchdog/Makefile     |   1 -
>>>  drivers/watchdog/tangox_wdt.c | 209 ----------------------------------
>>>  3 files changed, 221 deletions(-)
>>>  delete mode 100644 drivers/watchdog/tangox_wdt.c
>>
>> The DT binding can go as well.
> 
> Good catch! I thought I had cross-checked all DT compatible strings of the
> removed dts files, bindings and drivers to make sure everything is gone
> at once, but it seems I missed a couple of files including this one.
> 
> Guenter and Wim, let me know if I should resend this patch or all watchdog
> patches, or just remove the binding as part of the platform removal in the
> soc tree.

I'd suggest to just resend this patch, or to send another one on top of it.
It is Wim's call to make, though, since he will apply the patches.

Guenter

WARNING: multiple messages have this Message-ID (diff)
From: Guenter Roeck <linux@roeck-us.net>
To: "Arnd Bergmann" <arnd@kernel.org>, "Måns Rullgård" <mans@mansr.com>
Cc: LINUXWATCHDOG <linux-watchdog@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Marc Gonzalez <marc.w.gonzalez@free.fr>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Wim Van Sebroeck <wim@linux-watchdog.org>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 4/5] watchdog: remove tango driver
Date: Thu, 21 Jan 2021 08:33:30 -0800	[thread overview]
Message-ID: <b57e94ac-85a2-8aa6-5400-400ead370848@roeck-us.net> (raw)
In-Reply-To: <CAK8P3a2QFewbxz+HEo9MCE3+RuZBT=yM3Bd2pGhtvN0=-9sj_g@mail.gmail.com>

On 1/21/21 7:18 AM, Arnd Bergmann wrote:
> On Thu, Jan 21, 2021 at 3:01 PM Måns Rullgård <mans@mansr.com> wrote:
>> Arnd Bergmann <arnd@kernel.org> writes:
>>> From: Arnd Bergmann <arnd@arndb.de>
>>>
>>> The tango platform is getting removed, so the driver is no
>>> longer needed.
>>>
>>> Cc: Marc Gonzalez <marc.w.gonzalez@free.fr>
>>> Cc: Mans Rullgard <mans@mansr.com>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>> ---
>>>  drivers/watchdog/Kconfig      |  11 --
>>>  drivers/watchdog/Makefile     |   1 -
>>>  drivers/watchdog/tangox_wdt.c | 209 ----------------------------------
>>>  3 files changed, 221 deletions(-)
>>>  delete mode 100644 drivers/watchdog/tangox_wdt.c
>>
>> The DT binding can go as well.
> 
> Good catch! I thought I had cross-checked all DT compatible strings of the
> removed dts files, bindings and drivers to make sure everything is gone
> at once, but it seems I missed a couple of files including this one.
> 
> Guenter and Wim, let me know if I should resend this patch or all watchdog
> patches, or just remove the binding as part of the platform removal in the
> soc tree.

I'd suggest to just resend this patch, or to send another one on top of it.
It is Wim's call to make, though, since he will apply the patches.

Guenter

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-01-21 16:35 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 16:27 [PATCH 0/5] watchdog: remove obsolete drivers Arnd Bergmann
2021-01-20 16:27 ` Arnd Bergmann
2021-01-20 16:27 ` [PATCH 1/5] watchdog: remove sirf prima driver Arnd Bergmann
2021-01-20 16:27   ` Arnd Bergmann
2021-01-20 19:03   ` Guenter Roeck
2021-01-20 19:03     ` Guenter Roeck
2021-01-20 21:15   ` Barry Song
2021-01-20 21:15     ` Barry Song
2021-01-20 16:27 ` [PATCH 2/5] watchdog: remove sirf atlas driver Arnd Bergmann
2021-01-20 16:27   ` Arnd Bergmann
2021-01-20 19:03   ` Guenter Roeck
2021-01-20 19:03     ` Guenter Roeck
2021-01-20 21:17   ` Barry Song
2021-01-20 21:17     ` Barry Song
2021-01-20 16:27 ` [PATCH 3/5] watchdog: remove zte zx driver Arnd Bergmann
2021-01-20 16:27   ` Arnd Bergmann
2021-01-20 19:03   ` Guenter Roeck
2021-01-20 19:03     ` Guenter Roeck
2021-01-20 16:27 ` [PATCH 4/5] watchdog: remove tango driver Arnd Bergmann
2021-01-20 16:27   ` Arnd Bergmann
2021-01-20 19:03   ` Guenter Roeck
2021-01-20 19:03     ` Guenter Roeck
2021-01-21 14:01   ` Måns Rullgård
2021-01-21 14:01     ` Måns Rullgård
2021-01-21 15:18     ` Arnd Bergmann
2021-01-21 15:18       ` Arnd Bergmann
2021-01-21 16:33       ` Guenter Roeck [this message]
2021-01-21 16:33         ` Guenter Roeck
2021-01-23 18:34   ` Guenter Roeck
2021-01-23 18:34     ` Guenter Roeck
2021-01-23 18:47     ` Arnd Bergmann
2021-01-23 18:47       ` Arnd Bergmann
2021-01-20 16:27 ` [PATCH 5/5] watchdog: remove coh901 driver Arnd Bergmann
2021-01-20 16:27   ` Arnd Bergmann
2021-01-20 19:03   ` Guenter Roeck
2021-01-20 19:03     ` Guenter Roeck
2021-01-21 13:14   ` Linus Walleij
2021-01-21 13:14     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b57e94ac-85a2-8aa6-5400-400ead370848@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=arnd@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=mans@mansr.com \
    --cc=marc.w.gonzalez@free.fr \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.