From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, broonie@kernel.org, alsa-devel@alsa-project.org Cc: Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>, open list <linux-kernel@vger.kernel.org>, Takashi Iwai <tiwai@suse.com>, Alexander.Deucher@amd.com Subject: Re: [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops Date: Thu, 8 Jul 2021 17:11:14 +0530 [thread overview] Message-ID: <b754ef05-065d-ee7b-754f-1498f7c6cff6@amd.com> (raw) In-Reply-To: <ce03f4b3-874f-a286-5523-7793722a6ee7@linux.intel.com> On 7/7/21 10:04 PM, Pierre-Louis Bossart wrote: > >> +static int snd_acp5x_suspend(struct device *dev) >> +{ >> + int ret; >> + struct acp5x_dev_data *adata; >> + >> + adata = dev_get_drvdata(dev); >> + ret = acp5x_deinit(adata->acp5x_base); >> + if (ret) >> + dev_err(dev, "ACP de-init failed\n"); >> + else >> + dev_dbg(dev, "ACP de-initialized\n"); >> + >> + return ret; >> +} >> + >> +static int snd_acp5x_resume(struct device *dev) >> +{ >> + int ret; >> + struct acp5x_dev_data *adata; >> + >> + adata = dev_get_drvdata(dev); >> + ret = acp5x_init(adata->acp5x_base); >> + if (ret) { >> + dev_err(dev, "ACP init failed\n"); >> + return ret; >> + } >> + return 0; >> +} >> + >> +static const struct dev_pm_ops acp5x_pm = { >> + .runtime_suspend = snd_acp5x_suspend, >> + .runtime_resume = snd_acp5x_resume, >> + .resume = snd_acp5x_resume, > > use SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS? We will modify the code. > > also not clear why you don't have a .suspend here It was a miss. we will add .suspend callback which invokes same callback "snd_acp5x_suspend". > > And to avoid warnings use __maybe_unused for those callbacks when PM is disabled? > Agreed. We will modify the code and post the new version. >
WARNING: multiple messages have this Message-ID (diff)
From: "Mukunda,Vijendar" <vijendar.mukunda@amd.com> To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, broonie@kernel.org, alsa-devel@alsa-project.org Cc: Alexander.Deucher@amd.com, Takashi Iwai <tiwai@suse.com>, Sunil-kumar.Dommati@amd.com, Liam Girdwood <lgirdwood@gmail.com>, open list <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops Date: Thu, 8 Jul 2021 17:11:14 +0530 [thread overview] Message-ID: <b754ef05-065d-ee7b-754f-1498f7c6cff6@amd.com> (raw) In-Reply-To: <ce03f4b3-874f-a286-5523-7793722a6ee7@linux.intel.com> On 7/7/21 10:04 PM, Pierre-Louis Bossart wrote: > >> +static int snd_acp5x_suspend(struct device *dev) >> +{ >> + int ret; >> + struct acp5x_dev_data *adata; >> + >> + adata = dev_get_drvdata(dev); >> + ret = acp5x_deinit(adata->acp5x_base); >> + if (ret) >> + dev_err(dev, "ACP de-init failed\n"); >> + else >> + dev_dbg(dev, "ACP de-initialized\n"); >> + >> + return ret; >> +} >> + >> +static int snd_acp5x_resume(struct device *dev) >> +{ >> + int ret; >> + struct acp5x_dev_data *adata; >> + >> + adata = dev_get_drvdata(dev); >> + ret = acp5x_init(adata->acp5x_base); >> + if (ret) { >> + dev_err(dev, "ACP init failed\n"); >> + return ret; >> + } >> + return 0; >> +} >> + >> +static const struct dev_pm_ops acp5x_pm = { >> + .runtime_suspend = snd_acp5x_suspend, >> + .runtime_resume = snd_acp5x_resume, >> + .resume = snd_acp5x_resume, > > use SET_SYSTEM_SLEEP_PM_OPS and SET_RUNTIME_PM_OPS? We will modify the code. > > also not clear why you don't have a .suspend here It was a miss. we will add .suspend callback which invokes same callback "snd_acp5x_suspend". > > And to avoid warnings use __maybe_unused for those callbacks when PM is disabled? > Agreed. We will modify the code and post the new version. >
next prev parent reply other threads:[~2021-07-08 11:23 UTC|newest] Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-07 5:56 [PATCH 00/12] Add Vangogh ACP ASoC driver Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 01/12] ASoC: amd: add Vangogh ACP5x IP register header Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 02/12] ASoC: amd: add Vangogh ACP PCI driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:17 ` Mark Brown 2021-07-07 16:17 ` Mark Brown 2021-07-08 14:07 ` Mukunda,Vijendar 2021-07-08 14:07 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 03/12] add acp5x init/de-init functions Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:15 ` Pierre-Louis Bossart 2021-07-07 16:15 ` Pierre-Louis Bossart 2021-07-08 13:30 ` Mukunda,Vijendar 2021-07-08 13:30 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 04/12] ASoC: amd: create acp5x platform devices Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:22 ` Mark Brown 2021-07-07 16:22 ` Mark Brown 2021-07-08 15:02 ` Mukunda,Vijendar 2021-07-08 15:02 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 05/12] ASoC: amd: add ACP5x PCM platform driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:17 ` Pierre-Louis Bossart 2021-07-07 16:17 ` Pierre-Louis Bossart 2021-07-08 13:31 ` Mukunda,Vijendar 2021-07-08 13:31 ` Mukunda,Vijendar 2021-07-07 16:24 ` Mark Brown 2021-07-07 16:24 ` Mark Brown 2021-07-08 11:57 ` Mukunda,Vijendar 2021-07-08 11:57 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 06/12] ASoC: amd: irq handler changes for ACP5x PCM dma driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:20 ` Pierre-Louis Bossart 2021-07-07 16:20 ` Pierre-Louis Bossart 2021-07-08 13:32 ` Mukunda,Vijendar 2021-07-08 13:32 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 07/12] ASoC: amd: add ACP5x pcm dma driver ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:27 ` Pierre-Louis Bossart 2021-07-07 16:27 ` Pierre-Louis Bossart 2021-07-08 11:56 ` Mukunda,Vijendar 2021-07-08 11:56 ` Mukunda,Vijendar 2021-07-07 16:30 ` Mark Brown 2021-07-07 16:30 ` Mark Brown 2021-07-08 11:43 ` Mukunda,Vijendar 2021-07-08 11:43 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 08/12] ASoC: amd: add vangogh i2s controller driver Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 09/12] ASoC: amd: add vangogh i2s dai driver ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:35 ` Mark Brown 2021-07-07 16:35 ` Mark Brown 2021-07-08 11:30 ` Mukunda,Vijendar 2021-07-08 11:30 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 10/12] ASoC: amd: add vangogh pci driver pm ops Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 16:34 ` Pierre-Louis Bossart 2021-07-07 16:34 ` Pierre-Louis Bossart 2021-07-08 11:41 ` Mukunda,Vijendar [this message] 2021-07-08 11:41 ` Mukunda,Vijendar 2021-07-13 6:36 ` Mukunda,Vijendar 2021-07-13 6:36 ` Mukunda,Vijendar 2021-07-14 16:23 ` Mark Brown 2021-07-15 23:49 ` Mukunda,Vijendar 2021-07-07 5:56 ` [PATCH 11/12] ASoc: amd: add vangogh i2s dma " Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 5:56 ` [PATCH 12/12] ASoC: amd: enable vangogh acp5x driver build Vijendar Mukunda 2021-07-07 5:56 ` Vijendar Mukunda 2021-07-07 9:00 ` kernel test robot 2021-07-07 9:00 ` kernel test robot 2021-07-07 9:00 ` kernel test robot 2021-07-08 14:08 ` Mukunda,Vijendar 2021-07-08 14:08 ` Mukunda, Vijendar 2021-07-08 14:08 ` Mukunda,Vijendar 2021-07-07 16:55 ` [PATCH 00/12] Add Vangogh ACP ASoC driver Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b754ef05-065d-ee7b-754f-1498f7c6cff6@amd.com \ --to=vijendar.mukunda@amd.com \ --cc=Alexander.Deucher@amd.com \ --cc=Sunil-kumar.Dommati@amd.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.