From: Antonio Quartulli <a@unstable.cc> To: Sven Eckelmann <sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org> Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org>, Jiri Pirko <jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org>, Marek Lindner <mareklindner-rVWd3aGhH2z5bpWLKbzFeg@public.gmane.org> Subject: Re: [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute Date: Sat, 4 Aug 2018 17:08:42 +0800 [thread overview] Message-ID: <b8b8da51-48f5-0553-ac02-4ea79c6e1389@unstable.cc> (raw) In-Reply-To: <2057936.2F7DdePauk@sven-edge> [-- Attachment #1.1: Type: text/plain, Size: 1782 bytes --] Hi, On 04/08/18 17:02, Sven Eckelmann wrote: > On Samstag, 4. August 2018 10:41:09 CEST Antonio Quartulli wrote: > [...] >>>> Documentation/ABI/testing/sysfs-class-net-batman-adv | 7 +++++++ >>> >>> Please discuss this with Jiri [1]. >>> >> >> After re-reading Jiri's points I can't really understand why we should >> now switch to netlink. I think all our sysfs knobs are used to inject >> settings *to* userspace, therefore his point 1) does not really apply to >> us. Point 2) is a bit generic and does not really explain why we should >> *switch*. > > Wouldn't it have been better when Jiri would also see your reply? Now he isn't > even aware of your criticism. > >> This said, I'd rather keep this patch as it is and possibly discuss the >> matter when sending this code to netdev for merging. >> >> I've discussed this with Marek too and he is fine with this approach. > > Interesting, I don't see it this way. This patch [0] is for netdev and we have > the statement that "usage of sysfs in netdev subsystem is frowned upon". Now > you want that we ignore that and than maybe Simon have to deal with the > fallout when he forwards it to David? Nope, I'd rather step in myself, should David or anybody else complain about the patch once sent to netdev. But I totally understand your point. Personally I did not see Jiri's statements as representative of netdev as a whole, but it looked like his personal opinion to me (I might be wrong). I will reply to [1] directly so we can take the discussion from there then. Cheers, > > Kind regards, > Sven > > [0] https://patchwork.open-mesh.org/patch/17372/ > >>> [1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2018-May/017814.html -- Antonio Quartulli [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <a@unstable.cc> To: Sven Eckelmann <sven@narfation.org> Cc: The list for a Better Approach To Mobile Ad-hoc Networking <b.a.t.m.a.n@lists.open-mesh.org>, Marek Lindner <mareklindner@neomailbox.ch>, Jiri Pirko <jiri@resnulli.us>, netdev@vger.kernel.org Subject: Re: [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute Date: Sat, 4 Aug 2018 17:08:42 +0800 [thread overview] Message-ID: <b8b8da51-48f5-0553-ac02-4ea79c6e1389@unstable.cc> (raw) In-Reply-To: <2057936.2F7DdePauk@sven-edge> [-- Attachment #1.1: Type: text/plain, Size: 1782 bytes --] Hi, On 04/08/18 17:02, Sven Eckelmann wrote: > On Samstag, 4. August 2018 10:41:09 CEST Antonio Quartulli wrote: > [...] >>>> Documentation/ABI/testing/sysfs-class-net-batman-adv | 7 +++++++ >>> >>> Please discuss this with Jiri [1]. >>> >> >> After re-reading Jiri's points I can't really understand why we should >> now switch to netlink. I think all our sysfs knobs are used to inject >> settings *to* userspace, therefore his point 1) does not really apply to >> us. Point 2) is a bit generic and does not really explain why we should >> *switch*. > > Wouldn't it have been better when Jiri would also see your reply? Now he isn't > even aware of your criticism. > >> This said, I'd rather keep this patch as it is and possibly discuss the >> matter when sending this code to netdev for merging. >> >> I've discussed this with Marek too and he is fine with this approach. > > Interesting, I don't see it this way. This patch [0] is for netdev and we have > the statement that "usage of sysfs in netdev subsystem is frowned upon". Now > you want that we ignore that and than maybe Simon have to deal with the > fallout when he forwards it to David? Nope, I'd rather step in myself, should David or anybody else complain about the patch once sent to netdev. But I totally understand your point. Personally I did not see Jiri's statements as representative of netdev as a whole, but it looked like his personal opinion to me (I might be wrong). I will reply to [1] directly so we can take the discussion from there then. Cheers, > > Kind regards, > Sven > > [0] https://patchwork.open-mesh.org/patch/17372/ > >>> [1] https://lists.open-mesh.org/pipermail/b.a.t.m.a.n/2018-May/017814.html -- Antonio Quartulli [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-08-04 9:08 UTC|newest] Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-05-18 1:47 [B.A.T.M.A.N.] [PATCH v2 0/7] B.A.T.M.A.N. V - fallback to tp meter estimation if throughput otherwise not available Marek Lindner 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 1/7] batman-adv: tp_meter - prevent concurrent tp_meter sessions by using workqueue Marek Lindner 2018-08-29 6:56 ` Sven Eckelmann 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 2/7] batman-adv: tp_meter - don't check for existing session Marek Lindner 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 3/7] batman-adv: tp_meter - allow up to 10 queued sessions Marek Lindner 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 4/7] batman-adv: tp_meter - add caller distinction Marek Lindner 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 5/7] batman-adv: tp_meter - add option to perform one-hop test Marek Lindner 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 6/7] batman-adv: ELP - use tp meter to estimate the throughput if otherwise not available Marek Lindner 2018-05-21 13:17 ` Linus Lüssing 2018-05-21 17:51 ` Sven Eckelmann 2018-05-21 19:06 ` Sven Eckelmann 2018-08-04 9:31 ` Antonio Quartulli 2018-05-21 14:43 ` Linus Lüssing 2018-08-04 9:35 ` Marek Lindner 2018-05-21 14:48 ` Linus Lüssing 2018-08-04 9:39 ` Antonio Quartulli 2018-05-21 15:01 ` Linus Lüssing 2018-08-04 8:59 ` Antonio Quartulli 2018-05-21 16:36 ` Sven Eckelmann 2018-05-18 1:47 ` [B.A.T.M.A.N.] [PATCH v2 7/7] batman-adv: ELP - add throughput meter test duration attribute Marek Lindner 2018-05-21 13:46 ` Linus Lüssing 2018-05-21 13:57 ` Linus Lüssing 2018-08-04 9:05 ` Marek Lindner 2018-05-21 14:34 ` Sven Eckelmann 2018-08-04 8:41 ` Antonio Quartulli [not found] ` <314bf0ac-4c10-da7a-d527-45afe92423fa-2CpIooy/SPIKlTDg6p0iyA@public.gmane.org> 2018-08-04 9:02 ` Sven Eckelmann 2018-08-04 9:02 ` [B.A.T.M.A.N.] " Sven Eckelmann 2018-08-04 9:08 ` Antonio Quartulli [this message] 2018-08-04 9:08 ` Antonio Quartulli
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=b8b8da51-48f5-0553-ac02-4ea79c6e1389@unstable.cc \ --to=a@unstable.cc \ --cc=b.a.t.m.a.n-ZwoEplunGu2X36UT3dwllkB+6BGkLq7r@public.gmane.org \ --cc=jiri-rHqAuBHg3fBzbRFIqnYvSA@public.gmane.org \ --cc=mareklindner-rVWd3aGhH2z5bpWLKbzFeg@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=sven-KaDOiPu9UxWEi8DpZVb4nw@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.