All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Correct 'so'
@ 2021-03-10 14:58 ` Xiaofeng Cao
  0 siblings, 0 replies; 4+ messages in thread
From: Xiaofeng Cao @ 2021-03-10 14:58 UTC (permalink / raw)
  To: mchehab, patrice.chotard
  Cc: linux-media, linux-kernel, linux-arm-kernel, Xiaofeng Cao

In Kconfig it should be 'to'
In c8sectpfe-core.c it should be 'do'

Signed-off-by: Xiaofeng Cao <cxfcosmos@gmail.com>
---
 drivers/media/Kconfig                                 | 2 +-
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 6222b3ae220b..b07812657cee 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
 	  This is found on Embedded hardware (SoC), on V4L2 codecs and
 	  on some GPU and newer CPU chipsets.
 
-	  Say Y when you want to be able so see such devices.
+	  Say Y when you want to be able to see such devices.
 
 config MEDIA_TEST_SUPPORT
 	bool
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index a7a6ea666740..338b205ae3a7 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
 
 	/*
 	 * TODO FIXME we should detect some error conditions here
-	 * and ideally so something about them!
+	 * and ideally do something about them!
 	 */
 
 	return IRQ_HANDLED;
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH] Correct 'so'
@ 2021-03-10 14:58 ` Xiaofeng Cao
  0 siblings, 0 replies; 4+ messages in thread
From: Xiaofeng Cao @ 2021-03-10 14:58 UTC (permalink / raw)
  To: mchehab, patrice.chotard
  Cc: linux-media, linux-kernel, linux-arm-kernel, Xiaofeng Cao

In Kconfig it should be 'to'
In c8sectpfe-core.c it should be 'do'

Signed-off-by: Xiaofeng Cao <cxfcosmos@gmail.com>
---
 drivers/media/Kconfig                                 | 2 +-
 drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
index 6222b3ae220b..b07812657cee 100644
--- a/drivers/media/Kconfig
+++ b/drivers/media/Kconfig
@@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
 	  This is found on Embedded hardware (SoC), on V4L2 codecs and
 	  on some GPU and newer CPU chipsets.
 
-	  Say Y when you want to be able so see such devices.
+	  Say Y when you want to be able to see such devices.
 
 config MEDIA_TEST_SUPPORT
 	bool
diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
index a7a6ea666740..338b205ae3a7 100644
--- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
+++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
@@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
 
 	/*
 	 * TODO FIXME we should detect some error conditions here
-	 * and ideally so something about them!
+	 * and ideally do something about them!
 	 */
 
 	return IRQ_HANDLED;
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] Correct 'so'
  2021-03-10 14:58 ` Xiaofeng Cao
@ 2021-03-10 17:19   ` Randy Dunlap
  -1 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-03-10 17:19 UTC (permalink / raw)
  To: Xiaofeng Cao, mchehab, patrice.chotard
  Cc: linux-media, linux-kernel, linux-arm-kernel

On 3/10/21 6:58 AM, Xiaofeng Cao wrote:
> In Kconfig it should be 'to'
> In c8sectpfe-core.c it should be 'do'
> 
> Signed-off-by: Xiaofeng Cao <cxfcosmos@gmail.com>

The Subject: could use some work, but the patch contents look good.
Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/media/Kconfig                                 | 2 +-
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 6222b3ae220b..b07812657cee 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
>  	  This is found on Embedded hardware (SoC), on V4L2 codecs and
>  	  on some GPU and newer CPU chipsets.
>  
> -	  Say Y when you want to be able so see such devices.
> +	  Say Y when you want to be able to see such devices.
>  
>  config MEDIA_TEST_SUPPORT
>  	bool
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index a7a6ea666740..338b205ae3a7 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
>  
>  	/*
>  	 * TODO FIXME we should detect some error conditions here
> -	 * and ideally so something about them!
> +	 * and ideally do something about them!
>  	 */
>  
>  	return IRQ_HANDLED;
> 


-- 
~Randy


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] Correct 'so'
@ 2021-03-10 17:19   ` Randy Dunlap
  0 siblings, 0 replies; 4+ messages in thread
From: Randy Dunlap @ 2021-03-10 17:19 UTC (permalink / raw)
  To: Xiaofeng Cao, mchehab, patrice.chotard
  Cc: linux-media, linux-kernel, linux-arm-kernel

On 3/10/21 6:58 AM, Xiaofeng Cao wrote:
> In Kconfig it should be 'to'
> In c8sectpfe-core.c it should be 'do'
> 
> Signed-off-by: Xiaofeng Cao <cxfcosmos@gmail.com>

The Subject: could use some work, but the patch contents look good.
Thanks.

Acked-by: Randy Dunlap <rdunlap@infradead.org>

> ---
>  drivers/media/Kconfig                                 | 2 +-
>  drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> index 6222b3ae220b..b07812657cee 100644
> --- a/drivers/media/Kconfig
> +++ b/drivers/media/Kconfig
> @@ -134,7 +134,7 @@ config MEDIA_PLATFORM_SUPPORT
>  	  This is found on Embedded hardware (SoC), on V4L2 codecs and
>  	  on some GPU and newer CPU chipsets.
>  
> -	  Say Y when you want to be able so see such devices.
> +	  Say Y when you want to be able to see such devices.
>  
>  config MEDIA_TEST_SUPPORT
>  	bool
> diff --git a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> index a7a6ea666740..338b205ae3a7 100644
> --- a/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> +++ b/drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c
> @@ -655,7 +655,7 @@ static irqreturn_t c8sectpfe_error_irq_handler(int irq, void *priv)
>  
>  	/*
>  	 * TODO FIXME we should detect some error conditions here
> -	 * and ideally so something about them!
> +	 * and ideally do something about them!
>  	 */
>  
>  	return IRQ_HANDLED;
> 


-- 
~Randy


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2021-03-10 17:21 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-10 14:58 [PATCH] Correct 'so' Xiaofeng Cao
2021-03-10 14:58 ` Xiaofeng Cao
2021-03-10 17:19 ` Randy Dunlap
2021-03-10 17:19   ` Randy Dunlap

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.