All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-aspeed <linux-aspeed@lists.ozlabs.org>,
	David Wang <David_Wang6097@jabil.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Steven Lee <steven_lee@aspeedtech.com>,
	Ken Chen <chen.kenyy@inventec.com>
Subject: Re: [PATCH 2/7] dt-bindings: arm: aspeed: document board compatibles
Date: Thu, 23 Jun 2022 09:10:34 +0200	[thread overview]
Message-ID: <bd070c5d-4765-092d-8f10-fefd0361f65e@linaro.org> (raw)
In-Reply-To: <CACPK8Xc=dmaJtLXGsQa8bBdWDnSbwyW3f_yaQr4HqT0WvyScRg@mail.gmail.com>

On 23/06/2022 07:36, Joel Stanley wrote:
> On Mon, 20 Jun 2022 at 11:06, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
>>> Document all compatibles used in existing upstreamed Aspeed AST2400,
>>> AST2500 and AST2600 based boards.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>  .../bindings/arm/aspeed/aspeed.yaml           | 83 +++++++++++++++++++
>>>  MAINTAINERS                                   |  1 +
>>>  2 files changed, 84 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>
>> Joel, Andrew,
>>
>> Any comments on the series? Rob applied only patch 1, so the rest is
>> supposed through Aspeed tree. Shall I pick them up and send to arm-soc?
> 
> I will take a look at them when it's time to send patches for the next
> kernel release.

But that's not how the next development works. Patches, if proper/good,
should be applied in some reasonable amount of time and then sit in
maintainers tree. This way the patches will be in linux-next, assuming
that maintainer correctly added it to linux-next. All other people can
then easily base their work on linux-next or maintainer's tree and
continue their development.

Waiting with the patches till time to intreract with arm-soc (usually
some late in the cycle, like rc5-rc6), not providing review, does not
allow other people to see accepted contributions and base the work on them.

Really, there is no single reason to hold on patches till there is time
to send them to arm-soc. It's the first time I hear something like this
about SoC or any other tree.

> 
> They should go through the aspeed tree like the rest of the aspeed
> device tree patches.

Of course, but somehow they were not going...

Best regards,
Krzysztof

WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Joel Stanley <joel@jms.id.au>
Cc: Andrew Jeffery <andrew@aj.id.au>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	linux-aspeed <linux-aspeed@lists.ozlabs.org>,
	David Wang <David_Wang6097@jabil.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	Steven Lee <steven_lee@aspeedtech.com>,
	Ken Chen <chen.kenyy@inventec.com>
Subject: Re: [PATCH 2/7] dt-bindings: arm: aspeed: document board compatibles
Date: Thu, 23 Jun 2022 09:10:34 +0200	[thread overview]
Message-ID: <bd070c5d-4765-092d-8f10-fefd0361f65e@linaro.org> (raw)
In-Reply-To: <CACPK8Xc=dmaJtLXGsQa8bBdWDnSbwyW3f_yaQr4HqT0WvyScRg@mail.gmail.com>

On 23/06/2022 07:36, Joel Stanley wrote:
> On Mon, 20 Jun 2022 at 11:06, Krzysztof Kozlowski
> <krzysztof.kozlowski@linaro.org> wrote:
>>
>> On 29/05/2022 12:49, Krzysztof Kozlowski wrote:
>>> Document all compatibles used in existing upstreamed Aspeed AST2400,
>>> AST2500 and AST2600 based boards.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>> ---
>>>  .../bindings/arm/aspeed/aspeed.yaml           | 83 +++++++++++++++++++
>>>  MAINTAINERS                                   |  1 +
>>>  2 files changed, 84 insertions(+)
>>>  create mode 100644 Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
>>
>> Joel, Andrew,
>>
>> Any comments on the series? Rob applied only patch 1, so the rest is
>> supposed through Aspeed tree. Shall I pick them up and send to arm-soc?
> 
> I will take a look at them when it's time to send patches for the next
> kernel release.

But that's not how the next development works. Patches, if proper/good,
should be applied in some reasonable amount of time and then sit in
maintainers tree. This way the patches will be in linux-next, assuming
that maintainer correctly added it to linux-next. All other people can
then easily base their work on linux-next or maintainer's tree and
continue their development.

Waiting with the patches till time to intreract with arm-soc (usually
some late in the cycle, like rc5-rc6), not providing review, does not
allow other people to see accepted contributions and base the work on them.

Really, there is no single reason to hold on patches till there is time
to send them to arm-soc. It's the first time I hear something like this
about SoC or any other tree.

> 
> They should go through the aspeed tree like the rest of the aspeed
> device tree patches.

Of course, but somehow they were not going...

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-23  7:10 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-29 10:49 [PATCH 1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards Krzysztof Kozlowski
2022-05-29 10:49 ` Krzysztof Kozlowski
2022-05-29 10:49 ` [PATCH 2/7] dt-bindings: arm: aspeed: document board compatibles Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-20 11:06   ` Krzysztof Kozlowski
2022-06-20 11:06     ` Krzysztof Kozlowski
2022-06-22 10:10     ` Krzysztof Kozlowski
2022-06-22 10:10       ` Krzysztof Kozlowski
2022-06-23  5:36     ` Joel Stanley
2022-06-23  5:36       ` Joel Stanley
2022-06-23  7:10       ` Krzysztof Kozlowski [this message]
2022-06-23  7:10         ` Krzysztof Kozlowski
2022-06-22 10:14   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:14     ` Krzysztof Kozlowski
2022-05-29 10:49 ` [PATCH 3/7] dt-bindings: arm: aspeed: add Aspeed Evaluation boards Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-06 19:26   ` Rob Herring
2022-06-06 19:26     ` Rob Herring
2022-06-22 10:16   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:16     ` Krzysztof Kozlowski
2022-05-29 10:49 ` [PATCH 4/7] ARM: dts: ast2500-evb: fix board compatible Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-22 10:17   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:17     ` Krzysztof Kozlowski
2022-07-22  2:43   ` Andrew Jeffery
2022-07-22  2:43     ` Andrew Jeffery
2022-05-29 10:49 ` [PATCH 5/7] ARM: dts: ast2600-evb: " Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-22 10:17   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:17     ` Krzysztof Kozlowski
2022-05-29 10:49 ` [PATCH 6/7] ARM: dts: ast2600-evb-a1: " Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-22 10:17   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:17     ` Krzysztof Kozlowski
2022-05-29 10:49 ` [PATCH 7/7] ARM: dts: aspeed: centriq2400: use qcom compatible Krzysztof Kozlowski
2022-05-29 10:49   ` Krzysztof Kozlowski
2022-06-22 10:17   ` (subset) " Krzysztof Kozlowski
2022-06-22 10:17     ` Krzysztof Kozlowski
2022-06-23  5:34     ` Joel Stanley
2022-06-23  5:34       ` Joel Stanley
2022-06-23  7:05       ` Krzysztof Kozlowski
2022-06-23  7:05         ` Krzysztof Kozlowski
2022-06-24  7:12         ` Krzysztof Kozlowski
2022-06-24  7:12           ` Krzysztof Kozlowski
2022-07-22  2:44   ` Andrew Jeffery
2022-07-22  2:44     ` Andrew Jeffery
2022-06-09  8:50 ` [PATCH 1/7] dt-bindings: vendor-prefixes: document several vendors for Aspeed BMC boards Krzysztof Kozlowski
2022-06-09  8:50   ` Krzysztof Kozlowski
2022-07-21  2:34   ` Andrew Jeffery
2022-07-21  2:34     ` Andrew Jeffery
2022-07-21  6:30     ` Krzysztof Kozlowski
2022-07-21  6:30       ` Krzysztof Kozlowski
2022-07-21  7:25       ` Krzysztof Kozlowski
2022-07-21  7:25         ` Krzysztof Kozlowski
2022-06-09 20:43 ` Rob Herring
2022-06-09 20:43   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bd070c5d-4765-092d-8f10-fefd0361f65e@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=David_Wang6097@jabil.com \
    --cc=andrew@aj.id.au \
    --cc=arnd@arndb.de \
    --cc=chen.kenyy@inventec.com \
    --cc=devicetree@vger.kernel.org \
    --cc=joel@jms.id.au \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-aspeed@lists.ozlabs.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=steven_lee@aspeedtech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.