* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
@ 2012-04-28 6:23 ` bugzilla-daemon
2012-05-22 9:50 ` bugzilla-daemon
` (11 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-04-28 6:23 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #1 from Karl Tomlinson <bugs.freedesktop@karlt.net> 2012-04-27 23:23:21 PDT ---
Similar crash in glXDestroyContext from kwin, or Firefox's glxtest.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
2012-04-28 6:23 ` [Bug 49198] " bugzilla-daemon
@ 2012-05-22 9:50 ` bugzilla-daemon
2012-05-22 10:11 ` bugzilla-daemon
` (10 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 9:50 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #2 from Karl Tomlinson <bugs.freedesktop@karlt.net> 2012-05-22 02:50:17 PDT ---
Bisection gives good: 3b3d2e53bc11f9b5fbda812953700b216cd8ab93
bad:
http://cgit.freedesktop.org/mesa/mesa/commit/?id=210ddf0819b5acf87a614214b6d4b02193aafa4a
(Bug still exists in git 8a933e36d1f91d3b8a5377a8d23c2dcdd403e8ad.)
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
2012-04-28 6:23 ` [Bug 49198] " bugzilla-daemon
2012-05-22 9:50 ` bugzilla-daemon
@ 2012-05-22 10:11 ` bugzilla-daemon
2012-05-22 10:26 ` bugzilla-daemon
` (9 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 10:11 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
Michel Dänzer <michel@daenzer.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.b.lankhorst@gmail.com
Component|Drivers/DRI/R600 |Drivers/Gallium/r600
--- Comment #3 from Michel Dänzer <michel@daenzer.net> 2012-05-22 03:11:05 PDT ---
Maarten, any ideas?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (2 preceding siblings ...)
2012-05-22 10:11 ` bugzilla-daemon
@ 2012-05-22 10:26 ` bugzilla-daemon
2012-05-22 11:36 ` bugzilla-daemon
` (8 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 10:26 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
m.b.lankhorst@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
--- Comment #4 from m.b.lankhorst@gmail.com 2012-05-22 03:26:10 PDT ---
Woops, looks like I just did overkill.
pthread_detach is not needed after a pthread_join, so just remove the
pipe_thread_destroy call.
I was probably looking at win32 too much at the time, where a thread handle has
to be closed after you wait for the thread to terminate.
I posted the patch to mesa-dev, but in any case shouldn't libpthread be at
least handling this slightly more gracefully than a crash?
diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
index 2239059..168f455 100644
--- a/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
+++ b/src/gallium/winsys/radeon/drm/radeon_drm_cs.c
@@ -469,7 +469,6 @@ static void radeon_drm_cs_destroy(struct radeon_winsys_cs
*rcs)
pipe_semaphore_signal(&cs->flush_queued);
pipe_semaphore_wait(&cs->flush_completed);
pipe_thread_wait(cs->thread);
- pipe_thread_destroy(cs->thread);
}
pipe_semaphore_destroy(&cs->flush_queued);
pipe_semaphore_destroy(&cs->flush_completed);
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply related [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (3 preceding siblings ...)
2012-05-22 10:26 ` bugzilla-daemon
@ 2012-05-22 11:36 ` bugzilla-daemon
2012-05-22 14:44 ` bugzilla-daemon
` (7 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 11:36 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #5 from Andre Heider <a.heider@gmail.com> 2012-05-22 04:36:26 PDT ---
This looks dangerous:
1) pipe_semaphore_signal(&cs->flush_queued);
2) pipe_semaphore_wait(&cs->flush_completed);
3) pipe_thread_wait(cs->thread);
There's no guarantee that pipe_semaphore_signal(&cs->flush_completed) in
radeon_drm_cs_emit_ioctl() is executed after 2).
Getting rid of 2) should fix that and it would be safe since 3) blocks until
radeon_drm_cs_emit_ioctl() returns.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (4 preceding siblings ...)
2012-05-22 11:36 ` bugzilla-daemon
@ 2012-05-22 14:44 ` bugzilla-daemon
2012-05-22 15:42 ` bugzilla-daemon
` (6 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 14:44 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #6 from m.b.lankhorst@gmail.com 2012-05-22 07:44:12 PDT ---
What do you mean? flush_completed is always explicitly signalled before the
flush thread is exiting, see right before the 'return NULL'
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (5 preceding siblings ...)
2012-05-22 14:44 ` bugzilla-daemon
@ 2012-05-22 15:42 ` bugzilla-daemon
2012-05-22 15:46 ` bugzilla-daemon
` (5 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 15:42 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #7 from Andre Heider <a.heider@gmail.com> 2012-05-22 08:42:42 PDT ---
Well, I just skimmed over the patch, so maybe I'm missing something, but what
I'm seeing is: 2 threads
a) runs radeon_drm_cs_destroy()
b) runs radeon_drm_cs_emit_ioctl()
When e.g. a context switch occurs on thread a) between 1) and 2) then thread b)
can run pipe_semaphore_signal(&cs->flush_completed) before a) runs
pipe_semaphore_wait(&cs->flush_completed).
The former will effectively be a noop since no other thread is waiting and the
latter will block forever.
No?
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (6 preceding siblings ...)
2012-05-22 15:42 ` bugzilla-daemon
@ 2012-05-22 15:46 ` bugzilla-daemon
2012-05-22 16:03 ` bugzilla-daemon
` (4 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 15:46 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #8 from m.b.lankhorst@gmail.com 2012-05-22 08:46:31 PDT ---
You're complaining about undefined behavior in a destruction handler?
When you call radeon_drm_cs_destroy, you better make damned well sure you've
finished using it first, you have bigger problems than a deadlock otherwise.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (7 preceding siblings ...)
2012-05-22 15:46 ` bugzilla-daemon
@ 2012-05-22 16:03 ` bugzilla-daemon
2012-09-19 10:20 ` bugzilla-daemon
` (3 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-05-22 16:03 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #9 from Andre Heider <a.heider@gmail.com> 2012-05-22 09:03:31 PDT ---
Merely pointing out what I noticed, which might be unrelated to its correctness
;)
And that's that the handler itself triggers thread b) and hence might deadlock,
unrelated to additional users.
But if I'm indeed seeing ghosts please ignore the false alarm.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (8 preceding siblings ...)
2012-05-22 16:03 ` bugzilla-daemon
@ 2012-09-19 10:20 ` bugzilla-daemon
2012-09-19 13:17 ` bugzilla-daemon
` (2 subsequent siblings)
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-09-19 10:20 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
Paul Menzel <paulepanter@users.sourceforge.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paulepanter@users.sourcefor
| |ge.net
--- Comment #10 from Paul Menzel <paulepanter@users.sourceforge.net> 2012-09-19 10:20:58 UTC ---
Could somebody please give an update on this issue? Was a fix committed?
According to Michael Dänzer I might have hit this issue crashing Evolution
3.4.3-1 with a segmentation fault [1]. This is Debian Sid/unstable with Mesa
8.0.4-2.
[1] http://lists.freedesktop.org/archives/dri-devel/2012-September/028029.html
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (9 preceding siblings ...)
2012-09-19 10:20 ` bugzilla-daemon
@ 2012-09-19 13:17 ` bugzilla-daemon
2012-09-19 21:20 ` bugzilla-daemon
2012-09-20 7:27 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-09-19 13:17 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
--- Comment #11 from Paul Menzel <paulepanter@users.sourceforge.net> 2012-09-19 13:17:40 UTC ---
The Debian BTS tracks this issue under #688108 [1].
[1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=688108
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (10 preceding siblings ...)
2012-09-19 13:17 ` bugzilla-daemon
@ 2012-09-19 21:20 ` bugzilla-daemon
2012-09-20 7:27 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-09-19 21:20 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
Karl Tomlinson <bugs.freedesktop@karlt.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution| |FIXED
--- Comment #12 from Karl Tomlinson <bugs.freedesktop@karlt.net> 2012-09-19 21:20:02 UTC ---
http://cgit.freedesktop.org/mesa/mesa/commit/src/gallium/winsys/radeon/drm/radeon_drm_cs.c?id=6bb0151f1fd87b4e15f177c7122fc28fea29497e
fixes this.
That fix is not on the 8.0 branch.
ISTR a smaller stacksize limit making libpthread more tolerant to these bugs.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread
* [Bug 49198] glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context
2012-04-26 22:56 [Bug 49198] New: glxinfo SIGSEGV in pthread_detach under radeon_drm_cs_destroy under dri2_destroy_context bugzilla-daemon
` (11 preceding siblings ...)
2012-09-19 21:20 ` bugzilla-daemon
@ 2012-09-20 7:27 ` bugzilla-daemon
12 siblings, 0 replies; 14+ messages in thread
From: bugzilla-daemon @ 2012-09-20 7:27 UTC (permalink / raw)
To: dri-devel
https://bugs.freedesktop.org/show_bug.cgi?id=49198
m.b.lankhorst@gmail.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |CLOSED
--- Comment #13 from m.b.lankhorst@gmail.com 2012-09-20 07:27:45 UTC ---
Pushed to the 8.0 branch too now, commit
25da204f692c291ae3f06bbb9245131738bb80da there.
--
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
^ permalink raw reply [flat|nested] 14+ messages in thread