From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Mark Brown <broonie@kernel.org>, MTD Maling List <linux-mtd@lists.infradead.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/7] memory: renesas-rpc-if: Move resource acquisition to .probe() Date: Thu, 30 Jun 2022 10:48:46 +0200 [thread overview] Message-ID: <c04c3691-7be3-afc5-4f95-2b06ee402c0d@linaro.org> (raw) In-Reply-To: <CAMuHMdUuU4qtfYh=hpY9bWMLKAnz83Oj8f=M9_iUxmR+Zetsow@mail.gmail.com> On 29/06/2022 20:48, Geert Uytterhoeven wrote: >> >> You sure? Except rebasing I don't see that. rpcif_sw_init() received the >> rpcif so it had access to all fields. > > Yes I am, don't be misguided by the name of the local variable. > The rpcif structure is allocated by the HF or SPI child driver, > and thus not available in the RPC core driver's .probe() function. > The rpc_priv structure (as of patch 4) is allocated by the RPC core driver. > >>> I agree patches 1-3 could be moved later, if you think it is worthwhile. >> >> This would not be enough, it has to be first patch to be backportable. > > I can make it second? ;-) Why? The point is that this commit should have Fixes or Cc-stable tag. If you make it depending on other non-backportable commit, stable folks cannot pull it automatically. > Note that that still precludes (easily) backporting s2ram support. But S2R is a feature so it won't be backported... Best regards, Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Geert Uytterhoeven <geert@linux-m68k.org> Cc: Vignesh Raghavendra <vigneshr@ti.com>, Sergey Shtylyov <s.shtylyov@omp.ru>, Wolfram Sang <wsa+renesas@sang-engineering.com>, Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Mark Brown <broonie@kernel.org>, MTD Maling List <linux-mtd@lists.infradead.org>, Linux-Renesas <linux-renesas-soc@vger.kernel.org>, linux-spi <linux-spi@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 5/7] memory: renesas-rpc-if: Move resource acquisition to .probe() Date: Thu, 30 Jun 2022 10:48:46 +0200 [thread overview] Message-ID: <c04c3691-7be3-afc5-4f95-2b06ee402c0d@linaro.org> (raw) In-Reply-To: <CAMuHMdUuU4qtfYh=hpY9bWMLKAnz83Oj8f=M9_iUxmR+Zetsow@mail.gmail.com> On 29/06/2022 20:48, Geert Uytterhoeven wrote: >> >> You sure? Except rebasing I don't see that. rpcif_sw_init() received the >> rpcif so it had access to all fields. > > Yes I am, don't be misguided by the name of the local variable. > The rpcif structure is allocated by the HF or SPI child driver, > and thus not available in the RPC core driver's .probe() function. > The rpc_priv structure (as of patch 4) is allocated by the RPC core driver. > >>> I agree patches 1-3 could be moved later, if you think it is worthwhile. >> >> This would not be enough, it has to be first patch to be backportable. > > I can make it second? ;-) Why? The point is that this commit should have Fixes or Cc-stable tag. If you make it depending on other non-backportable commit, stable folks cannot pull it automatically. > Note that that still precludes (easily) backporting s2ram support. But S2R is a feature so it won't be backported... Best regards, Krzysztof ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2022-06-30 8:48 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-27 15:31 [PATCH 0/7] memory: renesas-rpc-if: Rebind and s2ram fixes Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 1/7] memory: renesas-rpc-if: Always use dev in rpcif_sw_init() Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 2/7] memory: renesas-rpc-if: Add dev helper to rpcif_probe() Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 3/7] memory: renesas-rpc-if: Improve Runtime PM handling Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 4/7] memory: renesas-rpc-if: Split-off private data from struct rpcif Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 5/7] memory: renesas-rpc-if: Move resource acquisition to .probe() Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-29 17:44 ` Krzysztof Kozlowski 2022-06-29 17:44 ` Krzysztof Kozlowski 2022-06-29 17:55 ` Geert Uytterhoeven 2022-06-29 17:55 ` Geert Uytterhoeven 2022-06-29 18:25 ` Krzysztof Kozlowski 2022-06-29 18:25 ` Krzysztof Kozlowski 2022-06-29 18:48 ` Geert Uytterhoeven 2022-06-29 18:48 ` Geert Uytterhoeven 2022-06-30 8:48 ` Krzysztof Kozlowski [this message] 2022-06-30 8:48 ` Krzysztof Kozlowski 2022-06-30 9:15 ` Geert Uytterhoeven 2022-06-30 9:15 ` Geert Uytterhoeven 2022-06-27 15:31 ` [PATCH 6/7] memory: renesas-rpc-if: Pass device instead of rpcif to rpcif_*() Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-06-29 18:26 ` Krzysztof Kozlowski 2022-06-29 18:26 ` Krzysztof Kozlowski 2022-06-30 7:25 ` Miquel Raynal 2022-06-30 7:25 ` Miquel Raynal 2022-06-30 8:46 ` Krzysztof Kozlowski 2022-06-30 8:46 ` Krzysztof Kozlowski 2022-06-30 8:58 ` Miquel Raynal 2022-06-30 8:58 ` Miquel Raynal 2022-06-27 15:31 ` [PATCH 7/7] memory: renesas-rpc-if: Reinitialize registers during system resume Geert Uytterhoeven 2022-06-27 15:31 ` Geert Uytterhoeven 2022-11-23 14:49 ` Geert Uytterhoeven 2022-11-23 14:49 ` Geert Uytterhoeven
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c04c3691-7be3-afc5-4f95-2b06ee402c0d@linaro.org \ --to=krzysztof.kozlowski@linaro.org \ --cc=broonie@kernel.org \ --cc=geert@linux-m68k.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=miquel.raynal@bootlin.com \ --cc=prabhakar.mahadev-lad.rj@bp.renesas.com \ --cc=richard@nod.at \ --cc=s.shtylyov@omp.ru \ --cc=vigneshr@ti.com \ --cc=wsa+renesas@sang-engineering.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.