All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, Chao Yu <chao.yu@linux.dev>
Subject: Re: [PATCH] f2fs: introduce nosmall_discard mount option
Date: Sat, 31 Jul 2021 07:41:17 +0800	[thread overview]
Message-ID: <c0af2126-7383-a579-e020-6480216c46fe@kernel.org> (raw)
In-Reply-To: <YQREtmDLBNKSQViC@google.com>

On 2021/7/31 2:28, Jaegeuk Kim wrote:
> how about adding "discard_gran=[small|segment|section]", and keeping discard_map
> in the small case only? And, I think we should set the section mode for zoned
> device automatically.

Yup, better,

About the naming, it look discard_gran is not clear here, since there is another
sysfs entry /sys/fs/f2fs/<devname>/discard_granularity has the same name, and
also semantics of newly added mount option is not only control the smallest discard
size, but also indicate discard start offset should be aligned to segment or section.
So how about using: "aligned_discard=[none|segment|section]" instead?

Thanks,

WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: Chao Yu <chao.yu@linux.dev>,
	linux-kernel@vger.kernel.org,
	linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: introduce nosmall_discard mount option
Date: Sat, 31 Jul 2021 07:41:17 +0800	[thread overview]
Message-ID: <c0af2126-7383-a579-e020-6480216c46fe@kernel.org> (raw)
In-Reply-To: <YQREtmDLBNKSQViC@google.com>

On 2021/7/31 2:28, Jaegeuk Kim wrote:
> how about adding "discard_gran=[small|segment|section]", and keeping discard_map
> in the small case only? And, I think we should set the section mode for zoned
> device automatically.

Yup, better,

About the naming, it look discard_gran is not clear here, since there is another
sysfs entry /sys/fs/f2fs/<devname>/discard_granularity has the same name, and
also semantics of newly added mount option is not only control the smallest discard
size, but also indicate discard start offset should be aligned to segment or section.
So how about using: "aligned_discard=[none|segment|section]" instead?

Thanks,


_______________________________________________
Linux-f2fs-devel mailing list
Linux-f2fs-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel

  reply	other threads:[~2021-07-30 23:41 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-30 10:05 [PATCH] f2fs: introduce nosmall_discard mount option Chao Yu
2021-07-30 10:05 ` [f2fs-dev] " Chao Yu
2021-07-30 18:28 ` Jaegeuk Kim
2021-07-30 18:28   ` [f2fs-dev] " Jaegeuk Kim
2021-07-30 23:41   ` Chao Yu [this message]
2021-07-30 23:41     ` Chao Yu
2021-07-30 23:48     ` Chao Yu
2021-07-30 23:48       ` Chao Yu
2021-07-31  0:42       ` Jaegeuk Kim
2021-07-31  0:42         ` Jaegeuk Kim
2021-07-31  0:48         ` Chao Yu
2021-07-31  0:48           ` Chao Yu
2021-08-04 13:52 ` Christoph Hellwig
2021-08-04 13:52   ` [f2fs-dev] " Christoph Hellwig
2021-08-05  1:22   ` Chao Yu
2021-08-05  1:22     ` [f2fs-dev] " Chao Yu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0af2126-7383-a579-e020-6480216c46fe@kernel.org \
    --to=chao@kernel.org \
    --cc=chao.yu@linux.dev \
    --cc=jaegeuk@kernel.org \
    --cc=linux-f2fs-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.