From: sathyanarayanan kuppuswamy <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Andy Shevchenko <andy.shevchenko@gmail.com>,
Sathyanarayanan Kuppuswamy Natarajan <sathyaosid@gmail.com>
Cc: Andy Shevchenko <andy@infradead.org>,
Zha Qipeng <qipeng.zha@intel.com>,
"dvhart@infradead.org" <dvhart@infradead.org>,
Guenter Roeck <linux@roeck-us.net>,
Wim Van Sebroeck <wim@iguana.be>,
David Box <david.e.box@linux.intel.com>,
Rajneesh Bhardwaj <rajneesh.bhardwaj@intel.com>,
Platform Driver <platform-driver-x86@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's
Date: Tue, 4 Apr 2017 13:14:37 -0700 [thread overview]
Message-ID: <c158bcb3-c6c2-3f81-c38b-6a63e6c1af5e@linux.intel.com> (raw)
In-Reply-To: <CAHp75VdZmQyo8ZwLgbybzUvEzYj+upxR74Ah0ViVBB=Ykk+Dsw@mail.gmail.com>
Hi Andy,
On 04/04/2017 06:23 AM, Andy Shevchenko wrote:
> On Mon, Apr 3, 2017 at 4:51 AM, Sathyanarayanan Kuppuswamy Natarajan
> <sathyaosid@gmail.com> wrote:
>
>>>> +static inline int is_gcr_valid(u32 offset)
>>> Pointer to ipcdev should be a parameter to this function.
>> But ipcdev is a static variable, visible across this file. So there is
>> no point in passing it as parameter.
> That's one of refactoring needed for this library. You need to pass a
> pointer to all internal functions and where it's possible to avoid
> reference to a global variable.
Yes, I have included this into the list of issues that needs to fixed
during the refactoring effort.
>
--
Sathyanarayanan Kuppuswamy
Android kernel developer
next prev parent reply other threads:[~2017-04-04 20:19 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-18 2:06 [PATCH v3 1/5] platform/x86: intel_pmc_ipc: fix gcr offset Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` [PATCH v3 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-31 13:47 ` Rajneesh Bhardwaj
2017-03-31 13:47 ` Rajneesh Bhardwaj
2017-03-18 2:06 ` [PATCH v3 3/5] watchdog: iTCO_wdt: Add PMC specific noreboot update api Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-28 9:12 ` [v3,3/5] " Guenter Roeck
2017-03-28 9:12 ` Guenter Roeck
2017-03-28 9:12 ` Guenter Roeck
2017-03-18 2:06 ` [PATCH v3 4/5] platform/x86: intel_pmc_ipc: Fix iTCO GCS memory mapping failure Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-31 14:01 ` Rajneesh Bhardwaj
2017-03-31 14:01 ` Rajneesh Bhardwaj
2017-03-31 17:22 ` sathyanarayanan kuppuswamy
2017-03-31 17:22 ` sathyanarayanan kuppuswamy
2017-03-31 17:22 ` sathyanarayanan kuppuswamy
2017-03-18 2:06 ` [PATCH v3 5/5] platform/x86: intel_pmc_ipc: use gcr mem base for S0ix counter read Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-18 2:06 ` Kuppuswamy Sathyanarayanan
2017-03-31 13:54 ` Rajneesh Bhardwaj
2017-03-31 13:54 ` Rajneesh Bhardwaj
2017-03-31 13:54 ` Rajneesh Bhardwaj
2017-03-31 15:08 ` Shanth Murthy
2017-03-31 15:08 ` Shanth Murthy
2017-03-31 13:37 ` [PATCH v3 1/5] platform/x86: intel_pmc_ipc: fix gcr offset Rajneesh Bhardwaj
2017-03-31 13:37 ` Rajneesh Bhardwaj
2017-03-31 23:27 ` [PATCH v4 " Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` [PATCH v4 2/5] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-04-02 13:58 ` Andy Shevchenko
2017-04-02 13:58 ` Andy Shevchenko
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-04 13:23 ` Andy Shevchenko
2017-04-04 13:23 ` Andy Shevchenko
2017-04-04 20:14 ` sathyanarayanan kuppuswamy [this message]
2017-04-04 20:14 ` sathyanarayanan kuppuswamy
2017-03-31 23:27 ` [PATCH v4 3/5] watchdog: iTCO_wdt: Add PMC specific noreboot update api Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-04-02 14:04 ` Andy Shevchenko
2017-04-02 14:04 ` Andy Shevchenko
2017-04-03 1:55 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:55 ` Sathyanarayanan Kuppuswamy Natarajan
2017-03-31 23:27 ` [PATCH v4 4/5] platform/x86: intel_pmc_ipc: Fix iTCO GCS memory mapping failure Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-04-02 14:10 ` Andy Shevchenko
2017-04-02 14:10 ` Andy Shevchenko
2017-04-03 1:53 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:53 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:53 ` Sathyanarayanan Kuppuswamy Natarajan
2017-03-31 23:27 ` [PATCH v4 5/5] platform/x86: intel_pmc_ipc: use gcr mem base for S0ix counter read Kuppuswamy Sathyanarayanan
2017-03-31 23:27 ` Kuppuswamy Sathyanarayanan
2017-04-02 14:11 ` [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset Andy Shevchenko
2017-04-02 14:11 ` Andy Shevchenko
2017-04-02 14:11 ` Andy Shevchenko
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-03 1:51 ` Sathyanarayanan Kuppuswamy Natarajan
2017-04-04 0:24 ` [PATCH v5 1/6] " Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` [PATCH v5 2/6] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 13:53 ` Andy Shevchenko
2017-04-04 13:53 ` Andy Shevchenko
2017-04-04 22:07 ` sathyanarayanan kuppuswamy
2017-04-04 22:07 ` sathyanarayanan kuppuswamy
2017-04-04 22:07 ` sathyanarayanan kuppuswamy
2017-04-04 0:24 ` [PATCH v5 3/6] watchdog: iTCO_wdt: Add PMC specific noreboot update api Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 13:48 ` Andy Shevchenko
2017-04-04 13:48 ` Andy Shevchenko
2017-04-04 0:24 ` [PATCH v5 4/6] watchdog: iTCO_wdt: cleanup set/unset no_reboot calls Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 3:22 ` Guenter Roeck
2017-04-04 3:22 ` Guenter Roeck
2017-04-04 3:22 ` Guenter Roeck
2017-04-04 13:49 ` Andy Shevchenko
2017-04-04 13:49 ` Andy Shevchenko
2017-04-04 0:24 ` [PATCH v5 5/6] platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory mapping failure Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 13:53 ` Andy Shevchenko
2017-04-04 13:53 ` Andy Shevchenko
2017-04-04 0:24 ` [PATCH v5 6/6] platform/x86: intel_pmc_ipc: use gcr mem base for S0ix counter read Kuppuswamy Sathyanarayanan
2017-04-04 0:24 ` Kuppuswamy Sathyanarayanan
2017-04-04 13:51 ` Andy Shevchenko
2017-04-04 13:51 ` Andy Shevchenko
2017-04-04 22:15 ` sathyanarayanan kuppuswamy
2017-04-04 22:15 ` sathyanarayanan kuppuswamy
2017-04-04 22:15 ` sathyanarayanan kuppuswamy
2017-04-04 13:25 ` [PATCH v4 1/5] platform/x86: intel_pmc_ipc: fix gcr offset Andy Shevchenko
2017-04-04 13:25 ` Andy Shevchenko
2017-04-04 21:32 ` sathyanarayanan kuppuswamy
2017-04-04 21:32 ` sathyanarayanan kuppuswamy
2017-04-05 22:54 ` [PATCH v6 1/6] " Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` [PATCH v6 2/6] platform/x86: intel_pmc_ipc: Add pmc gcr read/write/update api's Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` [PATCH v6 3/6] watchdog: iTCO_wdt: cleanup set/unset no_reboot_bit functions Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` [PATCH v6 4/6] watchdog: iTCO_wdt: Add PMC specific noreboot update api Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-06 11:42 ` Guenter Roeck
2017-04-06 11:42 ` Guenter Roeck
2017-04-05 22:54 ` [PATCH v6 5/6] platform/x86: intel_pmc_ipc: Fix iTCO_wdt GCS memory mapping failure Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-06 21:37 ` Andy Shevchenko
2017-04-06 21:37 ` Andy Shevchenko
2017-04-05 22:54 ` [PATCH v6 6/6] platform/x86: intel_pmc_ipc: use gcr mem base for S0ix counter read Kuppuswamy Sathyanarayanan
2017-04-05 22:54 ` Kuppuswamy Sathyanarayanan
2017-04-06 15:16 ` [PATCH v6 1/6] platform/x86: intel_pmc_ipc: fix gcr offset Rajneesh Bhardwaj
2017-04-06 15:16 ` Rajneesh Bhardwaj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c158bcb3-c6c2-3f81-c38b-6a63e6c1af5e@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=andy@infradead.org \
--cc=david.e.box@linux.intel.com \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=platform-driver-x86@vger.kernel.org \
--cc=qipeng.zha@intel.com \
--cc=rajneesh.bhardwaj@intel.com \
--cc=sathyaosid@gmail.com \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.