From: Hans Verkuil <hverkuil-cisco@xs4all.nl> To: Alex Riesen <alexander.riesen@cetitec.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls Date: Fri, 13 Mar 2020 11:52:03 +0100 [thread overview] Message-ID: <c260defe-bb3c-0dc2-476f-5cf8ff27b915@xs4all.nl> (raw) In-Reply-To: <20200313102600.GF3832@pflmari> On 3/13/20 11:26 AM, Alex Riesen wrote: > Hi Hans, > > Hans Verkuil, Fri, Mar 13, 2020 09:16:11 +0100: >> On 1/13/20 3:15 PM, Alex Riesen wrote: >>> This change implements audio-related V4L2 ioctls for the HDMI subdevice. >> >> This is really where things go wrong. These V4L2 audio ioctls are meant for >> old PCI TV tuner devices where the audio was implemented as audio jack outputs >> that are typically looped back to audio inputs on a (PCI) soundcard. And when >> these ioctls were designed ALSA didn't even exist. > > I see. That was before my time :) > >> Generally an hdmi driver will configure the i2s audio automatically, which is >> typically connected to the SoC and controlled by the ALSA driver of the SoC, >> but there may well be missing features (audio never got a lot of attention in >> hdmi receivers). So what I would like to know is: what features are missing? > > Well, the audio is missing. The current adv748x driver does not export the > audio features of the device at all. There is no code to enable the I2S audio > output and it is disabled (all clock and the data lines) by default. Sorry, I was vague in my question. Obviously that needs to be added, but besides adding the low-level i2s support I was wondering if there are additional things that need to be exposed to userspace in order for audio to fully work. > > But, by now it seems to be clear that implementation of ALSA SoC DAI > interfaces is the way to support the audio. > > And I am already slowly working on it. > >> Anything missing can likely be resolved by adding HDMI audio specific V4L2 controls, >> which would be the right approach for this. >> >> So I would expect to see a proposal for V4L2_CID_DV_RX_AUDIO_ controls to be >> added here: >> >> https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/ext-ctrls-dv.html > > This seems to be an explicitly "digital video" control class. And it has no > control option for mute. Or did you mean a similarly structured new class for > "digital audio"? There are no DV_ audio controls at all today. So any new audio controls would be added to the DV class. But if there is nothing that needs to be exposed, then nothing needs to be added :-) Regards, Hans > > This feels like an overkill for this particular driver... > > Regards, > Alex >
WARNING: multiple messages have this Message-ID (diff)
From: Hans Verkuil <hverkuil-cisco@xs4all.nl> To: Alex Riesen <alexander.riesen@cetitec.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>, Mauro Carvalho Chehab <mchehab@kernel.org>, Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Rob Herring <robh+dt@kernel.org>, Mark Rutland <mark.rutland@arm.com>, devel@driverdev.osuosl.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls Date: Fri, 13 Mar 2020 11:52:03 +0100 [thread overview] Message-ID: <c260defe-bb3c-0dc2-476f-5cf8ff27b915@xs4all.nl> (raw) In-Reply-To: <20200313102600.GF3832@pflmari> On 3/13/20 11:26 AM, Alex Riesen wrote: > Hi Hans, > > Hans Verkuil, Fri, Mar 13, 2020 09:16:11 +0100: >> On 1/13/20 3:15 PM, Alex Riesen wrote: >>> This change implements audio-related V4L2 ioctls for the HDMI subdevice. >> >> This is really where things go wrong. These V4L2 audio ioctls are meant for >> old PCI TV tuner devices where the audio was implemented as audio jack outputs >> that are typically looped back to audio inputs on a (PCI) soundcard. And when >> these ioctls were designed ALSA didn't even exist. > > I see. That was before my time :) > >> Generally an hdmi driver will configure the i2s audio automatically, which is >> typically connected to the SoC and controlled by the ALSA driver of the SoC, >> but there may well be missing features (audio never got a lot of attention in >> hdmi receivers). So what I would like to know is: what features are missing? > > Well, the audio is missing. The current adv748x driver does not export the > audio features of the device at all. There is no code to enable the I2S audio > output and it is disabled (all clock and the data lines) by default. Sorry, I was vague in my question. Obviously that needs to be added, but besides adding the low-level i2s support I was wondering if there are additional things that need to be exposed to userspace in order for audio to fully work. > > But, by now it seems to be clear that implementation of ALSA SoC DAI > interfaces is the way to support the audio. > > And I am already slowly working on it. > >> Anything missing can likely be resolved by adding HDMI audio specific V4L2 controls, >> which would be the right approach for this. >> >> So I would expect to see a proposal for V4L2_CID_DV_RX_AUDIO_ controls to be >> added here: >> >> https://linuxtv.org/downloads/v4l-dvb-apis-new/uapi/v4l/ext-ctrls-dv.html > > This seems to be an explicitly "digital video" control class. And it has no > control option for mute. Or did you mean a similarly structured new class for > "digital audio"? There are no DV_ audio controls at all today. So any new audio controls would be added to the DV class. But if there is nothing that needs to be exposed, then nothing needs to be added :-) Regards, Hans > > This feels like an overkill for this particular driver... > > Regards, > Alex > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
next prev parent reply other threads:[~2020-03-13 10:52 UTC|newest] Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-13 14:19 [PATCH 0/8] media: i2c: adv748x: add support for HDMI audio Alex Riesen 2020-01-13 14:19 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 1/8] media: adv748x: add a device-specific wrapper for register block read Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 2/8] media: adv748x: add audio mute control and output selection ioctls Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-03-13 8:16 ` Hans Verkuil 2020-03-13 8:16 ` Hans Verkuil 2020-03-13 10:26 ` Alex Riesen 2020-03-13 10:26 ` Alex Riesen 2020-03-13 10:52 ` Hans Verkuil [this message] 2020-03-13 10:52 ` Hans Verkuil 2020-03-13 11:00 ` Alex Riesen 2020-03-13 11:00 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 3/8] media: adv748x: add log_status ioctl Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 4/8] media: adv748x: reserve space for the audio (I2S) port in the driver structures Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 5/8] media: adv748x: add an ASoC DAI definition to the driver Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 6/8] media: adv748x: reduce amount of code for bitwise modification of device registers Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 14:15 ` [PATCH 7/8] dt-bindings: adv748x: add information about serial audio interface (I2S/TDM) Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-01-13 22:32 ` Rob Herring 2020-01-13 22:32 ` Rob Herring 2020-01-13 14:15 ` [PATCH 8/8] arm64: dts: renesas: salvator: add a connection from adv748x codec (HDMI input) to the R-Car SoC Alex Riesen 2020-01-13 14:15 ` Alex Riesen 2020-03-02 12:28 ` Geert Uytterhoeven 2020-03-02 12:28 ` Geert Uytterhoeven 2020-03-02 13:40 ` Alex Riesen 2020-03-02 13:40 ` Alex Riesen 2020-03-02 13:47 ` Geert Uytterhoeven 2020-03-02 13:47 ` Geert Uytterhoeven 2020-03-02 15:07 ` Alex Riesen 2020-03-02 15:07 ` Alex Riesen 2020-03-02 15:32 ` Geert Uytterhoeven 2020-03-02 15:32 ` Geert Uytterhoeven 2020-03-02 16:09 ` Alex Riesen 2020-03-02 16:09 ` Alex Riesen 2020-03-02 16:13 ` Geert Uytterhoeven 2020-03-02 16:13 ` Geert Uytterhoeven 2020-03-05 14:36 ` Alex Riesen 2020-03-05 14:36 ` Alex Riesen 2020-03-06 12:21 ` Geert Uytterhoeven 2020-03-06 12:21 ` Geert Uytterhoeven 2020-03-06 13:16 ` Laurent Pinchart 2020-03-06 13:16 ` Laurent Pinchart 2020-03-06 13:41 ` Alex Riesen 2020-03-06 13:41 ` Alex Riesen 2020-03-06 13:45 ` Laurent Pinchart 2020-03-06 13:45 ` Laurent Pinchart 2020-03-09 1:31 ` Kuninori Morimoto 2020-03-09 1:31 ` Kuninori Morimoto 2020-03-09 11:09 ` Alex Riesen 2020-03-09 11:09 ` Alex Riesen 2020-03-10 1:07 ` Kuninori Morimoto 2020-03-10 1:07 ` Kuninori Morimoto 2020-03-10 8:17 ` Alex Riesen 2020-03-10 8:17 ` Alex Riesen 2020-03-10 10:39 ` Laurent Pinchart 2020-03-10 10:39 ` Laurent Pinchart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c260defe-bb3c-0dc2-476f-5cf8ff27b915@xs4all.nl \ --to=hverkuil-cisco@xs4all.nl \ --cc=alexander.riesen@cetitec.com \ --cc=devel@driverdev.osuosl.org \ --cc=devicetree@vger.kernel.org \ --cc=kieran.bingham@ideasonboard.com \ --cc=laurent.pinchart@ideasonboard.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-media@vger.kernel.org \ --cc=linux-renesas-soc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=mchehab@kernel.org \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.