From: Nicolas Ferre <nicolas.ferre@microchip.com> To: Quentin Schulz <quentin.schulz@free-electrons.com>, <broonie@kernel.org> Cc: <linux-spi@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <alexandre.belloni@free-electrons.com>, <thomas.petazzoni@free-electrons.com> Subject: Re: [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Date: Wed, 12 Apr 2017 10:40:23 +0200 [thread overview] Message-ID: <c349c3b4-5ac8-c4f8-6112-ade885bc6b82@microchip.com> (raw) In-Reply-To: <20170412070520.29621-1-quentin.schulz@free-electrons.com> Le 12/04/2017 à 09:05, Quentin Schulz a écrit : > The SPI controller configuration during the init can be reused, for the > resume function for example. > > Let's move this configuration to a separate function. > > Signed-off-by: Quentin Schulz <quentin.schulz@free-electrons.com> Okay: Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/spi/spi-atmel.c | 35 +++++++++++++++++++++-------------- > 1 file changed, 21 insertions(+), 14 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 0e7712b..247d920 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1464,6 +1464,25 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev) > return 0; > } > > +static void atmel_spi_init(struct atmel_spi *as) > +{ > + spi_writel(as, CR, SPI_BIT(SWRST)); > + spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ > + if (as->caps.has_wdrbt) { > + spi_writel(as, MR, SPI_BIT(WDRBT) | SPI_BIT(MODFDIS) > + | SPI_BIT(MSTR)); > + } else { > + spi_writel(as, MR, SPI_BIT(MSTR) | SPI_BIT(MODFDIS)); > + } > + > + if (as->use_pdc) > + spi_writel(as, PTCR, SPI_BIT(RXTDIS) | SPI_BIT(TXTDIS)); > + spi_writel(as, CR, SPI_BIT(SPIEN)); > + > + if (as->fifo_size) > + spi_writel(as, CR, SPI_BIT(FIFOEN)); > +} > + > static int atmel_spi_probe(struct platform_device *pdev) > { > struct resource *regs; > @@ -1572,26 +1591,14 @@ static int atmel_spi_probe(struct platform_device *pdev) > > as->spi_clk = clk_get_rate(clk); > > - spi_writel(as, CR, SPI_BIT(SWRST)); > - spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ > - if (as->caps.has_wdrbt) { > - spi_writel(as, MR, SPI_BIT(WDRBT) | SPI_BIT(MODFDIS) > - | SPI_BIT(MSTR)); > - } else { > - spi_writel(as, MR, SPI_BIT(MSTR) | SPI_BIT(MODFDIS)); > - } > - > - if (as->use_pdc) > - spi_writel(as, PTCR, SPI_BIT(RXTDIS) | SPI_BIT(TXTDIS)); > - spi_writel(as, CR, SPI_BIT(SPIEN)); > - > as->fifo_size = 0; > if (!of_property_read_u32(pdev->dev.of_node, "atmel,fifo-size", > &as->fifo_size)) { > dev_info(&pdev->dev, "Using FIFO (%u data)\n", as->fifo_size); > - spi_writel(as, CR, SPI_BIT(FIFOEN)); > } > > + atmel_spi_init(as); > + > pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); > pm_runtime_use_autosuspend(&pdev->dev); > pm_runtime_set_active(&pdev->dev); > -- Nicolas Ferre
WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Ferre <nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> To: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: <linux-spi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>, <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Subject: Re: [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Date: Wed, 12 Apr 2017 10:40:23 +0200 [thread overview] Message-ID: <c349c3b4-5ac8-c4f8-6112-ade885bc6b82@microchip.com> (raw) In-Reply-To: <20170412070520.29621-1-quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Le 12/04/2017 à 09:05, Quentin Schulz a écrit : > The SPI controller configuration during the init can be reused, for the > resume function for example. > > Let's move this configuration to a separate function. > > Signed-off-by: Quentin Schulz <quentin.schulz-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> Okay: Acked-by: Nicolas Ferre <nicolas.ferre-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org> > --- > drivers/spi/spi-atmel.c | 35 +++++++++++++++++++++-------------- > 1 file changed, 21 insertions(+), 14 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 0e7712b..247d920 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -1464,6 +1464,25 @@ static int atmel_spi_gpio_cs(struct platform_device *pdev) > return 0; > } > > +static void atmel_spi_init(struct atmel_spi *as) > +{ > + spi_writel(as, CR, SPI_BIT(SWRST)); > + spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ > + if (as->caps.has_wdrbt) { > + spi_writel(as, MR, SPI_BIT(WDRBT) | SPI_BIT(MODFDIS) > + | SPI_BIT(MSTR)); > + } else { > + spi_writel(as, MR, SPI_BIT(MSTR) | SPI_BIT(MODFDIS)); > + } > + > + if (as->use_pdc) > + spi_writel(as, PTCR, SPI_BIT(RXTDIS) | SPI_BIT(TXTDIS)); > + spi_writel(as, CR, SPI_BIT(SPIEN)); > + > + if (as->fifo_size) > + spi_writel(as, CR, SPI_BIT(FIFOEN)); > +} > + > static int atmel_spi_probe(struct platform_device *pdev) > { > struct resource *regs; > @@ -1572,26 +1591,14 @@ static int atmel_spi_probe(struct platform_device *pdev) > > as->spi_clk = clk_get_rate(clk); > > - spi_writel(as, CR, SPI_BIT(SWRST)); > - spi_writel(as, CR, SPI_BIT(SWRST)); /* AT91SAM9263 Rev B workaround */ > - if (as->caps.has_wdrbt) { > - spi_writel(as, MR, SPI_BIT(WDRBT) | SPI_BIT(MODFDIS) > - | SPI_BIT(MSTR)); > - } else { > - spi_writel(as, MR, SPI_BIT(MSTR) | SPI_BIT(MODFDIS)); > - } > - > - if (as->use_pdc) > - spi_writel(as, PTCR, SPI_BIT(RXTDIS) | SPI_BIT(TXTDIS)); > - spi_writel(as, CR, SPI_BIT(SPIEN)); > - > as->fifo_size = 0; > if (!of_property_read_u32(pdev->dev.of_node, "atmel,fifo-size", > &as->fifo_size)) { > dev_info(&pdev->dev, "Using FIFO (%u data)\n", as->fifo_size); > - spi_writel(as, CR, SPI_BIT(FIFOEN)); > } > > + atmel_spi_init(as); > + > pm_runtime_set_autosuspend_delay(&pdev->dev, AUTOSUSPEND_TIMEOUT); > pm_runtime_use_autosuspend(&pdev->dev); > pm_runtime_set_active(&pdev->dev); > -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-spi" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-04-12 8:40 UTC|newest] Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-12 7:05 [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Quentin Schulz 2017-04-12 7:05 ` Quentin Schulz 2017-04-12 7:05 ` [PATCH 2/2] spi: atmel: add PM support to SAMA5D2 Quentin Schulz 2017-04-12 7:05 ` Quentin Schulz 2017-04-12 9:08 ` Nicolas Ferre 2017-04-12 9:08 ` Nicolas Ferre 2017-04-18 18:00 ` Applied "spi: atmel: add deepest PM support to SAMA5D2" to the spi tree Mark Brown 2017-04-12 8:40 ` Nicolas Ferre [this message] 2017-04-12 8:40 ` [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Nicolas Ferre 2017-04-12 9:48 ` Applied "spi: atmel: factorize reusable code for SPI controller init" to the spi tree Mark Brown 2017-04-12 9:48 ` Mark Brown 2017-04-14 8:22 [PATCH 1/2] spi: atmel: factorize reusable code for SPI controller init Quentin Schulz 2017-04-14 10:35 ` Alexandre Belloni 2017-04-14 10:35 ` Alexandre Belloni 2017-04-14 17:03 ` Mark Brown
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=c349c3b4-5ac8-c4f8-6112-ade885bc6b82@microchip.com \ --to=nicolas.ferre@microchip.com \ --cc=alexandre.belloni@free-electrons.com \ --cc=broonie@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-spi@vger.kernel.org \ --cc=quentin.schulz@free-electrons.com \ --cc=thomas.petazzoni@free-electrons.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.