All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Lee Jones <lee.jones@linaro.org>
Cc: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	MandyJH Liu <mandyjh.liu@mediatek.com>, <iommu@lists.linux.dev>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v3 06/21] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS
Date: Thu, 21 Jul 2022 10:35:13 +0800	[thread overview]
Message-ID: <c79b0f441bc4d7dce6c8d35f189783e69144413f.camel@mediatek.com> (raw)
In-Reply-To: <68a30bbd-5f9d-17d2-59fa-7b0da06ee877@linaro.org>

On Wed, 2022-07-20 at 19:37 +0200, Krzysztof Kozlowski wrote:
> On 20/07/2022 15:31, Lee Jones wrote:
> > On Wed, 20 Jul 2022, Tinghan Shen wrote:
> > 
> > > The System Control Processor System (SCPSYS) has several power
> > > management related tasks in the system. Add the bindings for it.
> > > 
> > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > 
> > Why have you ignored my review comments from v2?
> 
> If you refer whether the binding is needed at all, then the answer is
> yes, because this is not simple syscons but a device with children,
> which we want to parse/match.
> 
> Anyway Tinghan should respond to you about way how he proceeds...
> 
> Best regards,
> Krzysztof

Hi Lee,

I'm so sorry for not answering your feedback. I misunderstood it
that you're waiting the review result of DT maintainers.

This binding is added because of the discussion of the scpsys node[1].
I first looked at mfd/syscon.yaml to see if I could use it.
I found that it doesn't have the 'simple-mfd' compatible, so I decide to add a new one.
It's because I need the 'simple-mfd' compatible to parse child nodes.


[1] https://lore.kernel.org/all/f7eee4e8-05fa-4c83-9168-64e5ea4c510f@linaro.org/



Best regards,
TingHan


WARNING: multiple messages have this Message-ID (diff)
From: Tinghan Shen <tinghan.shen@mediatek.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
	Lee Jones <lee.jones@linaro.org>
Cc: Yong Wu <yong.wu@mediatek.com>, Joerg Roedel <joro@8bytes.org>,
	"Will Deacon" <will@kernel.org>,
	Robin Murphy <robin.murphy@arm.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	MandyJH Liu <mandyjh.liu@mediatek.com>, <iommu@lists.linux.dev>,
	<linux-mediatek@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>
Subject: Re: [PATCH v3 06/21] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS
Date: Thu, 21 Jul 2022 10:35:13 +0800	[thread overview]
Message-ID: <c79b0f441bc4d7dce6c8d35f189783e69144413f.camel@mediatek.com> (raw)
In-Reply-To: <68a30bbd-5f9d-17d2-59fa-7b0da06ee877@linaro.org>

On Wed, 2022-07-20 at 19:37 +0200, Krzysztof Kozlowski wrote:
> On 20/07/2022 15:31, Lee Jones wrote:
> > On Wed, 20 Jul 2022, Tinghan Shen wrote:
> > 
> > > The System Control Processor System (SCPSYS) has several power
> > > management related tasks in the system. Add the bindings for it.
> > > 
> > > Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>
> > 
> > Why have you ignored my review comments from v2?
> 
> If you refer whether the binding is needed at all, then the answer is
> yes, because this is not simple syscons but a device with children,
> which we want to parse/match.
> 
> Anyway Tinghan should respond to you about way how he proceeds...
> 
> Best regards,
> Krzysztof

Hi Lee,

I'm so sorry for not answering your feedback. I misunderstood it
that you're waiting the review result of DT maintainers.

This binding is added because of the discussion of the scpsys node[1].
I first looked at mfd/syscon.yaml to see if I could use it.
I found that it doesn't have the 'simple-mfd' compatible, so I decide to add a new one.
It's because I need the 'simple-mfd' compatible to parse child nodes.


[1] https://lore.kernel.org/all/f7eee4e8-05fa-4c83-9168-64e5ea4c510f@linaro.org/



Best regards,
TingHan


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-07-21  2:35 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-20 12:30 [PATCH v3 00/21] Add driver nodes for MT8195 SoC Tinghan Shen
2022-07-20 12:30 ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 01/21] dt-bindings: iommu: mediatek: Increase max interrupt number Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 17:30   ` Krzysztof Kozlowski
2022-07-20 17:30     ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 02/21] dt-bindings: memory: mediatek: Update condition for mt8195 smi node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 03/21] dt-bindings: power: mediatek: Refine multiple level power domain nodes Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 17:32   ` Krzysztof Kozlowski
2022-07-20 17:32     ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 04/21] dt-bindings: power: mediatek: Support naming power controller node with unit address Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 17:32   ` Krzysztof Kozlowski
2022-07-20 17:32     ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 05/21] dt-bindings: power: mediatek: Update maintainer list Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-25 22:24   ` Rob Herring
2022-07-25 22:24     ` Rob Herring
2022-07-20 12:30 ` [PATCH v3 06/21] dt-bindings: power: mediatek: Add bindings for MediaTek SCPSYS Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 13:31   ` Lee Jones
2022-07-20 13:31     ` Lee Jones
2022-07-20 17:37     ` Krzysztof Kozlowski
2022-07-20 17:37       ` Krzysztof Kozlowski
2022-07-21  2:35       ` Tinghan Shen [this message]
2022-07-21  2:35         ` Tinghan Shen
2022-07-21 11:36       ` Lee Jones
2022-07-21 11:36         ` Lee Jones
2022-07-20 17:35   ` Krzysztof Kozlowski
2022-07-20 17:35     ` Krzysztof Kozlowski
2022-07-21  3:05     ` Tinghan Shen
2022-07-21  3:05       ` Tinghan Shen
2022-07-21  6:34       ` Krzysztof Kozlowski
2022-07-21  6:34         ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 07/21] dt-bindings: power: mediatek: Update example in dt-bindings Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 17:38   ` Krzysztof Kozlowski
2022-07-20 17:38     ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 08/21] arm64: dts: mediatek: Update mt81xx scpsys node to align with dt-bindings Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 17:39   ` Krzysztof Kozlowski
2022-07-20 17:39     ` Krzysztof Kozlowski
2022-07-20 12:30 ` [PATCH v3 09/21] arm64: dts: mt8195: Disable watchdog external reset signal Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 10/21] arm64: dts: mt8195: Disable I2C0 node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 11/21] arm64: dts: mt8195: Add cpufreq node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 12/21] arm64: dts: mt8195: Add vdosys and vppsys clock nodes Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 13/21] arm64: dts: mt8195: Add power domains controller Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 14/21] arm64: dts: mt8195: Add spmi node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 15/21] arm64: dts: mt8195: Add scp node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 16/21] arm64: dts: mt8195: Add audio related nodes Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 17/21] arm64: dts: mt8195: Add adsp node and adsp mailbox nodes Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 18/21] arm64: dts: mt8195: Specify audio reset controller Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 19/21] arm64: dts: mt8195: Add iommu and smi nodes Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 20/21] arm64: dts: mt8195: Add gce node Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen
2022-07-20 12:30 ` [PATCH v3 21/21] arm64: dts: mt8195: Add display node for vdosys0 Tinghan Shen
2022-07-20 12:30   ` Tinghan Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c79b0f441bc4d7dce6c8d35f189783e69144413f.camel@mediatek.com \
    --to=tinghan.shen@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=devicetree@vger.kernel.org \
    --cc=iommu@lists.linux.dev \
    --cc=joro@8bytes.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=mandyjh.liu@mediatek.com \
    --cc=matthias.bgg@gmail.com \
    --cc=robh+dt@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=will@kernel.org \
    --cc=yong.wu@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.