* [PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode"
@ 2021-09-13 16:02 Jan Beulich
2021-09-13 16:38 ` Andrew Cooper
0 siblings, 1 reply; 2+ messages in thread
From: Jan Beulich @ 2021-09-13 16:02 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu, Roger Pau Monné
The option parser takes off "no-" prefixes before matching, so they also
shouldn't be specified to match against.
Fixes: e44d98608476 ("x86/setup: Ignore early boot parameters like no-real-mode")
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/arch/x86/setup.c
+++ b/xen/arch/x86/setup.c
@@ -692,7 +692,7 @@ static void __init noreturn reinit_bsp_s
* has options that are only used during the very initial boot process,
* so they can be ignored now.
*/
-ignore_param("no-real-mode");
+ignore_param("real-mode");
ignore_param("edd");
ignore_param("edid");
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode"
2021-09-13 16:02 [PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode" Jan Beulich
@ 2021-09-13 16:38 ` Andrew Cooper
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cooper @ 2021-09-13 16:38 UTC (permalink / raw)
To: Jan Beulich, xen-devel; +Cc: Wei Liu, Roger Pau Monné
On 13/09/2021 17:02, Jan Beulich wrote:
> The option parser takes off "no-" prefixes before matching, so they also
> shouldn't be specified to match against.
>
> Fixes: e44d98608476 ("x86/setup: Ignore early boot parameters like no-real-mode")
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Oops.
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
>
> --- a/xen/arch/x86/setup.c
> +++ b/xen/arch/x86/setup.c
> @@ -692,7 +692,7 @@ static void __init noreturn reinit_bsp_s
> * has options that are only used during the very initial boot process,
> * so they can be ignored now.
> */
> -ignore_param("no-real-mode");
> +ignore_param("real-mode");
> ignore_param("edd");
> ignore_param("edid");
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-13 16:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-13 16:02 [PATCH] x86/boot: properly "ignore" early evaluated "no-real-mode" Jan Beulich
2021-09-13 16:38 ` Andrew Cooper
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.