From: Chao Yu <yuchao0@huawei.com> To: Ju Hyung Park <qkrwngud825@gmail.com> Cc: Jaegeuk Kim <jaegeuk@kernel.org>, <linux-kernel@vger.kernel.org>, <linux-f2fs-devel@lists.sourceforge.net> Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: relocate chksum_offset for large_nat_bitmap feature Date: Thu, 25 Apr 2019 09:36:49 +0800 [thread overview] Message-ID: <cd4b13a5-9b59-aa53-5859-f52275b4d9d7@huawei.com> (raw) In-Reply-To: <CAD14+f0D9CVmBZGmbMcKB7xAHvBrbGAgVxR4W8Fiu0Vo6czDYQ@mail.gmail.com> Hi Ju Hyung, On 2019/4/24 19:43, Ju Hyung Park wrote: > Hi Chao, > > On Mon, Apr 22, 2019 at 6:34 PM Chao Yu <yuchao0@huawei.com> wrote: >> + if (__is_set_ckpt_flags(*cp_block, CP_LARGE_NAT_BITMAP_FLAG)) { >> + if (crc_offset != CP_MIN_CHKSUM_OFFSET) { >> + f2fs_put_page(*cp_page, 1); >> + f2fs_msg(sbi->sb, KERN_WARNING, >> + "layout of large_nat_bitmap is deprecated, " >> + "run fsck to repair, chksum_offset: %zu", >> + crc_offset); >> + return -EINVAL; >> + } >> + } >> + > > I try not to be a Grammar Nazi and a jerk on every patches, but since > this is a message a user would directly encounter, I'd like to see a > bit less ambiguous message. Please feel free to give us your opinion or suggestion. :) > > How about "using deprecated layout of large_nat_bitmap, please run > fsck v1.13.0 or higher to repair, chksum_offset: %zu"? > The original message seems to suggest that large_nat_bitmap is > deprecated outright. > > Also, I'd like to suggest to write down an actual version of > f2fs-tools here as we've seen older versions of fsck doing even more > damage and the users might not have the latest f2fs-tools installed. Agreed, user should be told which version of fsck can repair that problem, will update the message in next version. > > Btw, what happens if we use the latest fsck to fix the corrupted image > and use the older kernel to mount it? > Would it even mount? No, since fixed image is using a new layout, how about giving the detailed information about which version of kernel user should update to, once we detect such issue and trigger the repairing? Thanks, > > Thanks. > . >
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <yuchao0@huawei.com> To: Ju Hyung Park <qkrwngud825@gmail.com> Cc: Jaegeuk Kim <jaegeuk@kernel.org>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [PATCH 2/2] f2fs: relocate chksum_offset for large_nat_bitmap feature Date: Thu, 25 Apr 2019 09:36:49 +0800 [thread overview] Message-ID: <cd4b13a5-9b59-aa53-5859-f52275b4d9d7@huawei.com> (raw) In-Reply-To: <CAD14+f0D9CVmBZGmbMcKB7xAHvBrbGAgVxR4W8Fiu0Vo6czDYQ@mail.gmail.com> Hi Ju Hyung, On 2019/4/24 19:43, Ju Hyung Park wrote: > Hi Chao, > > On Mon, Apr 22, 2019 at 6:34 PM Chao Yu <yuchao0@huawei.com> wrote: >> + if (__is_set_ckpt_flags(*cp_block, CP_LARGE_NAT_BITMAP_FLAG)) { >> + if (crc_offset != CP_MIN_CHKSUM_OFFSET) { >> + f2fs_put_page(*cp_page, 1); >> + f2fs_msg(sbi->sb, KERN_WARNING, >> + "layout of large_nat_bitmap is deprecated, " >> + "run fsck to repair, chksum_offset: %zu", >> + crc_offset); >> + return -EINVAL; >> + } >> + } >> + > > I try not to be a Grammar Nazi and a jerk on every patches, but since > this is a message a user would directly encounter, I'd like to see a > bit less ambiguous message. Please feel free to give us your opinion or suggestion. :) > > How about "using deprecated layout of large_nat_bitmap, please run > fsck v1.13.0 or higher to repair, chksum_offset: %zu"? > The original message seems to suggest that large_nat_bitmap is > deprecated outright. > > Also, I'd like to suggest to write down an actual version of > f2fs-tools here as we've seen older versions of fsck doing even more > damage and the users might not have the latest f2fs-tools installed. Agreed, user should be told which version of fsck can repair that problem, will update the message in next version. > > Btw, what happens if we use the latest fsck to fix the corrupted image > and use the older kernel to mount it? > Would it even mount? No, since fixed image is using a new layout, how about giving the detailed information about which version of kernel user should update to, once we detect such issue and trigger the repairing? Thanks, > > Thanks. > . >
next prev parent reply other threads:[~2019-04-25 1:36 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-04-22 9:33 [PATCH 1/2] f2fs: allow unfixed f2fs_checkpoint.checksum_offset Chao Yu 2019-04-22 9:33 ` Chao Yu 2019-04-22 9:33 ` [PATCH 2/2] f2fs: relocate chksum_offset for large_nat_bitmap feature Chao Yu 2019-04-22 9:33 ` Chao Yu 2019-04-24 11:43 ` [f2fs-dev] " Ju Hyung Park 2019-04-25 1:36 ` Chao Yu [this message] 2019-04-25 1:36 ` Chao Yu 2019-04-23 20:43 ` [PATCH 1/2] f2fs: allow unfixed f2fs_checkpoint.checksum_offset Jaegeuk Kim 2019-04-23 20:56 ` [f2fs-dev] " Jaegeuk Kim 2019-04-24 7:14 ` Chao Yu 2019-04-24 7:14 ` Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cd4b13a5-9b59-aa53-5859-f52275b4d9d7@huawei.com \ --to=yuchao0@huawei.com \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ --cc=qkrwngud825@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.