From: Ludovic BARRE <ludovic.barre@st.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: Rob Herring <robh+dt@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, Alexandre Torgue <alexandre.torgue@st.com>, Linux ARM <linux-arm-kernel@lists.infradead.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, DTML <devicetree@vger.kernel.org>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, <linux-stm32@st-md-mailman.stormreply.com> Subject: Re: [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Date: Mon, 27 Jan 2020 14:52:28 +0100 [thread overview] Message-ID: <cdc08d8d-ffb1-0fe9-377d-a1e5faf089ce@st.com> (raw) In-Reply-To: <CAPDyKFo+4qTZbE=4Zgj3VN9BPYUHGskPSnYEJRo1TpARzg5zJg@mail.gmail.com> hi Ulf Le 1/24/20 à 2:19 PM, Ulf Hansson a écrit : > On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE <ludovic.barre@st.com> wrote: >> >> hi Ulf >> >> Just a "gentleman ping" on this series >> https://lkml.org/lkml/2020/1/10/392 > > I was just reviewing :-) Thanks for pinging! > > One overall comment is that I think you can try to work a bit on the > changelogs. In some cases you described what the patch does, which is > good, but it may lack information about *why* the change is wanted. Ok, I try to add a comment to *why* > > Overall, the series looks nice. > > Kind regards > Uffe >
WARNING: multiple messages have this Message-ID (diff)
From: Ludovic BARRE <ludovic.barre@st.com> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: DTML <devicetree@vger.kernel.org>, Alexandre Torgue <alexandre.torgue@st.com>, "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, linux-stm32@st-md-mailman.stormreply.com, Linux ARM <linux-arm-kernel@lists.infradead.org> Subject: Re: [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Date: Mon, 27 Jan 2020 14:52:28 +0100 [thread overview] Message-ID: <cdc08d8d-ffb1-0fe9-377d-a1e5faf089ce@st.com> (raw) In-Reply-To: <CAPDyKFo+4qTZbE=4Zgj3VN9BPYUHGskPSnYEJRo1TpARzg5zJg@mail.gmail.com> hi Ulf Le 1/24/20 à 2:19 PM, Ulf Hansson a écrit : > On Fri, 24 Jan 2020 at 13:55, Ludovic BARRE <ludovic.barre@st.com> wrote: >> >> hi Ulf >> >> Just a "gentleman ping" on this series >> https://lkml.org/lkml/2020/1/10/392 > > I was just reviewing :-) Thanks for pinging! > > One overall comment is that I think you can try to work a bit on the > changelogs. In some cases you described what the patch does, which is > good, but it may lack information about *why* the change is wanted. Ok, I try to add a comment to *why* > > Overall, the series looks nice. > > Kind regards > Uffe > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-27 13:52 UTC|newest] Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 13:48 [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 1/9] mmc: mmci: sdmmc: replace sg_dma_xxx macros Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 2/9] mmc: mmci: sdmmc: rename sdmmc_priv struct to sdmmc_idma Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 3/9] mmc: mmci: add a reference at mmc_host_ops in mmci struct Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:09 ` Ulf Hansson 2020-01-24 13:09 ` Ulf Hansson 2020-01-27 10:57 ` Ludovic BARRE 2020-01-27 10:57 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 4/9] mmc: mmci: add private pointer for variant Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-10 13:48 ` [PATCH 5/9] dt-bindings: mmc: mmci: add delay block base register for sdmmc Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-15 14:56 ` Rob Herring 2020-01-15 14:56 ` Rob Herring 2020-01-16 9:20 ` Ludovic BARRE 2020-01-16 9:20 ` Ludovic BARRE 2020-01-16 14:33 ` Rob Herring 2020-01-16 14:33 ` Rob Herring 2020-01-16 14:52 ` Ludovic BARRE 2020-01-16 14:52 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 6/9] mmc: mmci: sdmmc: add execute tuning with delay block Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:10 ` Ulf Hansson 2020-01-24 13:10 ` Ulf Hansson 2020-01-27 13:19 ` Ludovic BARRE 2020-01-27 13:19 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 7/9] mmc: mmci: add volt_switch callbacks Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:12 ` Ulf Hansson 2020-01-24 13:12 ` Ulf Hansson 2020-01-27 13:21 ` Ludovic BARRE 2020-01-27 13:21 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 8/9] mmc: mmci: sdmmc: add voltage switch functions Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 13:16 ` Ulf Hansson 2020-01-24 13:16 ` Ulf Hansson 2020-01-27 13:50 ` Ludovic BARRE 2020-01-27 13:50 ` Ludovic BARRE 2020-01-10 13:48 ` [PATCH 9/9] mmc: mmci: add sdmmc variant revision 2.0 Ludovic Barre 2020-01-10 13:48 ` Ludovic Barre 2020-01-24 12:55 ` [PATCH 0/9] mmc: mmci: sdmmc: add sdr104 support Ludovic BARRE 2020-01-24 12:55 ` Ludovic BARRE 2020-01-24 13:19 ` Ulf Hansson 2020-01-24 13:19 ` Ulf Hansson 2020-01-27 13:52 ` Ludovic BARRE [this message] 2020-01-27 13:52 ` Ludovic BARRE
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cdc08d8d-ffb1-0fe9-377d-a1e5faf089ce@st.com \ --to=ludovic.barre@st.com \ --cc=alexandre.torgue@st.com \ --cc=devicetree@vger.kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mmc@vger.kernel.org \ --cc=linux-stm32@st-md-mailman.stormreply.com \ --cc=mcoquelin.stm32@gmail.com \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.