From: David Daney <ddaney@caviumnetworks.com> To: Steven Rostedt <rostedt@goodmis.org>, Sachin Sant <sachinp@linux.vnet.ibm.com> Cc: Jason Baron <jbaron@akamai.com>, linux-mips@linux-mips.org, Chris Metcalf <cmetcalf@mellanox.com>, LKML <linux-kernel@vger.kernel.org>, Ralf Baechle <ralf@linux-mips.org>, Russell King <linux@armlinux.org.uk>, Rabin Vincent <rabin@rab.in>, Paul Mackerras <paulus@samba.org>, Anton Blanchard <anton@samba.org>, linuxppc-dev@lists.ozlabs.org, Ingo Molnar <mingo@kernel.org>, linux-arm-kernel@lists.infradead.org, Zhigang Lu <zlu@ezchip.com>, Michael Ellerman <mpe@ellerman.id.au> Subject: Re: [PATCH] jump_label: align jump_entry table to at least 4-bytes Date: Tue, 28 Feb 2017 10:16:45 -0800 [thread overview] Message-ID: <cdf98840-8d43-2c58-e2f9-75ae8fb8a600@caviumnetworks.com> (raw) In-Reply-To: <20170228112144.65455de5@gandalf.local.home> On 02/28/2017 08:21 AM, Steven Rostedt wrote: > On Tue, 28 Feb 2017 10:25:46 +0530 > Sachin Sant <sachinp@linux.vnet.ibm.com> wrote: > >> File: ./net/ipv4/xfrm4_input.o >> [12] __jump_table PROGBITS 0000000000000000 000639 000018 18 WAM 0 0 1 >> File: ./net/ipv4/udplite.o >> File: ./net/ipv4/xfrm4_output.o >> [ 9] __jump_table PROGBITS 0000000000000000 000481 000018 18 WAM 0 0 1 > > Looks like there's some issues right there. Those look good to me 18/18 = 1 with no remainder. The odd numbers are the offset of the section in the ELF file. If you look at the stack trace, it seems that it is during module loading. Are the primitives for generating the tables doing something different for the module case? I am not familiar enough with the powerpc ABIs to know. Try this: $ perl -n -e 's/\[ /\[/; my @f = split " "; print hex($f[5]) % 0x18 if $#f > 5; print $_' <~/jump_table.log There are no entries with size that is not a multiple of 0x18. I think my patch to add the ENTSIZE is not doing anything here. I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing some sort of problem due to that. > > -- Steve >
WARNING: multiple messages have this Message-ID (diff)
From: ddaney@caviumnetworks.com (David Daney) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH] jump_label: align jump_entry table to at least 4-bytes Date: Tue, 28 Feb 2017 10:16:45 -0800 [thread overview] Message-ID: <cdf98840-8d43-2c58-e2f9-75ae8fb8a600@caviumnetworks.com> (raw) In-Reply-To: <20170228112144.65455de5@gandalf.local.home> On 02/28/2017 08:21 AM, Steven Rostedt wrote: > On Tue, 28 Feb 2017 10:25:46 +0530 > Sachin Sant <sachinp@linux.vnet.ibm.com> wrote: > >> File: ./net/ipv4/xfrm4_input.o >> [12] __jump_table PROGBITS 0000000000000000 000639 000018 18 WAM 0 0 1 >> File: ./net/ipv4/udplite.o >> File: ./net/ipv4/xfrm4_output.o >> [ 9] __jump_table PROGBITS 0000000000000000 000481 000018 18 WAM 0 0 1 > > Looks like there's some issues right there. Those look good to me 18/18 = 1 with no remainder. The odd numbers are the offset of the section in the ELF file. If you look at the stack trace, it seems that it is during module loading. Are the primitives for generating the tables doing something different for the module case? I am not familiar enough with the powerpc ABIs to know. Try this: $ perl -n -e 's/\[ /\[/; my @f = split " "; print hex($f[5]) % 0x18 if $#f > 5; print $_' <~/jump_table.log There are no entries with size that is not a multiple of 0x18. I think my patch to add the ENTSIZE is not doing anything here. I suspect that the alignment of the __jump_table section in the .ko files is not correct, and you are seeing some sort of problem due to that. > > -- Steve >
next prev parent reply other threads:[~2017-02-28 18:53 UTC|newest] Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-02-27 18:49 [PATCH] jump_label: align jump_entry table to at least 4-bytes Jason Baron 2017-02-27 18:49 ` Jason Baron 2017-02-27 18:57 ` David Daney 2017-02-27 18:57 ` David Daney 2017-02-27 19:18 ` Jason Baron 2017-02-27 19:18 ` Jason Baron 2017-02-27 19:59 ` David Daney 2017-02-27 19:59 ` David Daney 2017-02-27 21:06 ` Steven Rostedt 2017-02-27 21:06 ` Steven Rostedt 2017-02-27 21:41 ` David Daney 2017-02-27 21:41 ` David Daney 2017-02-27 22:09 ` Steven Rostedt 2017-02-27 22:09 ` Steven Rostedt 2017-02-27 22:21 ` David Daney 2017-02-27 22:21 ` David Daney 2017-02-27 22:21 ` David Daney 2017-02-27 22:36 ` Steven Rostedt 2017-02-27 22:36 ` Steven Rostedt 2017-02-27 22:45 ` David Daney 2017-02-27 22:45 ` David Daney 2017-02-27 22:50 ` Jason Baron 2017-02-27 22:50 ` Jason Baron 2017-02-27 23:34 ` David Daney 2017-02-27 23:34 ` David Daney 2017-02-28 4:55 ` Sachin Sant 2017-02-28 16:21 ` Steven Rostedt 2017-02-28 16:21 ` Steven Rostedt 2017-02-28 18:16 ` David Daney [this message] 2017-02-28 18:16 ` David Daney 2017-02-28 18:39 ` Jason Baron 2017-02-28 18:39 ` Jason Baron 2017-02-28 19:05 ` David Daney 2017-02-28 19:05 ` David Daney 2017-02-28 19:22 ` David Daney 2017-02-28 19:22 ` David Daney 2017-02-28 19:34 ` Jason Baron 2017-02-28 19:34 ` Jason Baron 2017-02-28 20:15 ` David Daney 2017-02-28 20:15 ` David Daney 2017-02-28 20:15 ` David Daney 2017-02-28 22:41 ` Jason Baron 2017-02-28 22:41 ` Jason Baron 2017-03-01 6:34 ` Michael Ellerman 2017-03-01 6:34 ` Michael Ellerman 2017-03-01 16:40 ` David Daney 2017-03-01 16:40 ` David Daney 2017-03-01 20:02 ` Jason Baron 2017-03-01 20:02 ` Jason Baron 2017-03-01 21:12 ` David Daney 2017-03-01 21:12 ` David Daney 2017-03-01 7:12 ` Sachin Sant 2017-03-01 7:12 ` Sachin Sant 2017-02-27 22:58 ` Steven Rostedt 2017-02-27 22:58 ` Steven Rostedt 2017-03-06 2:16 ` [PATCH] MIPS: jump_lable: Give __jump_table elements an entsize kbuild test robot 2017-03-06 2:16 ` kbuild test robot
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cdf98840-8d43-2c58-e2f9-75ae8fb8a600@caviumnetworks.com \ --to=ddaney@caviumnetworks.com \ --cc=anton@samba.org \ --cc=cmetcalf@mellanox.com \ --cc=jbaron@akamai.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mips@linux-mips.org \ --cc=linux@armlinux.org.uk \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mingo@kernel.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=rabin@rab.in \ --cc=ralf@linux-mips.org \ --cc=rostedt@goodmis.org \ --cc=sachinp@linux.vnet.ibm.com \ --cc=zlu@ezchip.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.