* [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-10-30 6:21 Vimal Singh
2009-10-30 8:42 ` Vimal Singh
0 siblings, 1 reply; 20+ messages in thread
From: Vimal Singh @ 2009-10-30 6:21 UTC (permalink / raw)
To: Linux MTD
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
mtd_info *mtd, u_char *buf, int len)
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-10-30 6:21 [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c' Vimal Singh
@ 2009-10-30 8:42 ` Vimal Singh
2009-11-03 8:18 ` Artem Bityutskiy
0 siblings, 1 reply; 20+ messages in thread
From: Vimal Singh @ 2009-10-30 8:42 UTC (permalink / raw)
To: Linux MTD, linux-omap
Looping Linux-omap mailing list.
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
mtd_info *mtd, u_char *buf, int len)
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-10-30 8:42 ` Vimal Singh
@ 2009-11-03 8:18 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-03 8:18 UTC (permalink / raw)
To: Vimal Singh; +Cc: Linux MTD, linux-omap
On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
> Looping Linux-omap mailing list.
>
>
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
[dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
ERROR: patch seems to be corrupt (line wrapped?)
#94: FILE: drivers/mtd/nand/omap2.c:500:
mtd_info *mtd, u_char *buf, int len)
total: 1 errors, 0 warnings, 16 lines checked
vimal has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[dedekind@eru l2-mtd-2.6.git]$ vim vimal
[dedekind@eru l2-mtd-2.6.git]$ git am vimal
Applying: Fixing compilation warning for 'nand/omap2.c'
fatal: corrupt patch at line 10
Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
[dedekind@eru l2-mtd-2.6.git]$
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-03 8:18 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-03 8:18 UTC (permalink / raw)
To: Vimal Singh; +Cc: linux-omap, Linux MTD
On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
> Looping Linux-omap mailing list.
>
>
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
[dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
ERROR: patch seems to be corrupt (line wrapped?)
#94: FILE: drivers/mtd/nand/omap2.c:500:
mtd_info *mtd, u_char *buf, int len)
total: 1 errors, 0 warnings, 16 lines checked
vimal has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
[dedekind@eru l2-mtd-2.6.git]$ vim vimal
[dedekind@eru l2-mtd-2.6.git]$ git am vimal
Applying: Fixing compilation warning for 'nand/omap2.c'
fatal: corrupt patch at line 10
Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
[dedekind@eru l2-mtd-2.6.git]$
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-03 8:18 ` Artem Bityutskiy
@ 2009-11-03 8:38 ` Vimal Singh
-1 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-03 8:38 UTC (permalink / raw)
To: dedekind1; +Cc: Linux MTD, linux-omap
On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
>> Looping Linux-omap mailing list.
>>
>>
>> From: Vimal Singh <vimalsingh@ti.com>
>> Date: Fri, 30 Oct 2009 11:31:34 +0530
>> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>>
>> Fixing below warning in compilation:
>> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>>
>> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> [dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
> ERROR: patch seems to be corrupt (line wrapped?)
> #94: FILE: drivers/mtd/nand/omap2.c:500:
> mtd_info *mtd, u_char *buf, int len)
>
> total: 1 errors, 0 warnings, 16 lines checked
>
> vimal has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> [dedekind@eru l2-mtd-2.6.git]$ vim vimal
> [dedekind@eru l2-mtd-2.6.git]$ git am vimal
> Applying: Fixing compilation warning for 'nand/omap2.c'
> fatal: corrupt patch at line 10
> Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
> When you have resolved this problem run "git am --resolved".
> If you would prefer to skip this patch, instead run "git am --skip".
> To restore the original branch and stop patching run "git am --abort".
> [dedekind@eru l2-mtd-2.6.git]$
>
Grr... its again mailer's issue. Fixed this in below patch:
-vimal
From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
mtd_info *mtd, u_char
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-03 8:38 ` Vimal Singh
0 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-03 8:38 UTC (permalink / raw)
To: dedekind1; +Cc: linux-omap, Linux MTD
On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
>> Looping Linux-omap mailing list.
>>
>>
>> From: Vimal Singh <vimalsingh@ti.com>
>> Date: Fri, 30 Oct 2009 11:31:34 +0530
>> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>>
>> Fixing below warning in compilation:
>> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>>
>> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> [dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
> ERROR: patch seems to be corrupt (line wrapped?)
> #94: FILE: drivers/mtd/nand/omap2.c:500:
> mtd_info *mtd, u_char *buf, int len)
>
> total: 1 errors, 0 warnings, 16 lines checked
>
> vimal has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
> [dedekind@eru l2-mtd-2.6.git]$ vim vimal
> [dedekind@eru l2-mtd-2.6.git]$ git am vimal
> Applying: Fixing compilation warning for 'nand/omap2.c'
> fatal: corrupt patch at line 10
> Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
> When you have resolved this problem run "git am --resolved".
> If you would prefer to skip this patch, instead run "git am --skip".
> To restore the original branch and stop patching run "git am --abort".
> [dedekind@eru l2-mtd-2.6.git]$
>
Grr... its again mailer's issue. Fixed this in below patch:
-vimal
>From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
mtd_info *mtd, u_char
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-03 8:38 ` Vimal Singh
@ 2009-11-03 8:42 ` Artem Bityutskiy
-1 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-03 8:42 UTC (permalink / raw)
To: Vimal Singh; +Cc: Linux MTD, linux-omap
On Tue, 2009-11-03 at 14:08 +0530, Vimal Singh wrote:
> On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
> >> Looping Linux-omap mailing list.
> >>
> >>
> >> From: Vimal Singh <vimalsingh@ti.com>
> >> Date: Fri, 30 Oct 2009 11:31:34 +0530
> >> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
> >>
> >> Fixing below warning in compilation:
> >> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> >> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> >> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
> >>
> >> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> >> ---
> >> drivers/mtd/nand/omap2.c | 6 ++++--
> >> 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > [dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
> > ERROR: patch seems to be corrupt (line wrapped?)
> > #94: FILE: drivers/mtd/nand/omap2.c:500:
> > mtd_info *mtd, u_char *buf, int len)
> >
> > total: 1 errors, 0 warnings, 16 lines checked
> >
> > vimal has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > [dedekind@eru l2-mtd-2.6.git]$ vim vimal
> > [dedekind@eru l2-mtd-2.6.git]$ git am vimal
> > Applying: Fixing compilation warning for 'nand/omap2.c'
> > fatal: corrupt patch at line 10
> > Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
> > When you have resolved this problem run "git am --resolved".
> > If you would prefer to skip this patch, instead run "git am --skip".
> > To restore the original branch and stop patching run "git am --abort".
> > [dedekind@eru l2-mtd-2.6.git]$
> >
>
> Grr... its again mailer's issue. Fixed this in below patch:
>
> -vimal
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
git-send-email ...
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> mtd_info *mtd, u_char
:-) It is the same again.
Try to send the e-mail to yourself, then save it and apply with git-am.
If it works, send to the mailing list.
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
>
> /**
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-03 8:42 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-03 8:42 UTC (permalink / raw)
To: Vimal Singh; +Cc: linux-omap, Linux MTD
On Tue, 2009-11-03 at 14:08 +0530, Vimal Singh wrote:
> On Tue, Nov 3, 2009 at 1:48 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> > On Fri, 2009-10-30 at 14:12 +0530, Vimal Singh wrote:
> >> Looping Linux-omap mailing list.
> >>
> >>
> >> From: Vimal Singh <vimalsingh@ti.com>
> >> Date: Fri, 30 Oct 2009 11:31:34 +0530
> >> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
> >>
> >> Fixing below warning in compilation:
> >> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> >> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> >> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
> >>
> >> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> >> ---
> >> drivers/mtd/nand/omap2.c | 6 ++++--
> >> 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > [dedekind@eru l2-mtd-2.6.git]$ scripts/checkpatch.pl vimal
> > ERROR: patch seems to be corrupt (line wrapped?)
> > #94: FILE: drivers/mtd/nand/omap2.c:500:
> > mtd_info *mtd, u_char *buf, int len)
> >
> > total: 1 errors, 0 warnings, 16 lines checked
> >
> > vimal has style problems, please review. If any of these errors
> > are false positives report them to the maintainer, see
> > CHECKPATCH in MAINTAINERS.
> > [dedekind@eru l2-mtd-2.6.git]$ vim vimal
> > [dedekind@eru l2-mtd-2.6.git]$ git am vimal
> > Applying: Fixing compilation warning for 'nand/omap2.c'
> > fatal: corrupt patch at line 10
> > Patch failed at 0001 Fixing compilation warning for 'nand/omap2.c'
> > When you have resolved this problem run "git am --resolved".
> > If you would prefer to skip this patch, instead run "git am --skip".
> > To restore the original branch and stop patching run "git am --abort".
> > [dedekind@eru l2-mtd-2.6.git]$
> >
>
> Grr... its again mailer's issue. Fixed this in below patch:
>
> -vimal
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
git-send-email ...
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> mtd_info *mtd, u_char
:-) It is the same again.
Try to send the e-mail to yourself, then save it and apply with git-am.
If it works, send to the mailing list.
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
>
> /**
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-03 8:42 ` Artem Bityutskiy
@ 2009-11-03 9:01 ` Vimal Singh
-1 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-03 9:01 UTC (permalink / raw)
To: dedekind1; +Cc: Linux MTD, linux-omap
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 090ab87..92573d5 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> mtd_info *mtd, u_char
>
> :-) It is the same again.
>
> Try to send the e-mail to yourself, then save it and apply with git-am.
> If it works, send to the mailing list.
Below patch applies. Sorry for noise... :(
Thanks,
vimal
>From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-03 9:01 ` Vimal Singh
0 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-03 9:01 UTC (permalink / raw)
To: dedekind1; +Cc: linux-omap, Linux MTD
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 090ab87..92573d5 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> mtd_info *mtd, u_char
>
> :-) It is the same again.
>
> Try to send the e-mail to yourself, then save it and apply with git-am.
> If it works, send to the mailing list.
Below patch applies. Sorry for noise... :(
Thanks,
vimal
>From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
From: Vimal Singh <vimalsingh@ti.com>
Date: Fri, 30 Oct 2009 11:31:34 +0530
Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
1.5.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-03 9:01 ` Vimal Singh
@ 2009-11-10 14:20 ` Artem Bityutskiy
-1 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:20 UTC (permalink / raw)
To: Vimal Singh; +Cc: Linux MTD, linux-omap
On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> >> index 090ab87..92573d5 100644
> >> --- a/drivers/mtd/nand/omap2.c
> >> +++ b/drivers/mtd/nand/omap2.c
> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> >> mtd_info *mtd, u_char
> >
> > :-) It is the same again.
> >
> > Try to send the e-mail to yourself, then save it and apply with git-am.
> > If it works, send to the mailing list.
>
> Below patch applies. Sorry for noise... :(
>
> Thanks,
> vimal
>
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
I think that you should instead remove the 'const' modifier from the
'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
modifier, it should never change the bugger.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-10 14:20 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:20 UTC (permalink / raw)
To: Vimal Singh; +Cc: linux-omap, Linux MTD
On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> >> index 090ab87..92573d5 100644
> >> --- a/drivers/mtd/nand/omap2.c
> >> +++ b/drivers/mtd/nand/omap2.c
> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> >> mtd_info *mtd, u_char
> >
> > :-) It is the same again.
> >
> > Try to send the e-mail to yourself, then save it and apply with git-am.
> > If it works, send to the mailing list.
>
> Below patch applies. Sorry for noise... :(
>
> Thanks,
> vimal
>
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
I think that you should instead remove the 'const' modifier from the
'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
modifier, it should never change the bugger.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-03 9:01 ` Vimal Singh
@ 2009-11-10 14:24 ` Artem Bityutskiy
-1 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:24 UTC (permalink / raw)
To: Vimal Singh; +Cc: Linux MTD, linux-omap
On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> >> index 090ab87..92573d5 100644
> >> --- a/drivers/mtd/nand/omap2.c
> >> +++ b/drivers/mtd/nand/omap2.c
> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> >> mtd_info *mtd, u_char
> >
> > :-) It is the same again.
> >
> > Try to send the e-mail to yourself, then save it and apply with git-am.
> > If it works, send to the mailing list.
>
> Below patch applies. Sorry for noise... :(
>
> Thanks,
> vimal
>
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
>
> /**
BTW, this patch is still corrupted for me. And it is strange that I do
not see it in the archives, so I cannot check is this my setup which is
guilty, or it is you sending the patches incorrectly:
http://lists.infradead.org/pipermail/linux-mtd/2009-November/027918.html
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-10 14:24 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:24 UTC (permalink / raw)
To: Vimal Singh; +Cc: linux-omap, Linux MTD
On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> >> index 090ab87..92573d5 100644
> >> --- a/drivers/mtd/nand/omap2.c
> >> +++ b/drivers/mtd/nand/omap2.c
> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> >> mtd_info *mtd, u_char
> >
> > :-) It is the same again.
> >
> > Try to send the e-mail to yourself, then save it and apply with git-am.
> > If it works, send to the mailing list.
>
> Below patch applies. Sorry for noise... :(
>
> Thanks,
> vimal
>
>
> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> From: Vimal Singh <vimalsingh@ti.com>
> Date: Fri, 30 Oct 2009 11:31:34 +0530
> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>
> Fixing below warning in compilation:
> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>
> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> ---
> drivers/mtd/nand/omap2.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> index 090ab87..92573d5 100644
> --- a/drivers/mtd/nand/omap2.c
> +++ b/drivers/mtd/nand/omap2.c
> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> const u_char *buf, int len)
> {
> + u_char *p = (u_char *)buf;
> +
> if (len <= mtd->oobsize)
> - omap_write_buf_pref(mtd, buf, len);
> + omap_write_buf_pref(mtd, p, len);
> else
> /* start transfer in DMA mode */
> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> + omap_nand_dma_transfer(mtd, p, len, 0x1);
> }
>
> /**
BTW, this patch is still corrupted for me. And it is strange that I do
not see it in the archives, so I cannot check is this my setup which is
guilty, or it is you sending the patches incorrectly:
http://lists.infradead.org/pipermail/linux-mtd/2009-November/027918.html
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-10 14:20 ` Artem Bityutskiy
@ 2009-11-10 14:26 ` Artem Bityutskiy
-1 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:26 UTC (permalink / raw)
To: Vimal Singh; +Cc: Linux MTD, linux-omap
On Tue, 2009-11-10 at 16:20 +0200, Artem Bityutskiy wrote:
> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> > >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> > >> index 090ab87..92573d5 100644
> > >> --- a/drivers/mtd/nand/omap2.c
> > >> +++ b/drivers/mtd/nand/omap2.c
> > >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> > >> mtd_info *mtd, u_char
> > >
> > > :-) It is the same again.
> > >
> > > Try to send the e-mail to yourself, then save it and apply with git-am.
> > > If it works, send to the mailing list.
> >
> > Below patch applies. Sorry for noise... :(
> >
> > Thanks,
> > vimal
> >
> >
> > From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> > From: Vimal Singh <vimalsingh@ti.com>
> > Date: Fri, 30 Oct 2009 11:31:34 +0530
> > Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
> >
> > Fixing below warning in compilation:
> > drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> > drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> > 'omap_nand_dma_transfer' discards qualifiers from pointer target type
> >
> > Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> > ---
> > drivers/mtd/nand/omap2.c | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> > index 090ab87..92573d5 100644
> > --- a/drivers/mtd/nand/omap2.c
> > +++ b/drivers/mtd/nand/omap2.c
> > @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> > static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> > const u_char *buf, int len)
> > {
> > + u_char *p = (u_char *)buf;
> > +
> > if (len <= mtd->oobsize)
> > - omap_write_buf_pref(mtd, buf, len);
> > + omap_write_buf_pref(mtd, p, len);
> > else
> > /* start transfer in DMA mode */
> > - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> > + omap_nand_dma_transfer(mtd, p, len, 0x1);
> > }
>
> I think that you should instead remove the 'const' modifier from the
> 'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
> modifier, it should never change the bugger.
Sorry, s/bugger/buffer/
:-)
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-10 14:26 ` Artem Bityutskiy
0 siblings, 0 replies; 20+ messages in thread
From: Artem Bityutskiy @ 2009-11-10 14:26 UTC (permalink / raw)
To: Vimal Singh; +Cc: linux-omap, Linux MTD
On Tue, 2009-11-10 at 16:20 +0200, Artem Bityutskiy wrote:
> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
> > >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> > >> index 090ab87..92573d5 100644
> > >> --- a/drivers/mtd/nand/omap2.c
> > >> +++ b/drivers/mtd/nand/omap2.c
> > >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> > >> mtd_info *mtd, u_char
> > >
> > > :-) It is the same again.
> > >
> > > Try to send the e-mail to yourself, then save it and apply with git-am.
> > > If it works, send to the mailing list.
> >
> > Below patch applies. Sorry for noise... :(
> >
> > Thanks,
> > vimal
> >
> >
> > From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
> > From: Vimal Singh <vimalsingh@ti.com>
> > Date: Fri, 30 Oct 2009 11:31:34 +0530
> > Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
> >
> > Fixing below warning in compilation:
> > drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
> > drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
> > 'omap_nand_dma_transfer' discards qualifiers from pointer target type
> >
> > Signed-off-by: Vimal Singh <vimalsingh@ti.com>
> > ---
> > drivers/mtd/nand/omap2.c | 6 ++++--
> > 1 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
> > index 090ab87..92573d5 100644
> > --- a/drivers/mtd/nand/omap2.c
> > +++ b/drivers/mtd/nand/omap2.c
> > @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
> > static void omap_write_buf_dma_pref(struct mtd_info *mtd,
> > const u_char *buf, int len)
> > {
> > + u_char *p = (u_char *)buf;
> > +
> > if (len <= mtd->oobsize)
> > - omap_write_buf_pref(mtd, buf, len);
> > + omap_write_buf_pref(mtd, p, len);
> > else
> > /* start transfer in DMA mode */
> > - omap_nand_dma_transfer(mtd, buf, len, 0x1);
> > + omap_nand_dma_transfer(mtd, p, len, 0x1);
> > }
>
> I think that you should instead remove the 'const' modifier from the
> 'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
> modifier, it should never change the bugger.
Sorry, s/bugger/buffer/
:-)
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-10 14:26 ` Artem Bityutskiy
@ 2009-11-11 4:40 ` Vimal Singh
-1 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-11 4:40 UTC (permalink / raw)
To: dedekind1; +Cc: Linux MTD, linux-omap
On Tue, Nov 10, 2009 at 7:56 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2009-11-10 at 16:20 +0200, Artem Bityutskiy wrote:
>> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
>> > >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> > >> index 090ab87..92573d5 100644
>> > >> --- a/drivers/mtd/nand/omap2.c
>> > >> +++ b/drivers/mtd/nand/omap2.c
>> > >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> > >> mtd_info *mtd, u_char
>> > >
>> > > :-) It is the same again.
>> > >
>> > > Try to send the e-mail to yourself, then save it and apply with git-am.
>> > > If it works, send to the mailing list.
>> >
>> > Below patch applies. Sorry for noise... :(
>> >
>> > Thanks,
>> > vimal
>> >
>> >
>> > From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
>> > From: Vimal Singh <vimalsingh@ti.com>
>> > Date: Fri, 30 Oct 2009 11:31:34 +0530
>> > Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>> >
>> > Fixing below warning in compilation:
>> > drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> > drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> > 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>> >
>> > Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> > ---
>> > drivers/mtd/nand/omap2.c | 6 ++++--
>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> > index 090ab87..92573d5 100644
>> > --- a/drivers/mtd/nand/omap2.c
>> > +++ b/drivers/mtd/nand/omap2.c
>> > @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> > static void omap_write_buf_dma_pref(struct mtd_info *mtd,
>> > const u_char *buf, int len)
>> > {
>> > + u_char *p = (u_char *)buf;
>> > +
>> > if (len <= mtd->oobsize)
>> > - omap_write_buf_pref(mtd, buf, len);
>> > + omap_write_buf_pref(mtd, p, len);
>> > else
>> > /* start transfer in DMA mode */
>> > - omap_nand_dma_transfer(mtd, buf, len, 0x1);
>> > + omap_nand_dma_transfer(mtd, p, len, 0x1);
>> > }
>>
>> I think that you should instead remove the 'const' modifier from the
>> 'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
>> modifier, it should never change the bugger.
>
> Sorry, s/bugger/buffer/
> :-)
Write calls are intended to copy data bytes from supplied buffer to
NAND. So yes, these calls are not supposed to change this buffer.
--
Regards,
Vimal Singh
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-11 4:40 ` Vimal Singh
0 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-11 4:40 UTC (permalink / raw)
To: dedekind1; +Cc: linux-omap, Linux MTD
On Tue, Nov 10, 2009 at 7:56 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2009-11-10 at 16:20 +0200, Artem Bityutskiy wrote:
>> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
>> > >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> > >> index 090ab87..92573d5 100644
>> > >> --- a/drivers/mtd/nand/omap2.c
>> > >> +++ b/drivers/mtd/nand/omap2.c
>> > >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> > >> mtd_info *mtd, u_char
>> > >
>> > > :-) It is the same again.
>> > >
>> > > Try to send the e-mail to yourself, then save it and apply with git-am.
>> > > If it works, send to the mailing list.
>> >
>> > Below patch applies. Sorry for noise... :(
>> >
>> > Thanks,
>> > vimal
>> >
>> >
>> > From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
>> > From: Vimal Singh <vimalsingh@ti.com>
>> > Date: Fri, 30 Oct 2009 11:31:34 +0530
>> > Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>> >
>> > Fixing below warning in compilation:
>> > drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> > drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> > 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>> >
>> > Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> > ---
>> > drivers/mtd/nand/omap2.c | 6 ++++--
>> > 1 files changed, 4 insertions(+), 2 deletions(-)
>> >
>> > diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> > index 090ab87..92573d5 100644
>> > --- a/drivers/mtd/nand/omap2.c
>> > +++ b/drivers/mtd/nand/omap2.c
>> > @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> > static void omap_write_buf_dma_pref(struct mtd_info *mtd,
>> > const u_char *buf, int len)
>> > {
>> > + u_char *p = (u_char *)buf;
>> > +
>> > if (len <= mtd->oobsize)
>> > - omap_write_buf_pref(mtd, buf, len);
>> > + omap_write_buf_pref(mtd, p, len);
>> > else
>> > /* start transfer in DMA mode */
>> > - omap_nand_dma_transfer(mtd, buf, len, 0x1);
>> > + omap_nand_dma_transfer(mtd, p, len, 0x1);
>> > }
>>
>> I think that you should instead remove the 'const' modifier from the
>> 'omap_write_buf_dma_pref()' function. Indeed, if it has the 'const'
>> modifier, it should never change the bugger.
>
> Sorry, s/bugger/buffer/
> :-)
Write calls are intended to copy data bytes from supplied buffer to
NAND. So yes, these calls are not supposed to change this buffer.
--
Regards,
Vimal Singh
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
2009-11-10 14:24 ` Artem Bityutskiy
@ 2009-11-11 4:44 ` Vimal Singh
-1 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-11 4:44 UTC (permalink / raw)
To: dedekind1; +Cc: Linux MTD, linux-omap
On Tue, Nov 10, 2009 at 7:54 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
>> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> >> index 090ab87..92573d5 100644
>> >> --- a/drivers/mtd/nand/omap2.c
>> >> +++ b/drivers/mtd/nand/omap2.c
>> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> >> mtd_info *mtd, u_char
>> >
>> > :-) It is the same again.
>> >
>> > Try to send the e-mail to yourself, then save it and apply with git-am.
>> > If it works, send to the mailing list.
>>
>> Below patch applies. Sorry for noise... :(
>>
>> Thanks,
>> vimal
>>
>>
>> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
>> From: Vimal Singh <vimalsingh@ti.com>
>> Date: Fri, 30 Oct 2009 11:31:34 +0530
>> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>>
>> Fixing below warning in compilation:
>> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>>
>> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 090ab87..92573d5 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
>> const u_char *buf, int len)
>> {
>> + u_char *p = (u_char *)buf;
>> +
>> if (len <= mtd->oobsize)
>> - omap_write_buf_pref(mtd, buf, len);
>> + omap_write_buf_pref(mtd, p, len);
>> else
>> /* start transfer in DMA mode */
>> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
>> + omap_nand_dma_transfer(mtd, p, len, 0x1);
>> }
>>
>> /**
>
> BTW, this patch is still corrupted for me. And it is strange that I do
> not see it in the archives, so I cannot check is this my setup which is
> guilty, or it is you sending the patches incorrectly:
>
> http://lists.infradead.org/pipermail/linux-mtd/2009-November/027918.html
Here is the patch once again:
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 20+ messages in thread
* Re: [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c'
@ 2009-11-11 4:44 ` Vimal Singh
0 siblings, 0 replies; 20+ messages in thread
From: Vimal Singh @ 2009-11-11 4:44 UTC (permalink / raw)
To: dedekind1; +Cc: linux-omap, Linux MTD
On Tue, Nov 10, 2009 at 7:54 PM, Artem Bityutskiy <dedekind1@gmail.com> wrote:
> On Tue, 2009-11-03 at 14:31 +0530, Vimal Singh wrote:
>> >> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> >> index 090ab87..92573d5 100644
>> >> --- a/drivers/mtd/nand/omap2.c
>> >> +++ b/drivers/mtd/nand/omap2.c
>> >> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> >> mtd_info *mtd, u_char
>> >
>> > :-) It is the same again.
>> >
>> > Try to send the e-mail to yourself, then save it and apply with git-am.
>> > If it works, send to the mailing list.
>>
>> Below patch applies. Sorry for noise... :(
>>
>> Thanks,
>> vimal
>>
>>
>> From eebbd81141b196af2dc3f7a2650ce16b6b0d76ae Mon Sep 17 00:00:00 2001
>> From: Vimal Singh <vimalsingh@ti.com>
>> Date: Fri, 30 Oct 2009 11:31:34 +0530
>> Subject: [PATCH] Fixing compilation warning for 'nand/omap2.c'
>>
>> Fixing below warning in compilation:
>> drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
>> drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
>> 'omap_nand_dma_transfer' discards qualifiers from pointer target type
>>
>> Signed-off-by: Vimal Singh <vimalsingh@ti.com>
>> ---
>> drivers/mtd/nand/omap2.c | 6 ++++--
>> 1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
>> index 090ab87..92573d5 100644
>> --- a/drivers/mtd/nand/omap2.c
>> +++ b/drivers/mtd/nand/omap2.c
>> @@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
>> static void omap_write_buf_dma_pref(struct mtd_info *mtd,
>> const u_char *buf, int len)
>> {
>> + u_char *p = (u_char *)buf;
>> +
>> if (len <= mtd->oobsize)
>> - omap_write_buf_pref(mtd, buf, len);
>> + omap_write_buf_pref(mtd, p, len);
>> else
>> /* start transfer in DMA mode */
>> - omap_nand_dma_transfer(mtd, buf, len, 0x1);
>> + omap_nand_dma_transfer(mtd, p, len, 0x1);
>> }
>>
>> /**
>
> BTW, this patch is still corrupted for me. And it is strange that I do
> not see it in the archives, so I cannot check is this my setup which is
> guilty, or it is you sending the patches incorrectly:
>
> http://lists.infradead.org/pipermail/linux-mtd/2009-November/027918.html
Here is the patch once again:
Fixing below warning in compilation:
drivers/mtd/nand/omap2.c: In function 'omap_write_buf_dma_pref':
drivers/mtd/nand/omap2.c:508: warning: passing argument 2 of
'omap_nand_dma_transfer' discards qualifiers from pointer target type
Signed-off-by: Vimal Singh <vimalsingh@ti.com>
---
drivers/mtd/nand/omap2.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/mtd/nand/omap2.c b/drivers/mtd/nand/omap2.c
index 090ab87..92573d5 100644
--- a/drivers/mtd/nand/omap2.c
+++ b/drivers/mtd/nand/omap2.c
@@ -501,11 +501,13 @@ static void omap_read_buf_dma_pref(struct
static void omap_write_buf_dma_pref(struct mtd_info *mtd,
const u_char *buf, int len)
{
+ u_char *p = (u_char *)buf;
+
if (len <= mtd->oobsize)
- omap_write_buf_pref(mtd, buf, len);
+ omap_write_buf_pref(mtd, p, len);
else
/* start transfer in DMA mode */
- omap_nand_dma_transfer(mtd, buf, len, 0x1);
+ omap_nand_dma_transfer(mtd, p, len, 0x1);
}
/**
^ permalink raw reply related [flat|nested] 20+ messages in thread
end of thread, other threads:[~2009-11-11 4:44 UTC | newest]
Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-10-30 6:21 [PATCH 1/3] Fixing compilation warning for 'nand/omap2.c' Vimal Singh
2009-10-30 8:42 ` Vimal Singh
2009-11-03 8:18 ` Artem Bityutskiy
2009-11-03 8:18 ` Artem Bityutskiy
2009-11-03 8:38 ` Vimal Singh
2009-11-03 8:38 ` Vimal Singh
2009-11-03 8:42 ` Artem Bityutskiy
2009-11-03 8:42 ` Artem Bityutskiy
2009-11-03 9:01 ` Vimal Singh
2009-11-03 9:01 ` Vimal Singh
2009-11-10 14:20 ` Artem Bityutskiy
2009-11-10 14:20 ` Artem Bityutskiy
2009-11-10 14:26 ` Artem Bityutskiy
2009-11-10 14:26 ` Artem Bityutskiy
2009-11-11 4:40 ` Vimal Singh
2009-11-11 4:40 ` Vimal Singh
2009-11-10 14:24 ` Artem Bityutskiy
2009-11-10 14:24 ` Artem Bityutskiy
2009-11-11 4:44 ` Vimal Singh
2009-11-11 4:44 ` Vimal Singh
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.