* [PATCH 0/1] send-pull-request bugfix
@ 2011-01-22 0:21 Scott Garman
2011-01-22 0:22 ` [PATCH 1/1] send-pull-request: unset $TO and $CC from environment Scott Garman
2011-01-28 1:30 ` [PATCH 0/1] send-pull-request bugfix Saul Wold
0 siblings, 2 replies; 4+ messages in thread
From: Scott Garman @ 2011-01-22 0:21 UTC (permalink / raw)
To: poky
Hi Saul,
Darren Hart and I discovered that when $CC is set (which
our meta-toolchain environment script sets up), the value
leaks into the use of this script. Unsetting $TO as well
just to be thorough. This pull request fixes that.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: sgarman/pull-request-fix
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix
Thanks,
Scott Garman <scott.a.garman@intel.com>
---
Scott Garman (1):
send-pull-request: unset $TO and $CC from environment
scripts/send-pull-request | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/1] send-pull-request: unset $TO and $CC from environment
2011-01-22 0:21 [PATCH 0/1] send-pull-request bugfix Scott Garman
@ 2011-01-22 0:22 ` Scott Garman
2011-01-24 22:58 ` Darren Hart
2011-01-28 1:30 ` [PATCH 0/1] send-pull-request bugfix Saul Wold
1 sibling, 1 reply; 4+ messages in thread
From: Scott Garman @ 2011-01-22 0:22 UTC (permalink / raw)
To: poky
Darren Hart and I discovered that when $CC is set (which
our meta-toolchain environment script sets up), the value
leaks into the use of this script. Unsetting $TO as well
just to be thorough.
Signed-off-by: Scott Garman <scott.a.garman@intel.com>
---
scripts/send-pull-request | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/scripts/send-pull-request b/scripts/send-pull-request
index 9872c0d..a66d4dc 100755
--- a/scripts/send-pull-request
+++ b/scripts/send-pull-request
@@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
PULL_MTA="sendmail"
fi
+# Prevent environment leakage to these vars.
+unset TO
+unset CC
+
usage()
{
cat <<EOM
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] send-pull-request: unset $TO and $CC from environment
2011-01-22 0:22 ` [PATCH 1/1] send-pull-request: unset $TO and $CC from environment Scott Garman
@ 2011-01-24 22:58 ` Darren Hart
0 siblings, 0 replies; 4+ messages in thread
From: Darren Hart @ 2011-01-24 22:58 UTC (permalink / raw)
To: Scott Garman; +Cc: poky
On 01/21/2011 04:22 PM, Scott Garman wrote:
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough.
>
> Signed-off-by: Scott Garman<scott.a.garman@intel.com>
Thanks Scott!
Acked-by: Darren Hart <dvhart@linux.intel.com>
> ---
> scripts/send-pull-request | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/send-pull-request b/scripts/send-pull-request
> index 9872c0d..a66d4dc 100755
> --- a/scripts/send-pull-request
> +++ b/scripts/send-pull-request
> @@ -6,6 +6,10 @@ if [ -z "$PULL_MTA" ]; then
> PULL_MTA="sendmail"
> fi
>
> +# Prevent environment leakage to these vars.
> +unset TO
> +unset CC
> +
> usage()
> {
> cat<<EOM
--
Darren Hart
Intel Open Source Technology Center
Yocto Project - Linux Kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 0/1] send-pull-request bugfix
2011-01-22 0:21 [PATCH 0/1] send-pull-request bugfix Scott Garman
2011-01-22 0:22 ` [PATCH 1/1] send-pull-request: unset $TO and $CC from environment Scott Garman
@ 2011-01-28 1:30 ` Saul Wold
1 sibling, 0 replies; 4+ messages in thread
From: Saul Wold @ 2011-01-28 1:30 UTC (permalink / raw)
To: Scott Garman; +Cc: poky
On 01/21/2011 04:21 PM, Scott Garman wrote:
> Hi Saul,
>
> Darren Hart and I discovered that when $CC is set (which
> our meta-toolchain environment script sets up), the value
> leaks into the use of this script. Unsetting $TO as well
> just to be thorough. This pull request fixes that.
>
> Pull URL: git://git.pokylinux.org/poky-contrib.git
> Branch: sgarman/pull-request-fix
> Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=sgarman/pull-request-fix
>
> Thanks,
> Scott Garman<scott.a.garman@intel.com>
> ---
>
>
> Scott Garman (1):
> send-pull-request: unset $TO and $CC from environment
>
> scripts/send-pull-request | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> _______________________________________________
> poky mailing list
> poky@yoctoproject.org
> https://lists.yoctoproject.org/listinfo/poky
>
Pulled into Master
Thanks
Sau!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-28 1:30 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-22 0:21 [PATCH 0/1] send-pull-request bugfix Scott Garman
2011-01-22 0:22 ` [PATCH 1/1] send-pull-request: unset $TO and $CC from environment Scott Garman
2011-01-24 22:58 ` Darren Hart
2011-01-28 1:30 ` [PATCH 0/1] send-pull-request bugfix Saul Wold
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.