* [PATCH 0/1] gdk-pixbuf: Add --with-x11 when building lsb image
@ 2012-04-27 8:39 Xiaofeng Yan
2012-04-27 8:39 ` [PATCH 1/1] " Xiaofeng Yan
0 siblings, 1 reply; 5+ messages in thread
From: Xiaofeng Yan @ 2012-04-27 8:39 UTC (permalink / raw)
To: openembedded-core
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
Hi Richard,
This is V2 for fixing bug 2284. I made some modification according to your suggestion.
Please review it again.
The following was your suggestion:
We should be using the linuxstdbase override and also make it
conditional on x11 being in DISTRO_FEATURES.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/2284
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/2284
Thanks,
Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
Xiaofeng Yan (1):
gdk-pixbuf: Add --with-x11 when building lsb image
meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image
2012-04-27 8:39 [PATCH 0/1] gdk-pixbuf: Add --with-x11 when building lsb image Xiaofeng Yan
@ 2012-04-27 8:39 ` Xiaofeng Yan
2012-04-27 10:58 ` Richard Purdie
0 siblings, 1 reply; 5+ messages in thread
From: Xiaofeng Yan @ 2012-04-27 8:39 UTC (permalink / raw)
To: openembedded-core
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
Use the linuxstdbase override and also make it
conditional on x11 being in DISTRO_FEATURES for passing lsb test
[YOCTO #2284]
Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
index e31f717..3000c79 100644
--- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
+++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
@@ -19,7 +19,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
-PR = "r0"
+PR = "r1"
inherit autotools pkgconfig gettext
@@ -28,10 +28,11 @@ LIBV = "2.10.0"
EXTRA_OECONF = "\
--without-libtiff \
--with-libpng \
- --without-x11 \
--disable-introspection \
"
+EXTRA_OECONF_append_linuxstdbase = " ${@base_contains('DISTRO_FEATURES', 'x11', '--with-x11', '--without-x11', d)}"
+
FILES_${PN} = "${bindir}/gdk-pixbuf-query-loaders \
${libdir}/lib*.so.*"
--
1.7.0.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image
2012-04-27 8:39 ` [PATCH 1/1] " Xiaofeng Yan
@ 2012-04-27 10:58 ` Richard Purdie
2012-04-28 3:19 ` Xiaofeng Yan
0 siblings, 1 reply; 5+ messages in thread
From: Richard Purdie @ 2012-04-27 10:58 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Fri, 2012-04-27 at 16:39 +0800, Xiaofeng Yan wrote:
> From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
>
> LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
> because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
> Use the linuxstdbase override and also make it
> conditional on x11 being in DISTRO_FEATURES for passing lsb test
>
> [YOCTO #2284]
>
> Signed-off-by: Xiaofeng Yan <xiaofeng.yan@windriver.com>
> ---
> meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> index e31f717..3000c79 100644
> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
> @@ -19,7 +19,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
> SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
> SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>
> -PR = "r0"
> +PR = "r1"
>
> inherit autotools pkgconfig gettext
Your patch will leave it enabled in the non-lsb case under many
circumstances. How about something like:
@@ -28,10 +28,13 @@ LIBV = "2.10.0"
EXTRA_OECONF = "\
--without-libtiff \
--with-libpng \
- --without-x11 \
+ ${X11DEPENDS} \
--disable-introspection \
"
+X11DEPENDS = "--without-x11"
+X11DEPENDS_linuxstdbase = "${@base_contains('DISTRO_FEATURES', 'x11', '--with-x11', '--without-x11', d)}"
+
FILES_${PN} = "${bindir}/gdk-pixbuf-query-loaders \
${libdir}/lib*.so.*"
I'd also like to split the library into a separate package.
Cheers,
Richard
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/1] gdk-pixbuf: Add --with-x11 when building lsb image
2012-04-27 10:58 ` Richard Purdie
@ 2012-04-28 3:19 ` Xiaofeng Yan
0 siblings, 0 replies; 5+ messages in thread
From: Xiaofeng Yan @ 2012-04-28 3:19 UTC (permalink / raw)
To: openembedded-core
On 2012年04月27日 18:58, Richard Purdie wrote:
> On Fri, 2012-04-27 at 16:39 +0800, Xiaofeng Yan wrote:
>> From: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>>
>> LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
>> because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
>> Use the linuxstdbase override and also make it
>> conditional on x11 being in DISTRO_FEATURES for passing lsb test
>>
>> [YOCTO #2284]
>>
>> Signed-off-by: Xiaofeng Yan<xiaofeng.yan@windriver.com>
>> ---
>> meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 5 +++--
>> 1 files changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> index e31f717..3000c79 100644
>> --- a/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> +++ b/meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb
>> @@ -19,7 +19,7 @@ SRC_URI = "http://ftp.acc.umu.se/pub/GNOME/sources/gdk-pixbuf/2.24/gdk-pixbuf-${
>> SRC_URI[md5sum] = "72f39b34b20f68148c1609bd27415412"
>> SRC_URI[sha256sum] = "da7a3f00db360913716368e19e336402755cafa93769f3cfa28a969303e4bee1"
>>
>> -PR = "r0"
>> +PR = "r1"
>>
>> inherit autotools pkgconfig gettext
> Your patch will leave it enabled in the non-lsb case under many
> circumstances. How about something like:
>
> @@ -28,10 +28,13 @@ LIBV = "2.10.0"
> EXTRA_OECONF = "\
> --without-libtiff \
> --with-libpng \
> - --without-x11 \
> + ${X11DEPENDS} \
> --disable-introspection \
> "
>
> +X11DEPENDS = "--without-x11"
> +X11DEPENDS_linuxstdbase = "${@base_contains('DISTRO_FEATURES', 'x11', '--with-x11', '--without-x11', d)}"
> +
> FILES_${PN} = "${bindir}/gdk-pixbuf-query-loaders \
> ${libdir}/lib*.so.*"
>
>
> I'd also like to split the library into a separate package.
got it, thanks for your suggestion.
> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH 0/1]:gdk-pixbuf: Add --with-x11 when building lsb image
@ 2012-04-24 5:50 Xiaofeng Yan
0 siblings, 0 replies; 5+ messages in thread
From: Xiaofeng Yan @ 2012-04-24 5:50 UTC (permalink / raw)
To: openembedded-core
From: Xiaofeng Yan <xiaofeng.yan@windriver.com>
LSB Test Suite complain "no library libgdk_pixbuf_xlib-2.0.so.0" \
because of having "--without-x11" for gdk-pixbuf_2.24.1.bb.
For passing lsb test I add PACKAGECONFIG support to the recipe and \
have poky-lsb turn on the poky-lsb distro for this recipe.
Pull URL: git://git.pokylinux.org/poky-contrib.git
Branch: xiaofeng/2248
Browse: http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=xiaofeng/2248
Thanks,
Xiaofeng Yan <xiaofeng.yan@windriver.com>
---
Xiaofeng Yan (1):
gdk-pixbuf: Add --with-x11 when building lsb image
meta/recipes-gnome/gdk-pixbuf/gdk-pixbuf_2.24.1.bb | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2012-04-28 3:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-04-27 8:39 [PATCH 0/1] gdk-pixbuf: Add --with-x11 when building lsb image Xiaofeng Yan
2012-04-27 8:39 ` [PATCH 1/1] " Xiaofeng Yan
2012-04-27 10:58 ` Richard Purdie
2012-04-28 3:19 ` Xiaofeng Yan
-- strict thread matches above, loose matches on Subject: below --
2012-04-24 5:50 [PATCH 0/1]:gdk-pixbuf: " Xiaofeng Yan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.