* [PATCH 0/1] perf: split package
@ 2014-07-16 8:00 Chong Lu
2014-07-16 8:00 ` [PATCH 1/1] " Chong Lu
0 siblings, 1 reply; 9+ messages in thread
From: Chong Lu @ 2014-07-16 8:00 UTC (permalink / raw)
To: openembedded-core
The following changes since commit 1dcdd877c7946be4c0b1203deb14e2f842f9d0c2:
bitbake: toasterui: fix build - project identification (2014-07-14 14:10:03 +0100)
are available in the git repository at:
git://git.pokylinux.org/poky-contrib chonglu/perf
http://git.pokylinux.org/cgit.cgi/poky-contrib/log/?h=chonglu/perf
Chong Lu (1):
perf: split package
meta/recipes-kernel/perf/perf.bb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
--
1.9.1
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/1] perf: split package
2014-07-16 8:00 [PATCH 0/1] perf: split package Chong Lu
@ 2014-07-16 8:00 ` Chong Lu
2014-07-16 13:04 ` Bruce Ashfield
0 siblings, 1 reply; 9+ messages in thread
From: Chong Lu @ 2014-07-16 8:00 UTC (permalink / raw)
To: openembedded-core
Fix incorrect paths to split perf package.
Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
---
meta/recipes-kernel/perf/perf.bb | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
index 20968f9..781a738 100644
--- a/meta/recipes-kernel/perf/perf.bb
+++ b/meta/recipes-kernel/perf/perf.bb
@@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}"
FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
-FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
-FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
-FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python"
-FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
+FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
+FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
+FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python"
+FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
INHIBIT_PACKAGE_DEBUG_SPLIT="1"
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-16 8:00 ` [PATCH 1/1] " Chong Lu
@ 2014-07-16 13:04 ` Bruce Ashfield
2014-07-17 1:43 ` Chong Lu
0 siblings, 1 reply; 9+ messages in thread
From: Bruce Ashfield @ 2014-07-16 13:04 UTC (permalink / raw)
To: Chong Lu; +Cc: Patches and discussions about the oe-core layer
On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
> Fix incorrect paths to split perf package.
Can you elaborate here ? This commit message doesn't really tell us much.
Why is the current split incorrect ? What is the symptom and result of the
incorrect split ? Are the package contents the same after this change ?
Bruce
>
> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
> ---
> meta/recipes-kernel/perf/perf.bb | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
> index 20968f9..781a738 100644
> --- a/meta/recipes-kernel/perf/perf.bb
> +++ b/meta/recipes-kernel/perf/perf.bb
> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}"
>
> FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
> -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python"
> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
> +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python"
> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>
>
> INHIBIT_PACKAGE_DEBUG_SPLIT="1"
> --
> 1.9.1
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-16 13:04 ` Bruce Ashfield
@ 2014-07-17 1:43 ` Chong Lu
2014-07-17 2:13 ` Bruce Ashfield
0 siblings, 1 reply; 9+ messages in thread
From: Chong Lu @ 2014-07-17 1:43 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>> Fix incorrect paths to split perf package.
> Can you elaborate here ? This commit message doesn't really tell us much.
> Why is the current split incorrect ? What is the symptom and result of the
> incorrect split ? Are the package contents the same after this change ?
>
> Bruce
Hi Bruce,
Currently, perf can't split to perf-archive, perf-tests, perf-python and
perf-perl.
All files are included in perf package. For example, like perf-tests
package:
It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
'${libdir}/perf/perf-core/tests'.
So I change the files paths to make split successfully.
I will improve commit message and resend a V2.
Best Regards
Chong
>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>> ---
>> meta/recipes-kernel/perf/perf.bb | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/recipes-kernel/perf/perf.bb b/meta/recipes-kernel/perf/perf.bb
>> index 20968f9..781a738 100644
>> --- a/meta/recipes-kernel/perf/perf.bb
>> +++ b/meta/recipes-kernel/perf/perf.bb
>> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests ${RSUGGESTS_SCRIPTING}"
>>
>> FILES_${PN} += "${libexecdir}/perf-core ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
>> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
>> -FILES_${PN}-python = "${libdir}/python*/site-packages ${libdir}/perf/perf-core/scripts/python"
>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
>> +FILES_${PN}-python = "${libdir}/python*/site-packages ${exec_prefix}/libexec/perf-core/scripts/python"
>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>>
>>
>> INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>> --
>> 1.9.1
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-17 1:43 ` Chong Lu
@ 2014-07-17 2:13 ` Bruce Ashfield
2014-07-17 6:58 ` Chong Lu
0 siblings, 1 reply; 9+ messages in thread
From: Bruce Ashfield @ 2014-07-17 2:13 UTC (permalink / raw)
To: Chong Lu; +Cc: Patches and discussions about the oe-core layer
On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
>
> On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
>>
>> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>
>>> Fix incorrect paths to split perf package.
>>
>> Can you elaborate here ? This commit message doesn't really tell us much.
>> Why is the current split incorrect ? What is the symptom and result of the
>> incorrect split ? Are the package contents the same after this change ?
>>
>> Bruce
>
> Hi Bruce,
>
> Currently, perf can't split to perf-archive, perf-tests, perf-python and
> perf-perl.
> All files are included in perf package. For example, like perf-tests
> package:
> It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
> '${libdir}/perf/perf-core/tests'.
> So I change the files paths to make split successfully.
But that means, whether or not we like it, anything using perf has been using
those "non splits" and getting everything when perf is installed.
It's also might be in order to make the main perf package RDEPEND on
the other three, to keep it consistent. Make it a ?= so it can be overridden,
and then we can age it out over time.
Bruce
>
> I will improve commit message and resend a V2.
>
> Best Regards
> Chong
>
>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>>> ---
>>> meta/recipes-kernel/perf/perf.bb | 8 ++++----
>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>
>>> diff --git a/meta/recipes-kernel/perf/perf.bb
>>> b/meta/recipes-kernel/perf/perf.bb
>>> index 20968f9..781a738 100644
>>> --- a/meta/recipes-kernel/perf/perf.bb
>>> +++ b/meta/recipes-kernel/perf/perf.bb
>>> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests
>>> ${RSUGGESTS_SCRIPTING}"
>>>
>>> FILES_${PN} += "${libexecdir}/perf-core
>>> ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
>>> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
>>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
>>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
>>> -FILES_${PN}-python = "${libdir}/python*/site-packages
>>> ${libdir}/perf/perf-core/scripts/python"
>>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
>>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
>>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
>>> +FILES_${PN}-python = "${libdir}/python*/site-packages
>>> ${exec_prefix}/libexec/perf-core/scripts/python"
>>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>>>
>>>
>>> INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>>> --
>>> 1.9.1
>>>
>>> --
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>
>>
>>
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-17 2:13 ` Bruce Ashfield
@ 2014-07-17 6:58 ` Chong Lu
2014-07-17 7:04 ` Henning Heinold
2014-07-17 13:22 ` Bruce Ashfield
0 siblings, 2 replies; 9+ messages in thread
From: Chong Lu @ 2014-07-17 6:58 UTC (permalink / raw)
To: Bruce Ashfield; +Cc: Patches and discussions about the oe-core layer
On 07/17/2014 10:13 AM, Bruce Ashfield wrote:
> On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
>> On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
>>> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>> Fix incorrect paths to split perf package.
>>> Can you elaborate here ? This commit message doesn't really tell us much.
>>> Why is the current split incorrect ? What is the symptom and result of the
>>> incorrect split ? Are the package contents the same after this change ?
>>>
>>> Bruce
>> Hi Bruce,
>>
>> Currently, perf can't split to perf-archive, perf-tests, perf-python and
>> perf-perl.
>> All files are included in perf package. For example, like perf-tests
>> package:
>> It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
>> '${libdir}/perf/perf-core/tests'.
>> So I change the files paths to make split successfully.
> But that means, whether or not we like it, anything using perf has been using
> those "non splits" and getting everything when perf is installed.
>
> It's also might be in order to make the main perf package RDEPEND on
> the other three, to keep it consistent. Make it a ?= so it can be overridden,
> and then we can age it out over time.
>
> Bruce
Do you mean we should set RDEPENDS like:
RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we
should use
RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
to keep it consistent. Do you agree?
Or, we can also revert following commit to make all files in perf package.
commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
Author: Henning Heinold <henning@itconsulting-heinold.de>
Date: Mon Jun 9 23:21:29 2014 +0200
perf: split packging
Best Regards
Chong
>> I will improve commit message and resend a V2.
>>
>> Best Regards
>> Chong
>>
>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>>>> ---
>>>> meta/recipes-kernel/perf/perf.bb | 8 ++++----
>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> diff --git a/meta/recipes-kernel/perf/perf.bb
>>>> b/meta/recipes-kernel/perf/perf.bb
>>>> index 20968f9..781a738 100644
>>>> --- a/meta/recipes-kernel/perf/perf.bb
>>>> +++ b/meta/recipes-kernel/perf/perf.bb
>>>> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests
>>>> ${RSUGGESTS_SCRIPTING}"
>>>>
>>>> FILES_${PN} += "${libexecdir}/perf-core
>>>> ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
>>>> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
>>>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
>>>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
>>>> -FILES_${PN}-python = "${libdir}/python*/site-packages
>>>> ${libdir}/perf/perf-core/scripts/python"
>>>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
>>>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
>>>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
>>>> +FILES_${PN}-python = "${libdir}/python*/site-packages
>>>> ${exec_prefix}/libexec/perf-core/scripts/python"
>>>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>>>>
>>>>
>>>> INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>>>> --
>>>> 1.9.1
>>>>
>>>> --
>>>> _______________________________________________
>>>> Openembedded-core mailing list
>>>> Openembedded-core@lists.openembedded.org
>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>>>
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-17 6:58 ` Chong Lu
@ 2014-07-17 7:04 ` Henning Heinold
2014-07-17 7:52 ` Chong Lu
2014-07-17 13:22 ` Bruce Ashfield
1 sibling, 1 reply; 9+ messages in thread
From: Henning Heinold @ 2014-07-17 7:04 UTC (permalink / raw)
To: Patches and discussions about the oe-core layer
On Thu, Jul 17, 2014 at 02:58:46PM +0800, Chong Lu wrote:
>
> On 07/17/2014 10:13 AM, Bruce Ashfield wrote:
> >On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
> >>On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
> >>>On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
> >>>>Fix incorrect paths to split perf package.
> >>>Can you elaborate here ? This commit message doesn't really tell us much.
> >>>Why is the current split incorrect ? What is the symptom and result of the
> >>>incorrect split ? Are the package contents the same after this change ?
> >>>
> >>>Bruce
> >>Hi Bruce,
> >>
> >>Currently, perf can't split to perf-archive, perf-tests, perf-python and
> >>perf-perl.
> >>All files are included in perf package. For example, like perf-tests
> >>package:
> >>It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
> >>'${libdir}/perf/perf-core/tests'.
> >>So I change the files paths to make split successfully.
> >But that means, whether or not we like it, anything using perf has been using
> >those "non splits" and getting everything when perf is installed.
> >
> >It's also might be in order to make the main perf package RDEPEND on
> >the other three, to keep it consistent. Make it a ?= so it can be overridden,
> >and then we can age it out over time.
> >
> >Bruce
> Do you mean we should set RDEPENDS like:
> RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>
> In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we
> should use
> RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
> to keep it consistent. Do you agree?
>
> Or, we can also revert following commit to make all files in perf package.
> commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
> Author: Henning Heinold <henning@itconsulting-heinold.de>
> Date: Mon Jun 9 23:21:29 2014 +0200
>
> perf: split packging
>
> Best Regards
> Chong
Please do not destroy the following use case, which is using perf top
WIHTOUT installing perl or python.
Bye Henning
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-17 7:04 ` Henning Heinold
@ 2014-07-17 7:52 ` Chong Lu
0 siblings, 0 replies; 9+ messages in thread
From: Chong Lu @ 2014-07-17 7:52 UTC (permalink / raw)
To: Henning Heinold, Patches and discussions about the oe-core layer
On 07/17/2014 03:04 PM, Henning Heinold wrote:
> On Thu, Jul 17, 2014 at 02:58:46PM +0800, Chong Lu wrote:
>> On 07/17/2014 10:13 AM, Bruce Ashfield wrote:
>>> On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>> On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
>>>>> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>>>> Fix incorrect paths to split perf package.
>>>>> Can you elaborate here ? This commit message doesn't really tell us much.
>>>>> Why is the current split incorrect ? What is the symptom and result of the
>>>>> incorrect split ? Are the package contents the same after this change ?
>>>>>
>>>>> Bruce
>>>> Hi Bruce,
>>>>
>>>> Currently, perf can't split to perf-archive, perf-tests, perf-python and
>>>> perf-perl.
>>>> All files are included in perf package. For example, like perf-tests
>>>> package:
>>>> It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
>>>> '${libdir}/perf/perf-core/tests'.
>>>> So I change the files paths to make split successfully.
>>> But that means, whether or not we like it, anything using perf has been using
>>> those "non splits" and getting everything when perf is installed.
>>>
>>> It's also might be in order to make the main perf package RDEPEND on
>>> the other three, to keep it consistent. Make it a ?= so it can be overridden,
>>> and then we can age it out over time.
>>>
>>> Bruce
>> Do you mean we should set RDEPENDS like:
>> RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>>
>> In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we
>> should use
>> RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>> to keep it consistent. Do you agree?
>>
>> Or, we can also revert following commit to make all files in perf package.
>> commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
>> Author: Henning Heinold <henning@itconsulting-heinold.de>
>> Date: Mon Jun 9 23:21:29 2014 +0200
>>
>> perf: split packging
>>
>> Best Regards
>> Chong
> Please do not destroy the following use case, which is using perf top
> WIHTOUT installing perl or python.
>
> Bye Henning
Hi Henning,
perf can't split to perf-archive, perf-tests, perf-python and perf-perl
from your patch.
Currently, all files are in perf package.
BR
Chong
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/1] perf: split package
2014-07-17 6:58 ` Chong Lu
2014-07-17 7:04 ` Henning Heinold
@ 2014-07-17 13:22 ` Bruce Ashfield
1 sibling, 0 replies; 9+ messages in thread
From: Bruce Ashfield @ 2014-07-17 13:22 UTC (permalink / raw)
To: Chong Lu; +Cc: Patches and discussions about the oe-core layer
On Thu, Jul 17, 2014 at 2:58 AM, Chong Lu <Chong.Lu@windriver.com> wrote:
>
> On 07/17/2014 10:13 AM, Bruce Ashfield wrote:
>>
>> On Wed, Jul 16, 2014 at 9:43 PM, Chong Lu <Chong.Lu@windriver.com> wrote:
>>>
>>> On 07/16/2014 09:04 PM, Bruce Ashfield wrote:
>>>>
>>>> On Wed, Jul 16, 2014 at 4:00 AM, Chong Lu <Chong.Lu@windriver.com>
>>>> wrote:
>>>>>
>>>>> Fix incorrect paths to split perf package.
>>>>
>>>> Can you elaborate here ? This commit message doesn't really tell us
>>>> much.
>>>> Why is the current split incorrect ? What is the symptom and result of
>>>> the
>>>> incorrect split ? Are the package contents the same after this change ?
>>>>
>>>> Bruce
>>>
>>> Hi Bruce,
>>>
>>> Currently, perf can't split to perf-archive, perf-tests, perf-python and
>>> perf-perl.
>>> All files are included in perf package. For example, like perf-tests
>>> package:
>>> It generates files in '${exec_prefix}/libexec/perf-core/tests', not in
>>> '${libdir}/perf/perf-core/tests'.
>>> So I change the files paths to make split successfully.
>>
>> But that means, whether or not we like it, anything using perf has been
>> using
>> those "non splits" and getting everything when perf is installed.
>>
>> It's also might be in order to make the main perf package RDEPEND on
>> the other three, to keep it consistent. Make it a ?= so it can be
>> overridden,
>> and then we can age it out over time.
>>
>> Bruce
>
> Do you mean we should set RDEPENDS like:
> RDEPENDS_${PN} ?= "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
>
> In perf.bb file, we have RDEPENDS_${PN} += "elfutils", so I think we should
> use
> RDEPENDS_${PN} += "${PN}-archive ${PN}-tests ${PN}-python ${PN}-perl"
> to keep it consistent. Do you agree?
Consistency is one thing, but it won't allow the split package to be
easily dropped,
so I'd still suggest that the ?= would make it easier to override.
Bruce
>
> Or, we can also revert following commit to make all files in perf package.
> commit 36c3e923df85e685b707fe6bd84b053a5e366fe4
> Author: Henning Heinold <henning@itconsulting-heinold.de>
> Date: Mon Jun 9 23:21:29 2014 +0200
>
> perf: split packging
>
> Best Regards
> Chong
>
>
>>> I will improve commit message and resend a V2.
>>>
>>> Best Regards
>>> Chong
>>>
>>>>> Signed-off-by: Chong Lu <Chong.Lu@windriver.com>
>>>>> ---
>>>>> meta/recipes-kernel/perf/perf.bb | 8 ++++----
>>>>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>>>>
>>>>> diff --git a/meta/recipes-kernel/perf/perf.bb
>>>>> b/meta/recipes-kernel/perf/perf.bb
>>>>> index 20968f9..781a738 100644
>>>>> --- a/meta/recipes-kernel/perf/perf.bb
>>>>> +++ b/meta/recipes-kernel/perf/perf.bb
>>>>> @@ -166,10 +166,10 @@ RSUGGESTS_${PN} += "${PN}-archive ${PN}-tests
>>>>> ${RSUGGESTS_SCRIPTING}"
>>>>>
>>>>> FILES_${PN} += "${libexecdir}/perf-core
>>>>> ${exec_prefix}/libexec/perf-core ${libdir}/traceevent"
>>>>> FILES_${PN}-dbg += "${libdir}/python*/site-packages/.debug"
>>>>> -FILES_${PN}-archive = "${libdir}/perf/perf-core/perf-archive"
>>>>> -FILES_${PN}-tests = "${libdir}/perf/perf-core/tests"
>>>>> -FILES_${PN}-python = "${libdir}/python*/site-packages
>>>>> ${libdir}/perf/perf-core/scripts/python"
>>>>> -FILES_${PN}-perl = "${libdir}/perf/perf-core/scripts/perl"
>>>>> +FILES_${PN}-archive = "${exec_prefix}/libexec/perf-core/perf-archive"
>>>>> +FILES_${PN}-tests = "${exec_prefix}/libexec/perf-core/tests"
>>>>> +FILES_${PN}-python = "${libdir}/python*/site-packages
>>>>> ${exec_prefix}/libexec/perf-core/scripts/python"
>>>>> +FILES_${PN}-perl = "${exec_prefix}/libexec/perf-core/scripts/perl"
>>>>>
>>>>>
>>>>> INHIBIT_PACKAGE_DEBUG_SPLIT="1"
>>>>> --
>>>>> 1.9.1
>>>>>
>>>>> --
>>>>> _______________________________________________
>>>>> Openembedded-core mailing list
>>>>> Openembedded-core@lists.openembedded.org
>>>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>>
>>>>
>>>>
>>
>>
>
--
"Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end"
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2014-07-17 13:22 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-16 8:00 [PATCH 0/1] perf: split package Chong Lu
2014-07-16 8:00 ` [PATCH 1/1] " Chong Lu
2014-07-16 13:04 ` Bruce Ashfield
2014-07-17 1:43 ` Chong Lu
2014-07-17 2:13 ` Bruce Ashfield
2014-07-17 6:58 ` Chong Lu
2014-07-17 7:04 ` Henning Heinold
2014-07-17 7:52 ` Chong Lu
2014-07-17 13:22 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.