All of lore.kernel.org
 help / color / mirror / Atom feed
From: Xin Long <lucien.xin@gmail.com>
To: network dev <netdev@vger.kernel.org>, linux-sctp@vger.kernel.org
Cc: davem@davemloft.net,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts
Date: Mon, 18 Mar 2019 20:05:58 +0800	[thread overview]
Message-ID: <cover.1552910681.git.lucien.xin@gmail.com> (raw)

This is a patchset to fix ignoring asoc_id for tcp-style sockets on
some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:

  [net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
  (https://patchwork.ozlabs.org/cover/1031706/)

As Marcelo suggested, we fix it on each setsockopt that is using
SCTP_CURRENT_ASSOC one by one by adding the check:

    if (sctp_style(sk, TCP))
        	xxx.xxx_assoc_id = SCTP_FUTURE_ASSOC;

so that assoc_id will be completely ingored for tcp-style socket on
setsockopts, and works as SCTP_FUTURE_ASSOC.

Marcelo Ricardo Leitner (1):
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt

Xin Long (12):
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DELAYED_SACK
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SNDINFO sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_CONTEXT
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_MAX_BURST
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_KEY
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_ACTIVE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_DELETE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_DEACTIVATE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_PRINFO sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_ENABLE_STREAM_RESET sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_EVENT sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_STREAM_SCHEDULER sockopt

 net/sctp/socket.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

-- 
2.1.0


WARNING: multiple messages have this Message-ID (diff)
From: Xin Long <lucien.xin@gmail.com>
To: network dev <netdev@vger.kernel.org>, linux-sctp@vger.kernel.org
Cc: davem@davemloft.net,
	Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
	Neil Horman <nhorman@tuxdriver.com>
Subject: [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts
Date: Mon, 18 Mar 2019 12:05:58 +0000	[thread overview]
Message-ID: <cover.1552910681.git.lucien.xin@gmail.com> (raw)

This is a patchset to fix ignoring asoc_id for tcp-style sockets on
some setsockopts, introduced by SCTP_CURRENT_ASSOC of the patchset:

  [net-next,00/24] sctp: support SCTP_FUTURE/CURRENT/ALL_ASSOC
  (https://patchwork.ozlabs.org/cover/1031706/)

As Marcelo suggested, we fix it on each setsockopt that is using
SCTP_CURRENT_ASSOC one by one by adding the check:

    if (sctp_style(sk, TCP))
        	xxx.xxx_assoc_id = SCTP_FUTURE_ASSOC;

so that assoc_id will be completely ingored for tcp-style socket on
setsockopts, and works as SCTP_FUTURE_ASSOC.

Marcelo Ricardo Leitner (1):
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SEND_PARAM sockopt

Xin Long (12):
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DELAYED_SACK
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_SNDINFO sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_CONTEXT
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_MAX_BURST
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_KEY
    sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_ACTIVE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_DELETE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_AUTH_DEACTIVATE_KEY sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_DEFAULT_PRINFO sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_ENABLE_STREAM_RESET sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_EVENT sockopt
  sctp: fix ignoring asoc_id for tcp-style sockets on
    SCTP_STREAM_SCHEDULER sockopt

 net/sctp/socket.c | 39 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)

-- 
2.1.0

             reply	other threads:[~2019-03-18 12:06 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-18 12:05 Xin Long [this message]
2019-03-18 12:05 ` [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts Xin Long
2019-03-18 12:05 ` [PATCH net 01/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SEND_PARAM sockopt Xin Long
2019-03-18 12:05   ` [PATCH net 01/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SEND_PARAM sockop Xin Long
2019-03-18 12:06   ` [PATCH net 02/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DELAYED_SACK sockopt Xin Long
2019-03-18 12:06     ` Xin Long
2019-03-18 12:06     ` [PATCH net 03/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_SNDINFO sockopt Xin Long
2019-03-18 12:06       ` Xin Long
2019-03-18 12:06       ` [PATCH net 04/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_CONTEXT sockopt Xin Long
2019-03-18 12:06         ` Xin Long
2019-03-18 12:06         ` [PATCH net 05/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_MAX_BURST sockopt Xin Long
2019-03-18 12:06           ` Xin Long
2019-03-18 12:06           ` [PATCH net 06/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_KEY sockopt Xin Long
2019-03-18 12:06             ` Xin Long
2019-03-18 12:06             ` [PATCH net 07/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_ACTIVE_KEY sockopt Xin Long
2019-03-18 12:06               ` Xin Long
2019-03-18 12:06               ` [PATCH net 08/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_DELETE_KEY sockopt Xin Long
2019-03-18 12:06                 ` Xin Long
2019-03-18 12:06                 ` [PATCH net 09/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_DEACTIVATE_KEY sockopt Xin Long
2019-03-18 12:06                   ` [PATCH net 09/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_AUTH_DEACTIVATE_KEY socko Xin Long
2019-03-18 12:06                   ` [PATCH net 10/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_DEFAULT_PRINFO sockopt Xin Long
2019-03-18 12:06                     ` Xin Long
2019-03-18 12:06                     ` [PATCH net 11/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_ENABLE_STREAM_RESET sockopt Xin Long
2019-03-18 12:06                       ` [PATCH net 11/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_ENABLE_STREAM_RESET socko Xin Long
2019-03-18 12:06                       ` [PATCH net 12/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_EVENT sockopt Xin Long
2019-03-18 12:06                         ` Xin Long
2019-03-18 12:06                         ` [PATCH net 13/13] sctp: fix ignoring asoc_id for tcp-style sockets on SCTP_STREAM_SCHEDULER sockopt Xin Long
2019-03-18 12:06                           ` Xin Long
2019-03-19  1:31 ` [PATCH net 00/13] sctp: fix ignoring asoc_id for tcp-style sockets on some setsockopts David Miller
2019-03-19  1:31   ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1552910681.git.lucien.xin@gmail.com \
    --to=lucien.xin@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-sctp@vger.kernel.org \
    --cc=marcelo.leitner@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.