From: Matt Helsley <mhelsley@vmware.com>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Matt Helsley <mhelsley@vmware.com>
Subject: [PATCH v4 0/8] recordmcount cleanups
Date: Wed, 31 Jul 2019 11:24:08 -0700 [thread overview]
Message-ID: <cover.1564596289.git.mhelsley@vmware.com> (raw)
recordmcount presents unnecessary challenges to reviewers:
It pretends to wrap access to the ELF file in
uread/uwrite/ulseek functions which aren't related
the way you might think (i.e. not the way read, write,
and lseek are releated to each other).
It uses setjmp/longjmp to handle errors (and success)
during processing of the object files. This makes it
hard to review what functions are doing, how globals
change over time, etc.
There are some kernel style nits.
This series addresses all of those by removing un-helper functions,
unused parameters, and rewriting the error/success handling to
better resemble regular kernel C code.
--
This series was formerly part of a v3 posted under the subject
"Cleanup recordmcount and begin objtool conversion". I am
reposting it split into two series: these cleanups of recordmcount
and a second series that begins the conversion of the cleaned-up
recordmcount into an objtool subcommand called mcount.
v4:
Addressed feedback on v3 from Steven Rostedt:
Moved already_has_mcount into recordmcount.c to avoid
unnecessary multiple definitions.
Changed return semantics of find_secsym_ndx() to avoid
need for missing_sym (and multiple definitions)
and to separate the returned symbol info
(value, index) from success/failure indication.
Fixed up local variable declaration to follow inverted
christmas tree style.
Matt Helsley (8):
recordmcount: Remove redundant strcmp
recordmcount: Remove uread()
recordmcount: Remove unused fd from uwrite() and ulseek()
recordmcount: Rewrite error/success handling
recordmcount: Kernel style function signature formatting
recordmcount: Kernel style formatting
recordmcount: Remove redundant cleanup() calls
recordmcount: Clarify what cleanup() does
scripts/recordmcount.c | 321 ++++++++++++++++++++---------------------
scripts/recordmcount.h | 150 +++++++++++++------
2 files changed, 259 insertions(+), 212 deletions(-)
--
2.20.1
next reply other threads:[~2019-07-31 18:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 18:24 Matt Helsley [this message]
2019-07-31 18:24 ` [PATCH v4 1/8] recordmcount: Remove redundant strcmp Matt Helsley
2019-07-31 18:24 ` [PATCH v4 2/8] recordmcount: Remove uread() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 3/8] recordmcount: Remove unused fd from uwrite() and ulseek() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 4/8] recordmcount: Rewrite error/success handling Matt Helsley
2019-10-09 10:46 ` Uwe Kleine-König
2019-10-09 10:46 ` Uwe Kleine-König
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-10 16:23 ` Steven Rostedt
2019-10-10 16:23 ` Steven Rostedt
2019-10-10 20:14 ` Uwe Kleine-König
2019-10-10 20:14 ` Uwe Kleine-König
2019-07-31 18:24 ` [PATCH v4 5/8] recordmcount: Kernel style function signature formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 6/8] recordmcount: Kernel style formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 7/8] recordmcount: Remove redundant cleanup() calls Matt Helsley
2019-07-31 18:24 ` [PATCH v4 8/8] recordmcount: Clarify what cleanup() does Matt Helsley
2019-08-02 17:47 ` [PATCH v4 0/8] recordmcount cleanups Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1564596289.git.mhelsley@vmware.com \
--to=mhelsley@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.