From: Steven Rostedt <rostedt@goodmis.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Matt Helsley <mhelsley@vmware.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling
Date: Thu, 10 Oct 2019 12:23:21 -0400 [thread overview]
Message-ID: <20191010122321.7329329f@gandalf.local.home> (raw)
In-Reply-To: <20191009152217.whklst5vwrwvsjc4@pengutronix.de>
On Wed, 9 Oct 2019 17:22:18 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> > index 3796eb37fb12..6dbec46b7703 100644
> > --- a/scripts/recordmcount.h
> > +++ b/scripts/recordmcount.h
> > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *const relhdr,
> > mcountsym = get_mcountsym(sym0, relp, str0);
> >
> > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
> > - if (make_nop) {
> > + if (make_nop)
> > ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
> > - if (ret < 0)
> > - return -1;
> > - }
>
> Yes, this patch fixes building for me.
May I add to my patch:
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
?
-- Steve
WARNING: multiple messages have this Message-ID (diff)
From: Steven Rostedt <rostedt@goodmis.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>,
linux-arm-kernel@lists.infradead.org,
LKML <linux-kernel@vger.kernel.org>,
kernel@pengutronix.de, Matt Helsley <mhelsley@vmware.com>
Subject: Re: [PATCH v4 4/8] recordmcount: Rewrite error/success handling
Date: Thu, 10 Oct 2019 12:23:21 -0400 [thread overview]
Message-ID: <20191010122321.7329329f@gandalf.local.home> (raw)
In-Reply-To: <20191009152217.whklst5vwrwvsjc4@pengutronix.de>
On Wed, 9 Oct 2019 17:22:18 +0200
Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > diff --git a/scripts/recordmcount.h b/scripts/recordmcount.h
> > index 3796eb37fb12..6dbec46b7703 100644
> > --- a/scripts/recordmcount.h
> > +++ b/scripts/recordmcount.h
> > @@ -389,11 +389,8 @@ static int nop_mcount(Elf_Shdr const *const relhdr,
> > mcountsym = get_mcountsym(sym0, relp, str0);
> >
> > if (mcountsym == Elf_r_sym(relp) && !is_fake_mcount(relp)) {
> > - if (make_nop) {
> > + if (make_nop)
> > ret = make_nop((void *)ehdr, _w(shdr->sh_offset) + _w(relp->r_offset));
> > - if (ret < 0)
> > - return -1;
> > - }
>
> Yes, this patch fixes building for me.
May I add to my patch:
Reported-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Tested-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
?
-- Steve
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-10-10 16:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 18:24 [PATCH v4 0/8] recordmcount cleanups Matt Helsley
2019-07-31 18:24 ` [PATCH v4 1/8] recordmcount: Remove redundant strcmp Matt Helsley
2019-07-31 18:24 ` [PATCH v4 2/8] recordmcount: Remove uread() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 3/8] recordmcount: Remove unused fd from uwrite() and ulseek() Matt Helsley
2019-07-31 18:24 ` [PATCH v4 4/8] recordmcount: Rewrite error/success handling Matt Helsley
2019-10-09 10:46 ` Uwe Kleine-König
2019-10-09 10:46 ` Uwe Kleine-König
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:05 ` Steven Rostedt
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-09 15:22 ` Uwe Kleine-König
2019-10-10 16:23 ` Steven Rostedt [this message]
2019-10-10 16:23 ` Steven Rostedt
2019-10-10 20:14 ` Uwe Kleine-König
2019-10-10 20:14 ` Uwe Kleine-König
2019-07-31 18:24 ` [PATCH v4 5/8] recordmcount: Kernel style function signature formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 6/8] recordmcount: Kernel style formatting Matt Helsley
2019-07-31 18:24 ` [PATCH v4 7/8] recordmcount: Remove redundant cleanup() calls Matt Helsley
2019-07-31 18:24 ` [PATCH v4 8/8] recordmcount: Clarify what cleanup() does Matt Helsley
2019-08-02 17:47 ` [PATCH v4 0/8] recordmcount cleanups Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010122321.7329329f@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhelsley@vmware.com \
--cc=mingo@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.