From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Len Brown <lenb@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Viresh Kumar <viresh.kumar@linaro.org> Cc: linux-pm@vger.kernel.org, Vincent Guittot <vincent.guittot@linaro.org>, Dirk Brandewie <dirk.brandewie@gmail.com>, linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org Subject: [PATCH V2 0/3] cpufreq: Migrate away from ->stop_cpu() callback Date: Wed, 16 Jun 2021 12:10:25 +0530 [thread overview] Message-ID: <cover.1623825358.git.viresh.kumar@linaro.org> (raw) Hi Rafael, Sending these separately from CPPC stuff to avoid unnecessary confusion and independent merging of these patches. These should get in nevertheless. commit 367dc4aa932b ("cpufreq: Add stop CPU callback to cpufreq_driver interface") added the stop_cpu() callback to allow the drivers to do clean up before the CPU is completely down and its state can't be modified. At that time the CPU hotplug framework used to call the cpufreq core's registered notifier for different events like CPU_DOWN_PREPARE and CPU_POST_DEAD. The stop_cpu() callback was called during the CPU_DOWN_PREPARE event. This is no longer the case, cpuhp_cpufreq_offline() is called only once by the CPU hotplug core now and we don't really need two separate callbacks for cpufreq drivers, i.e. stop_cpu() and exit(), as everything can be done from the exit() callback itself. Migrate to using the exit() callback instead of stop_cpu(). The stop_cpu() callback isn't removed from core as it will be reused in a different way in a separate patchset. -- Viresh Viresh Kumar (3): cpufreq: cppc: Migrate to ->exit() callback instead of ->stop_cpu() cpufreq: intel_pstate: Migrate to ->exit() callback instead of ->stop_cpu() cpufreq: powerenv: Migrate to ->exit() callback instead of ->stop_cpu() drivers/cpufreq/cppc_cpufreq.c | 46 ++++++++++++++++--------------- drivers/cpufreq/intel_pstate.c | 9 +----- drivers/cpufreq/powernv-cpufreq.c | 23 ++++++---------- 3 files changed, 34 insertions(+), 44 deletions(-) -- 2.31.1.272.g89b43f80a514
WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org> To: Rafael Wysocki <rjw@rjwysocki.net>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, Len Brown <lenb@kernel.org>, Michael Ellerman <mpe@ellerman.id.au>, Paul Mackerras <paulus@samba.org>, Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>, Viresh Kumar <viresh.kumar@linaro.org> Cc: Dirk Brandewie <dirk.brandewie@gmail.com>, linuxppc-dev@lists.ozlabs.org, Vincent Guittot <vincent.guittot@linaro.org>, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org Subject: [PATCH V2 0/3] cpufreq: Migrate away from ->stop_cpu() callback Date: Wed, 16 Jun 2021 12:10:25 +0530 [thread overview] Message-ID: <cover.1623825358.git.viresh.kumar@linaro.org> (raw) Hi Rafael, Sending these separately from CPPC stuff to avoid unnecessary confusion and independent merging of these patches. These should get in nevertheless. commit 367dc4aa932b ("cpufreq: Add stop CPU callback to cpufreq_driver interface") added the stop_cpu() callback to allow the drivers to do clean up before the CPU is completely down and its state can't be modified. At that time the CPU hotplug framework used to call the cpufreq core's registered notifier for different events like CPU_DOWN_PREPARE and CPU_POST_DEAD. The stop_cpu() callback was called during the CPU_DOWN_PREPARE event. This is no longer the case, cpuhp_cpufreq_offline() is called only once by the CPU hotplug core now and we don't really need two separate callbacks for cpufreq drivers, i.e. stop_cpu() and exit(), as everything can be done from the exit() callback itself. Migrate to using the exit() callback instead of stop_cpu(). The stop_cpu() callback isn't removed from core as it will be reused in a different way in a separate patchset. -- Viresh Viresh Kumar (3): cpufreq: cppc: Migrate to ->exit() callback instead of ->stop_cpu() cpufreq: intel_pstate: Migrate to ->exit() callback instead of ->stop_cpu() cpufreq: powerenv: Migrate to ->exit() callback instead of ->stop_cpu() drivers/cpufreq/cppc_cpufreq.c | 46 ++++++++++++++++--------------- drivers/cpufreq/intel_pstate.c | 9 +----- drivers/cpufreq/powernv-cpufreq.c | 23 ++++++---------- 3 files changed, 34 insertions(+), 44 deletions(-) -- 2.31.1.272.g89b43f80a514
next reply other threads:[~2021-06-16 6:41 UTC|newest] Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-16 6:40 Viresh Kumar [this message] 2021-06-16 6:40 ` [PATCH V2 0/3] cpufreq: Migrate away from ->stop_cpu() callback Viresh Kumar 2021-06-16 6:40 ` [PATCH V2 1/3] cpufreq: cppc: Migrate to ->exit() callback instead of ->stop_cpu() Viresh Kumar 2021-06-16 6:40 ` [PATCH V2 2/3] cpufreq: intel_pstate: " Viresh Kumar 2021-06-17 13:27 ` Rafael J. Wysocki 2021-06-18 3:22 ` [PATCH V3 2/3] cpufreq: intel_pstate: Migrate away from ->stop_cpu() callback Viresh Kumar 2021-06-18 12:00 ` Rafael J. Wysocki 2021-06-21 3:09 ` Viresh Kumar 2021-06-21 14:17 ` Rafael J. Wysocki 2021-06-21 14:26 ` Rafael J. Wysocki 2021-06-21 17:14 ` Rafael J. Wysocki 2021-06-16 6:40 ` [PATCH V2 3/3] cpufreq: powerenv: Migrate to ->exit() callback instead of ->stop_cpu() Viresh Kumar 2021-06-16 6:40 ` Viresh Kumar
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=cover.1623825358.git.viresh.kumar@linaro.org \ --to=viresh.kumar@linaro.org \ --cc=benh@kernel.crashing.org \ --cc=dirk.brandewie@gmail.com \ --cc=lenb@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=linuxppc-dev@lists.ozlabs.org \ --cc=mpe@ellerman.id.au \ --cc=paulus@samba.org \ --cc=rjw@rjwysocki.net \ --cc=srinivas.pandruvada@linux.intel.com \ --cc=vincent.guittot@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.