* [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2020-10-24 0:47 ` Rasmus Villemoes
0 siblings, 0 replies; 9+ messages in thread
From: Rasmus Villemoes @ 2020-10-24 0:47 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Daniel Vetter
Cc: Linus Torvalds, Rasmus Villemoes, kernel test robot, amd-gfx,
dri-devel, linux-kernel
Keep sparse happy by preserving the __user annotation when casting.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
kernel test robot has already started spamming me due to 9c5743dff. If
I don't fix those warnings I'll keep getting those emails for
months, so let me do the easy ones.
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
value = RREG32(RADEON_MM_DATA);
spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
- r = put_user(value, (uint32_t *)buf);
+ r = put_user(value, (uint32_t __user *)buf);
if (r)
return r;
--
2.23.0
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2020-10-24 0:47 ` Rasmus Villemoes
0 siblings, 0 replies; 9+ messages in thread
From: Rasmus Villemoes @ 2020-10-24 0:47 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Daniel Vetter
Cc: kernel test robot, Rasmus Villemoes, linux-kernel, dri-devel,
amd-gfx, Linus Torvalds
Keep sparse happy by preserving the __user annotation when casting.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
kernel test robot has already started spamming me due to 9c5743dff. If
I don't fix those warnings I'll keep getting those emails for
months, so let me do the easy ones.
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
value = RREG32(RADEON_MM_DATA);
spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
- r = put_user(value, (uint32_t *)buf);
+ r = put_user(value, (uint32_t __user *)buf);
if (r)
return r;
--
2.23.0
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2020-10-24 0:47 ` Rasmus Villemoes
0 siblings, 0 replies; 9+ messages in thread
From: Rasmus Villemoes @ 2020-10-24 0:47 UTC (permalink / raw)
To: Alex Deucher, Christian König, David Airlie, Daniel Vetter
Cc: kernel test robot, Rasmus Villemoes, linux-kernel, dri-devel,
amd-gfx, Linus Torvalds
Keep sparse happy by preserving the __user annotation when casting.
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
kernel test robot has already started spamming me due to 9c5743dff. If
I don't fix those warnings I'll keep getting those emails for
months, so let me do the easy ones.
drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
--- a/drivers/gpu/drm/radeon/radeon_ttm.c
+++ b/drivers/gpu/drm/radeon/radeon_ttm.c
@@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
value = RREG32(RADEON_MM_DATA);
spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
- r = put_user(value, (uint32_t *)buf);
+ r = put_user(value, (uint32_t __user *)buf);
if (r)
return r;
--
2.23.0
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
2020-10-24 0:47 ` Rasmus Villemoes
(?)
@ 2021-04-01 13:09 ` Christian König
-1 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-04-01 13:09 UTC (permalink / raw)
To: Rasmus Villemoes, Alex Deucher; +Cc: linux-kernel, dri-devel, amd-gfx
Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> Keep sparse happy by preserving the __user annotation when casting.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going over old patches and stumbled over that once.
Alex did you missed to pick it up?
Regards,
Christian.
> ---
>
> kernel test robot has already started spamming me due to 9c5743dff. If
> I don't fix those warnings I'll keep getting those emails for
> months, so let me do the easy ones.
>
>
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> value = RREG32(RADEON_MM_DATA);
> spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
>
> - r = put_user(value, (uint32_t *)buf);
> + r = put_user(value, (uint32_t __user *)buf);
> if (r)
> return r;
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2021-04-01 13:09 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-04-01 13:09 UTC (permalink / raw)
To: Rasmus Villemoes, Alex Deucher; +Cc: amd-gfx, linux-kernel, dri-devel
Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> Keep sparse happy by preserving the __user annotation when casting.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going over old patches and stumbled over that once.
Alex did you missed to pick it up?
Regards,
Christian.
> ---
>
> kernel test robot has already started spamming me due to 9c5743dff. If
> I don't fix those warnings I'll keep getting those emails for
> months, so let me do the easy ones.
>
>
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> value = RREG32(RADEON_MM_DATA);
> spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
>
> - r = put_user(value, (uint32_t *)buf);
> + r = put_user(value, (uint32_t __user *)buf);
> if (r)
> return r;
>
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2021-04-01 13:09 ` Christian König
0 siblings, 0 replies; 9+ messages in thread
From: Christian König @ 2021-04-01 13:09 UTC (permalink / raw)
To: Rasmus Villemoes, Alex Deucher; +Cc: amd-gfx, linux-kernel, dri-devel
Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> Keep sparse happy by preserving the __user annotation when casting.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Reviewed-by: Christian König <christian.koenig@amd.com>
Going over old patches and stumbled over that once.
Alex did you missed to pick it up?
Regards,
Christian.
> ---
>
> kernel test robot has already started spamming me due to 9c5743dff. If
> I don't fix those warnings I'll keep getting those emails for
> months, so let me do the easy ones.
>
>
> drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> value = RREG32(RADEON_MM_DATA);
> spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
>
> - r = put_user(value, (uint32_t *)buf);
> + r = put_user(value, (uint32_t __user *)buf);
> if (r)
> return r;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
2021-04-01 13:09 ` Christian König
(?)
@ 2021-04-01 21:15 ` Alex Deucher
-1 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-04-01 21:15 UTC (permalink / raw)
To: Christian König
Cc: Rasmus Villemoes, Alex Deucher, amd-gfx list, LKML,
Maling list - DRI developers
Current code already contains the fix.
Alex
On Thu, Apr 1, 2021 at 9:09 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Going over old patches and stumbled over that once.
>
> Alex did you missed to pick it up?
>
> Regards,
> Christian.
>
> > ---
> >
> > kernel test robot has already started spamming me due to 9c5743dff. If
> > I don't fix those warnings I'll keep getting those emails for
> > months, so let me do the easy ones.
> >
> >
> > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> > value = RREG32(RADEON_MM_DATA);
> > spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
> >
> > - r = put_user(value, (uint32_t *)buf);
> > + r = put_user(value, (uint32_t __user *)buf);
> > if (r)
> > return r;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2021-04-01 21:15 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-04-01 21:15 UTC (permalink / raw)
To: Christian König
Cc: Alex Deucher, Maling list - DRI developers, Rasmus Villemoes,
LKML, amd-gfx list
Current code already contains the fix.
Alex
On Thu, Apr 1, 2021 at 9:09 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Going over old patches and stumbled over that once.
>
> Alex did you missed to pick it up?
>
> Regards,
> Christian.
>
> > ---
> >
> > kernel test robot has already started spamming me due to 9c5743dff. If
> > I don't fix those warnings I'll keep getting those emails for
> > months, so let me do the easy ones.
> >
> >
> > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> > value = RREG32(RADEON_MM_DATA);
> > spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
> >
> > - r = put_user(value, (uint32_t *)buf);
> > + r = put_user(value, (uint32_t __user *)buf);
> > if (r)
> > return r;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read
@ 2021-04-01 21:15 ` Alex Deucher
0 siblings, 0 replies; 9+ messages in thread
From: Alex Deucher @ 2021-04-01 21:15 UTC (permalink / raw)
To: Christian König
Cc: Alex Deucher, Maling list - DRI developers, Rasmus Villemoes,
LKML, amd-gfx list
Current code already contains the fix.
Alex
On Thu, Apr 1, 2021 at 9:09 AM Christian König
<ckoenig.leichtzumerken@gmail.com> wrote:
>
> Am 24.10.20 um 02:47 schrieb Rasmus Villemoes:
> > Keep sparse happy by preserving the __user annotation when casting.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
>
> Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Going over old patches and stumbled over that once.
>
> Alex did you missed to pick it up?
>
> Regards,
> Christian.
>
> > ---
> >
> > kernel test robot has already started spamming me due to 9c5743dff. If
> > I don't fix those warnings I'll keep getting those emails for
> > months, so let me do the easy ones.
> >
> >
> > drivers/gpu/drm/radeon/radeon_ttm.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_ttm.c b/drivers/gpu/drm/radeon/radeon_ttm.c
> > index 36150b7f31a90aa1eece..ecfe88b0a35d8f317712 100644
> > --- a/drivers/gpu/drm/radeon/radeon_ttm.c
> > +++ b/drivers/gpu/drm/radeon/radeon_ttm.c
> > @@ -1005,7 +1005,7 @@ static ssize_t radeon_ttm_vram_read(struct file *f, char __user *buf,
> > value = RREG32(RADEON_MM_DATA);
> > spin_unlock_irqrestore(&rdev->mmio_idx_lock, flags);
> >
> > - r = put_user(value, (uint32_t *)buf);
> > + r = put_user(value, (uint32_t __user *)buf);
> > if (r)
> > return r;
> >
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2021-04-01 21:15 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-24 0:47 [PATCH] drm/ttm: add __user annotation in radeon_ttm_vram_read Rasmus Villemoes
2020-10-24 0:47 ` Rasmus Villemoes
2020-10-24 0:47 ` Rasmus Villemoes
2021-04-01 13:09 ` Christian König
2021-04-01 13:09 ` Christian König
2021-04-01 13:09 ` Christian König
2021-04-01 21:15 ` Alex Deucher
2021-04-01 21:15 ` Alex Deucher
2021-04-01 21:15 ` Alex Deucher
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.