From: "Philippe Mathieu-Daudé via" <qemu-devel@nongnu.org>
To: Philipp Tomsich <philipp.tomsich@vrull.eu>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, Bin Meng <bin.meng@windriver.com>,
Greg Favor <gfavor@ventanamicro.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH v2 2/2] target/riscv: Add XVentanaCondOps custom extension
Date: Wed, 19 Jan 2022 12:17:49 +0100 [thread overview]
Message-ID: <d237abed-fe8c-fb29-3ec0-27a0504eeffc@amsat.org> (raw)
In-Reply-To: <20220113202033.3320854-2-philipp.tomsich@vrull.eu>
On 13/1/22 21:20, Philipp Tomsich wrote:
> This adds the decoder and translation for the XVentanaCondOps custom
> extension (vendor-defined by Ventana Micro Systems), which is
> documented at https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.0/ventana-custom-extensions-v1.0.0.pdf
>
> This commit then also adds a guard-function (has_XVentanaCondOps_p)
> and the decoder function to the table of decoders, enabling the
> support for the XVentanaCondOps extension.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
>
> ---
>
> Changes in v2:
> - Split off decode table into XVentanaCondOps.decode
> - Wire up XVentanaCondOps in the decoder-table
> static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode)
> {
> @@ -862,6 +874,7 @@ static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode)
> bool (*decode_func)(DisasContext *, uint32_t);
> } decoders[] = {
> { always_true_p, decode_insn32 },
"always_true" is the first entry,
> + { has_XVentanaCondOps_p, decode_XVentanaCodeOps },
so is that ever called?
> };
>
> /* Check for compressed insn */
WARNING: multiple messages have this Message-ID (diff)
From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Philipp Tomsich <philipp.tomsich@vrull.eu>, qemu-devel@nongnu.org
Cc: qemu-riscv@nongnu.org, Bin Meng <bin.meng@windriver.com>,
Greg Favor <gfavor@ventanamicro.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Alistair Francis <alistair.francis@wdc.com>,
Kito Cheng <kito.cheng@sifive.com>
Subject: Re: [PATCH v2 2/2] target/riscv: Add XVentanaCondOps custom extension
Date: Wed, 19 Jan 2022 12:17:49 +0100 [thread overview]
Message-ID: <d237abed-fe8c-fb29-3ec0-27a0504eeffc@amsat.org> (raw)
In-Reply-To: <20220113202033.3320854-2-philipp.tomsich@vrull.eu>
On 13/1/22 21:20, Philipp Tomsich wrote:
> This adds the decoder and translation for the XVentanaCondOps custom
> extension (vendor-defined by Ventana Micro Systems), which is
> documented at https://github.com/ventanamicro/ventana-custom-extensions/releases/download/v1.0.0/ventana-custom-extensions-v1.0.0.pdf
>
> This commit then also adds a guard-function (has_XVentanaCondOps_p)
> and the decoder function to the table of decoders, enabling the
> support for the XVentanaCondOps extension.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@vrull.eu>
>
> ---
>
> Changes in v2:
> - Split off decode table into XVentanaCondOps.decode
> - Wire up XVentanaCondOps in the decoder-table
> static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode)
> {
> @@ -862,6 +874,7 @@ static void decode_opc(CPURISCVState *env, DisasContext *ctx, uint16_t opcode)
> bool (*decode_func)(DisasContext *, uint32_t);
> } decoders[] = {
> { always_true_p, decode_insn32 },
"always_true" is the first entry,
> + { has_XVentanaCondOps_p, decode_XVentanaCodeOps },
so is that ever called?
> };
>
> /* Check for compressed insn */
next prev parent reply other threads:[~2022-01-19 11:29 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 20:20 [PATCH v2 1/2] target/riscv: iterate over a table of decoders Philipp Tomsich
2022-01-13 20:20 ` Philipp Tomsich
2022-01-13 20:20 ` [PATCH v2 2/2] target/riscv: Add XVentanaCondOps custom extension Philipp Tomsich
2022-01-13 20:20 ` Philipp Tomsich
2022-01-18 22:53 ` Alistair Francis
2022-01-18 22:53 ` Alistair Francis
2022-01-18 23:21 ` Philipp Tomsich
2022-01-18 23:21 ` Philipp Tomsich
2022-01-19 1:19 ` Alistair Francis
2022-01-19 1:19 ` Alistair Francis
2022-01-19 1:30 ` Alistair Francis
2022-01-19 1:30 ` Alistair Francis
2022-01-20 15:37 ` Philipp Tomsich
2022-01-20 15:37 ` Philipp Tomsich
2022-01-21 3:02 ` Alistair Francis
2022-01-21 3:02 ` Alistair Francis
2022-01-19 11:17 ` Philippe Mathieu-Daudé via [this message]
2022-01-19 11:17 ` Philippe Mathieu-Daudé
2022-01-20 15:24 ` Philipp Tomsich
2022-01-20 15:24 ` Philipp Tomsich
2022-01-25 21:42 ` Richard Henderson
2022-01-19 11:30 ` [PATCH v2 1/2] target/riscv: iterate over a table of decoders Philippe Mathieu-Daudé via
2022-01-19 11:30 ` Philippe Mathieu-Daudé
2022-01-20 20:05 ` Philipp Tomsich
2022-01-20 20:05 ` Philipp Tomsich
2022-01-25 21:28 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d237abed-fe8c-fb29-3ec0-27a0504eeffc@amsat.org \
--to=qemu-devel@nongnu.org \
--cc=alistair.francis@wdc.com \
--cc=bin.meng@windriver.com \
--cc=f4bug@amsat.org \
--cc=gfavor@ventanamicro.com \
--cc=kito.cheng@sifive.com \
--cc=palmer@dabbelt.com \
--cc=philipp.tomsich@vrull.eu \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.