Re: [RFC PATCH 13/16] RISC-V: KVM: Add timer functionality

[Atish Patra <Atish.Patra@wdc.com>]

On Mon, 2019-07-29 at 16:40 +0200, Andreas Schwab wrote:
> On Jul 29 2019, Anup Patel <Anup.Patel@wdc.com> wrote:
> 
> > From: Atish Patra <atish.patra@wdc.com>
> > 
> > The RISC-V hypervisor specification doesn't have any virtual timer
> > feature.
> > 
> > Due to this, the guest VCPU timer will be programmed via SBI calls.
> > The host will use a separate hrtimer event for each guest VCPU to
> > provide timer functionality. We inject a virtual timer interrupt to
> > the guest VCPU whenever the guest VCPU hrtimer event expires.
> > 
> > The following features are not supported yet and will be added in
> > future:
> > 1. A time offset to adjust guest time from host time
> > 2. A saved next event in guest vcpu for vm migration
> 
> I'm getting this error:
> 
> In file included from <command-line>:
> ./include/clocksource/timer-riscv.h:12:30: error: unknown type name
> ‘u32’
>    12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
>       |                              ^~~
> ./include/clocksource/timer-riscv.h:12:41: error: unknown type name
> ‘u32’
>    12 | void riscv_cs_get_mult_shift(u32 *mult, u32 *shift);
>       |                                         ^~~
> make[1]: *** [scripts/Makefile.build:301: include/clocksource/timer-
> riscv.h.s] Error 1
> 
> Andreas.
> 

Strange. We never saw this error. But I think we should add this one to
the header file (include/clocksource/timer-riscv.h) 

#include <linux/types.h>

Can you try it at your end and confirm please ?

Regards,
Atish