Re: FreeBSD Fwd: Build failed in Jenkins: ceph-master #491

Re: FreeBSD Fwd: Build failed in Jenkins: ceph-master #491

[Willem Jan Withagen]

On 3-4-2017 17:00, Andrew N Solomon wrote:
> Willem-
> 
> I think I see the problem and have a fix in mind for this. I will put it
> up asap.
> Sorry for the trouble. Since you seemingly have available access to FreeBSD
> more easily than I do perhaps you could help with testing my fix once it
> is up?
> 
> We should be able to just move the #include <sys/auxv.h> line (ie line
> 16 of src/arch/ppc.c)
> under the #if __linux__ && __powerpc64__ (on line 18).
> 
> The call to getauxval is already under that same #if __linux__ &&
> __powerpc64__ directive. The
> reason auxv.h is included is to provide the declaration for the
> getauxval function, which is seemingly
> present in linux but not FreeBSD.
> 
> Thanks,
> Andy Solomon
> 
> 
> Inactive hide details for Willem Jan Withagen ---04/01/2017 04:11:24
> PM---From: Willem Jan Withagen <wjw@digiware.nl> To: AndreWillem Jan
> Withagen ---04/01/2017 04:11:24 PM---From: Willem Jan Withagen
> <wjw@digiware.nl> To: Andrew N Solomon/Austin/IBM@IBMUS, Ceph
> Development <ceph-devel@vger.kernel.org
> 
> From: Willem Jan Withagen <wjw@digiware.nl>
> To: Andrew N Solomon/Austin/IBM@IBMUS, Ceph Development
> <ceph-devel@vger.kernel.org>
> Date: 04/01/2017 04:11 PM
> Subject: FreeBSD Fwd: Build failed in Jenkins: ceph-master #491
> 
> ------------------------------------------------------------------------
> 
> 
> 
> Currently my FreeBSD build fails due to inclusion of a file
> that does not exist on FreeBSD.
> Next to the fact that I'm not really certain that everything will build
> and run on PPC with FreeBSD. :)
> 
> Perhaps we can conditionalise PPC code just as we did with ARM code?
> Or perhaps even exclude pp.cc in CMakeLists.txt without upsetting the
> balance of order.

Hi Andrew,

Currently there is PR (#14289) of Kefu in the works that tries to fix
this in a rather structural way.
You might want to take a look at it.

--WjW