From: Jason Wang <jasowang@redhat.com> To: Jason Gunthorpe <jgg@mellanox.com> Cc: "mst@redhat.com" <mst@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "tiwei.bie@intel.com" <tiwei.bie@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "cunming.liang@intel.com" <cunming.liang@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "rob.miller@broadcom.com" <rob.miller@broadcom.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "haotian.wang@sifive.com" <haotian.wang@sifive.com>, "lingshan.zhu@intel.com" <lingshan.zhu@intel.com>, "eperezma@redhat.com" <eperezma@redhat.com>, "lulu@redhat.com" <lulu@redhat.com>, Parav Pandit <parav@mellanox.com>, "kevin.tian@intel.com" <kevin.tian@intel.com>, "stefanha@redhat.com" <stefanha@redhat.com>, "rdunlap@infradead.org" <rdunlap@infradead.org>, "hch@infradead.org" <hch@infradead.org>, "aadam@redhat.com" <aadam@redhat.com>, Jiri Pirko <jiri@mellanox.com>, Shahaf Shuler <shahafs@mellanox.com>, "hanand@xilinx.com" <hanand@xilinx.com>, "mhabets@solarflare.com" <mhabets@solarflare.com> Subject: Re: [PATCH V4 4/5] virtio: introduce a vDPA based transport Date: Fri, 21 Feb 2020 16:06:24 +0800 [thread overview] Message-ID: <d6d910bb-8431-7e95-8808-9ed2d6ec9211@redhat.com> (raw) In-Reply-To: <20200220151914.GW23930@mellanox.com> On 2020/2/20 下午11:19, Jason Gunthorpe wrote: > On Thu, Feb 20, 2020 at 02:11:40PM +0800, Jason Wang wrote: >> +static int virtio_vdpa_probe(struct vdpa_device *vdpa) >> +{ >> + const struct vdpa_config_ops *ops = vdpa->config; >> + struct virtio_vdpa_device *vd_dev; >> + int ret = -EINVAL; >> + >> + vd_dev = kzalloc(sizeof(*vd_dev), GFP_KERNEL); >> + if (!vd_dev) >> + return -ENOMEM; >> + >> + vd_dev->vdev.dev.parent = vdpa_get_dma_dev(vdpa); >> + vd_dev->vdev.dev.release = virtio_vdpa_release_dev; >> + vd_dev->vdev.config = &virtio_vdpa_config_ops; >> + vd_dev->vdpa = vdpa; >> + INIT_LIST_HEAD(&vd_dev->virtqueues); >> + spin_lock_init(&vd_dev->lock); >> + >> + vd_dev->vdev.id.device = ops->get_device_id(vdpa); >> + if (vd_dev->vdev.id.device == 0) >> + goto err; >> + >> + vd_dev->vdev.id.vendor = ops->get_vendor_id(vdpa); >> + ret = register_virtio_device(&vd_dev->vdev); >> + if (ret) >> + goto err; > This error unwind is wrong. register_virtio_device() does > device_initialize() as it's first action. After that point error > unwind must be done with put_device() - particularly calling > kfree(vd_dev) after doing dev_set_name() leaks memory. Exactly. > > Looks like about half of the register_virtio_device() users did this > right, the others not. Perhaps you should fix them too... > > Jason Will do. Thanks >
WARNING: multiple messages have this Message-ID (diff)
From: Jason Wang <jasowang@redhat.com> To: Jason Gunthorpe <jgg@mellanox.com> Cc: "mst@redhat.com" <mst@redhat.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "kvm@vger.kernel.org" <kvm@vger.kernel.org>, "virtualization@lists.linux-foundation.org" <virtualization@lists.linux-foundation.org>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "tiwei.bie@intel.com" <tiwei.bie@intel.com>, "maxime.coquelin@redhat.com" <maxime.coquelin@redhat.com>, "cunming.liang@intel.com" <cunming.liang@intel.com>, "zhihong.wang@intel.com" <zhihong.wang@intel.com>, "rob.miller@broadcom.com" <rob.miller@broadcom.com>, "xiao.w.wang@intel.com" <xiao.w.wang@intel.com>, "haotian.wang@sifive.com" <haotian.wang@sifive.com>, "lingshan.zhu@intel.com" <lingshan.zhu@intel.com>, "eperezma@redhat.com" <eperezma@redhat.com>, "lulu@redhat.com" <lulu@redhat.co> Subject: Re: [PATCH V4 4/5] virtio: introduce a vDPA based transport Date: Fri, 21 Feb 2020 16:06:24 +0800 [thread overview] Message-ID: <d6d910bb-8431-7e95-8808-9ed2d6ec9211@redhat.com> (raw) In-Reply-To: <20200220151914.GW23930@mellanox.com> On 2020/2/20 下午11:19, Jason Gunthorpe wrote: > On Thu, Feb 20, 2020 at 02:11:40PM +0800, Jason Wang wrote: >> +static int virtio_vdpa_probe(struct vdpa_device *vdpa) >> +{ >> + const struct vdpa_config_ops *ops = vdpa->config; >> + struct virtio_vdpa_device *vd_dev; >> + int ret = -EINVAL; >> + >> + vd_dev = kzalloc(sizeof(*vd_dev), GFP_KERNEL); >> + if (!vd_dev) >> + return -ENOMEM; >> + >> + vd_dev->vdev.dev.parent = vdpa_get_dma_dev(vdpa); >> + vd_dev->vdev.dev.release = virtio_vdpa_release_dev; >> + vd_dev->vdev.config = &virtio_vdpa_config_ops; >> + vd_dev->vdpa = vdpa; >> + INIT_LIST_HEAD(&vd_dev->virtqueues); >> + spin_lock_init(&vd_dev->lock); >> + >> + vd_dev->vdev.id.device = ops->get_device_id(vdpa); >> + if (vd_dev->vdev.id.device == 0) >> + goto err; >> + >> + vd_dev->vdev.id.vendor = ops->get_vendor_id(vdpa); >> + ret = register_virtio_device(&vd_dev->vdev); >> + if (ret) >> + goto err; > This error unwind is wrong. register_virtio_device() does > device_initialize() as it's first action. After that point error > unwind must be done with put_device() - particularly calling > kfree(vd_dev) after doing dev_set_name() leaks memory. Exactly. > > Looks like about half of the register_virtio_device() users did this > right, the others not. Perhaps you should fix them too... > > Jason Will do. Thanks >
next prev parent reply other threads:[~2020-02-21 8:36 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-02-20 6:11 [PATCH V4 0/5] vDPA support Jason Wang 2020-02-20 6:11 ` [PATCH V4 1/5] vhost: factor out IOTLB Jason Wang 2020-02-20 6:11 ` [PATCH V4 2/5] vringh: IOTLB support Jason Wang 2020-02-20 6:11 ` [PATCH V4 3/5] vDPA: introduce vDPA bus Jason Wang 2020-02-20 15:14 ` Jason Gunthorpe 2020-02-20 15:14 ` Jason Gunthorpe 2020-02-21 7:54 ` Jason Wang 2020-02-21 7:54 ` Jason Wang 2020-02-24 6:14 ` Harpreet Singh Anand 2020-02-24 6:14 ` Harpreet Singh Anand 2020-02-24 6:48 ` Jason Wang 2020-02-24 6:48 ` Jason Wang 2020-02-20 6:11 ` [PATCH V4 4/5] virtio: introduce a vDPA based transport Jason Wang 2020-02-20 15:19 ` Jason Gunthorpe 2020-02-20 15:19 ` Jason Gunthorpe 2020-02-21 8:06 ` Jason Wang [this message] 2020-02-21 8:06 ` Jason Wang 2020-02-20 6:11 ` [PATCH V4 5/5] vdpasim: vDPA device simulator Jason Wang 2020-02-20 15:12 ` Jason Gunthorpe 2020-02-20 15:12 ` Jason Gunthorpe 2020-02-21 7:57 ` Jason Wang 2020-02-21 7:57 ` Jason Wang 2020-02-26 6:12 ` Jason Wang 2020-02-26 6:12 ` Jason Wang 2020-02-26 17:19 ` Jason Gunthorpe 2020-02-26 17:19 ` Jason Gunthorpe 2020-02-21 8:33 ` Harpreet Singh Anand 2020-02-21 8:33 ` Harpreet Singh Anand 2020-02-21 8:50 ` Jason Wang 2020-02-21 8:50 ` Jason Wang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=d6d910bb-8431-7e95-8808-9ed2d6ec9211@redhat.com \ --to=jasowang@redhat.com \ --cc=aadam@redhat.com \ --cc=cunming.liang@intel.com \ --cc=eperezma@redhat.com \ --cc=hanand@xilinx.com \ --cc=haotian.wang@sifive.com \ --cc=hch@infradead.org \ --cc=jgg@mellanox.com \ --cc=jiri@mellanox.com \ --cc=kevin.tian@intel.com \ --cc=kvm@vger.kernel.org \ --cc=lingshan.zhu@intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=lulu@redhat.com \ --cc=maxime.coquelin@redhat.com \ --cc=mhabets@solarflare.com \ --cc=mst@redhat.com \ --cc=netdev@vger.kernel.org \ --cc=parav@mellanox.com \ --cc=rdunlap@infradead.org \ --cc=rob.miller@broadcom.com \ --cc=shahafs@mellanox.com \ --cc=stefanha@redhat.com \ --cc=tiwei.bie@intel.com \ --cc=virtualization@lists.linux-foundation.org \ --cc=xiao.w.wang@intel.com \ --cc=zhihong.wang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.