From: Bhupesh Sharma <bhsharma@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
frowand.list@gmail.com
Cc: kexec@lists.infradead.org, james.morse@arm.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] arm64: kexec_file: add kdump
Date: Thu, 5 Dec 2019 01:56:47 +0530 [thread overview]
Message-ID: <da0113d3-24b8-6263-b06e-0e58037f292f@redhat.com> (raw)
In-Reply-To: <20191114051510.17037-1-takahiro.akashi@linaro.org>
Hi Akashi,
Thanks for the patchset.
On 11/14/2019 10:45 AM, AKASHI Takahiro wrote:
> This is the last piece of my kexec_file_load implementation for arm64.
> It is now ready for being merged as some relevant patch to dtc/libfdt[1]
> has finally been integrated in v5.3-rc1.
> (Nothing changed since kexec_file v16[2] except adding Patch#1 and #2.)
>
> Patch#1 and #2 are preliminary patches for libfdt component.
> Patch#3 is to add kdump support.
>
> Bhepesh's patch[3] will be required for 52-bit VA support.
> Once this patch is applied, whether or not CONFIG_ARM64_VA_BITS_52 is
> enabled or not, a matching fix on user space side, crash utility,
> will also be needed.
>
> Anyway, I tested my patch, at least, with the following configuration:
> 1) CONFIG_ARM64_BITS_48=y
> 2) CONFIG_ARM64_BITS_52=y, but vabits_actual=48
>
> (I don't have any platform to use for
> 3) CONFIG_ARM64_BITS_52=y, and vabits_actual=52)
>
> [1] commit 9bb9c6a110ea ("scripts/dtc: Update to upstream version
> v1.5.0-23-g87963ee20693"), in particular
> 7fcf8208b8a9 libfdt: add fdt_append_addrrange()
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/612641.html
> [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-November/693411.html
>
> Changes in v2 (Nov 14, 2019)
> * rebased to v5.4-rc7
> * no functional changes
This looks like a step in the right direction. I have some minor
nitpicks which I have mentioned in the individual patch reviews.
With those addressed (v2?):
Tested-and-Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks,
Bhupesh
> AKASHI Takahiro (3):
> libfdt: define UINT32_MAX in libfdt_env.h
> libfdt: include fdt_addresses.c
> arm64: kexec_file: add crash dump support
>
> arch/arm64/include/asm/kexec.h | 4 +
> arch/arm64/kernel/kexec_image.c | 4 -
> arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++-
> include/linux/libfdt_env.h | 3 +
> lib/Makefile | 2 +-
> lib/fdt_addresses.c | 2 +
> 6 files changed, 112 insertions(+), 9 deletions(-)
> create mode 100644 lib/fdt_addresses.c
>
WARNING: multiple messages have this Message-ID (diff)
From: Bhupesh Sharma <bhsharma@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
frowand.list@gmail.com
Cc: james.morse@arm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] arm64: kexec_file: add kdump
Date: Thu, 5 Dec 2019 01:56:47 +0530 [thread overview]
Message-ID: <da0113d3-24b8-6263-b06e-0e58037f292f@redhat.com> (raw)
In-Reply-To: <20191114051510.17037-1-takahiro.akashi@linaro.org>
Hi Akashi,
Thanks for the patchset.
On 11/14/2019 10:45 AM, AKASHI Takahiro wrote:
> This is the last piece of my kexec_file_load implementation for arm64.
> It is now ready for being merged as some relevant patch to dtc/libfdt[1]
> has finally been integrated in v5.3-rc1.
> (Nothing changed since kexec_file v16[2] except adding Patch#1 and #2.)
>
> Patch#1 and #2 are preliminary patches for libfdt component.
> Patch#3 is to add kdump support.
>
> Bhepesh's patch[3] will be required for 52-bit VA support.
> Once this patch is applied, whether or not CONFIG_ARM64_VA_BITS_52 is
> enabled or not, a matching fix on user space side, crash utility,
> will also be needed.
>
> Anyway, I tested my patch, at least, with the following configuration:
> 1) CONFIG_ARM64_BITS_48=y
> 2) CONFIG_ARM64_BITS_52=y, but vabits_actual=48
>
> (I don't have any platform to use for
> 3) CONFIG_ARM64_BITS_52=y, and vabits_actual=52)
>
> [1] commit 9bb9c6a110ea ("scripts/dtc: Update to upstream version
> v1.5.0-23-g87963ee20693"), in particular
> 7fcf8208b8a9 libfdt: add fdt_append_addrrange()
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/612641.html
> [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-November/693411.html
>
> Changes in v2 (Nov 14, 2019)
> * rebased to v5.4-rc7
> * no functional changes
This looks like a step in the right direction. I have some minor
nitpicks which I have mentioned in the individual patch reviews.
With those addressed (v2?):
Tested-and-Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks,
Bhupesh
> AKASHI Takahiro (3):
> libfdt: define UINT32_MAX in libfdt_env.h
> libfdt: include fdt_addresses.c
> arm64: kexec_file: add crash dump support
>
> arch/arm64/include/asm/kexec.h | 4 +
> arch/arm64/kernel/kexec_image.c | 4 -
> arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++-
> include/linux/libfdt_env.h | 3 +
> lib/Makefile | 2 +-
> lib/fdt_addresses.c | 2 +
> 6 files changed, 112 insertions(+), 9 deletions(-)
> create mode 100644 lib/fdt_addresses.c
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Bhupesh Sharma <bhsharma@redhat.com>
To: AKASHI Takahiro <takahiro.akashi@linaro.org>,
catalin.marinas@arm.com, will.deacon@arm.com, robh+dt@kernel.org,
frowand.list@gmail.com
Cc: james.morse@arm.com, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 0/3] arm64: kexec_file: add kdump
Date: Thu, 5 Dec 2019 01:56:47 +0530 [thread overview]
Message-ID: <da0113d3-24b8-6263-b06e-0e58037f292f@redhat.com> (raw)
In-Reply-To: <20191114051510.17037-1-takahiro.akashi@linaro.org>
Hi Akashi,
Thanks for the patchset.
On 11/14/2019 10:45 AM, AKASHI Takahiro wrote:
> This is the last piece of my kexec_file_load implementation for arm64.
> It is now ready for being merged as some relevant patch to dtc/libfdt[1]
> has finally been integrated in v5.3-rc1.
> (Nothing changed since kexec_file v16[2] except adding Patch#1 and #2.)
>
> Patch#1 and #2 are preliminary patches for libfdt component.
> Patch#3 is to add kdump support.
>
> Bhepesh's patch[3] will be required for 52-bit VA support.
> Once this patch is applied, whether or not CONFIG_ARM64_VA_BITS_52 is
> enabled or not, a matching fix on user space side, crash utility,
> will also be needed.
>
> Anyway, I tested my patch, at least, with the following configuration:
> 1) CONFIG_ARM64_BITS_48=y
> 2) CONFIG_ARM64_BITS_52=y, but vabits_actual=48
>
> (I don't have any platform to use for
> 3) CONFIG_ARM64_BITS_52=y, and vabits_actual=52)
>
> [1] commit 9bb9c6a110ea ("scripts/dtc: Update to upstream version
> v1.5.0-23-g87963ee20693"), in particular
> 7fcf8208b8a9 libfdt: add fdt_append_addrrange()
> [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2018-November/612641.html
> [3] http://lists.infradead.org/pipermail/linux-arm-kernel/2019-November/693411.html
>
> Changes in v2 (Nov 14, 2019)
> * rebased to v5.4-rc7
> * no functional changes
This looks like a step in the right direction. I have some minor
nitpicks which I have mentioned in the individual patch reviews.
With those addressed (v2?):
Tested-and-Reviewed-by: Bhupesh Sharma <bhsharma@redhat.com>
Thanks,
Bhupesh
> AKASHI Takahiro (3):
> libfdt: define UINT32_MAX in libfdt_env.h
> libfdt: include fdt_addresses.c
> arm64: kexec_file: add crash dump support
>
> arch/arm64/include/asm/kexec.h | 4 +
> arch/arm64/kernel/kexec_image.c | 4 -
> arch/arm64/kernel/machine_kexec_file.c | 106 ++++++++++++++++++++++++-
> include/linux/libfdt_env.h | 3 +
> lib/Makefile | 2 +-
> lib/fdt_addresses.c | 2 +
> 6 files changed, 112 insertions(+), 9 deletions(-)
> create mode 100644 lib/fdt_addresses.c
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-12-04 20:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-14 5:15 [PATCH v2 0/3] arm64: kexec_file: add kdump AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` [PATCH v2 1/3] libfdt: define UINT32_MAX in libfdt_env.h AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-12-04 20:33 ` Bhupesh Sharma
2019-12-04 20:33 ` Bhupesh Sharma
2019-12-04 20:33 ` Bhupesh Sharma
2019-11-14 5:15 ` [PATCH v2 2/3] libfdt: include fdt_addresses.c AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` [PATCH v2 3/3] arm64: kexec_file: add crash dump support AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-11-14 5:15 ` AKASHI Takahiro
2019-12-04 20:44 ` Bhupesh Sharma
2019-12-04 20:44 ` Bhupesh Sharma
2019-12-04 20:44 ` Bhupesh Sharma
2019-12-16 1:43 ` AKASHI Takahiro
2019-12-16 1:43 ` AKASHI Takahiro
2019-12-16 1:43 ` AKASHI Takahiro
2019-12-04 20:26 ` Bhupesh Sharma [this message]
2019-12-04 20:26 ` [PATCH v2 0/3] arm64: kexec_file: add kdump Bhupesh Sharma
2019-12-04 20:26 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=da0113d3-24b8-6263-b06e-0e58037f292f@redhat.com \
--to=bhsharma@redhat.com \
--cc=catalin.marinas@arm.com \
--cc=frowand.list@gmail.com \
--cc=james.morse@arm.com \
--cc=kexec@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=takahiro.akashi@linaro.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.