* patman regression?
@ 2020-12-11 4:08 Bin Meng
2020-12-11 4:27 ` Bin Meng
0 siblings, 1 reply; 10+ messages in thread
From: Bin Meng @ 2020-12-11 4:08 UTC (permalink / raw)
To: u-boot
Hi Simon,
The following command no longer works. They used to work.
$ ./tools/patman/patman -n -c1
usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT]
[-P PATCHWORK_URL] [-s START] [-v] [-H]
{send,test,status} ...
patman: error: unrecognized arguments: -n
$ ./tools/patman/patman -n -c 1
usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT]
[-P PATCHWORK_URL] [-s START] [-v] [-H]
{send,test,status} ...
patman: error: argument -c/--count: invalid int value: 'send'
I did not run a bisect to locate which commit introduced this. Do you
have any idea?
Regards,
Bin
^ permalink raw reply [flat|nested] 10+ messages in thread* patman regression? 2020-12-11 4:08 patman regression? Bin Meng @ 2020-12-11 4:27 ` Bin Meng 2020-12-11 4:32 ` Sean Anderson 0 siblings, 1 reply; 10+ messages in thread From: Bin Meng @ 2020-12-11 4:27 UTC (permalink / raw) To: u-boot On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > The following command no longer works. They used to work. > > $ ./tools/patman/patman -n -c1 > usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > [-P PATCHWORK_URL] [-s START] [-v] [-H] > {send,test,status} ... > patman: error: unrecognized arguments: -n > $ ./tools/patman/patman -n -c 1 > usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > [-P PATCHWORK_URL] [-s START] [-v] [-H] > {send,test,status} ... > patman: error: argument -c/--count: invalid int value: 'send' > > I did not run a bisect to locate which commit introduced this. Do you > have any idea? Resetting to v2020.10, patman works again with the above 2 commands. Note the latest patman also throws an exception about commit tags while the v2020.10 version did not. Traceback (most recent call last): File "./tools/patman/patman", line 177, in <module> control.send(args) File "./tools/patman/control.py", line 177, in send args.smtp_server) File "./tools/patman/control.py", line 136, in email_patches add_maintainers, limit) File "./tools//patman/series.py", line 264, in MakeCcFile raise_on_error=raise_on_error) File "./tools//patman/gitutil.py", line 383, in BuildEmailList raw += LookupEmail(item, alias, raise_on_error=raise_on_error) File "./tools//patman/gitutil.py", line 588, in LookupEmail raise ValueError(msg) ValueError: Alias 'doc' not found Regards, Bin ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-11 4:27 ` Bin Meng @ 2020-12-11 4:32 ` Sean Anderson 2020-12-11 4:37 ` Bin Meng 0 siblings, 1 reply; 10+ messages in thread From: Sean Anderson @ 2020-12-11 4:32 UTC (permalink / raw) To: u-boot On 12/10/20 11:27 PM, Bin Meng wrote: > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: >> >> Hi Simon, >> >> The following command no longer works. They used to work. >> >> $ ./tools/patman/patman -n -c1 >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >> [-P PATCHWORK_URL] [-s START] [-v] [-H] >> {send,test,status} ... >> patman: error: unrecognized arguments: -n >> $ ./tools/patman/patman -n -c 1 >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >> [-P PATCHWORK_URL] [-s START] [-v] [-H] >> {send,test,status} ... >> patman: error: argument -c/--count: invalid int value: 'send' >> >> I did not run a bisect to locate which commit introduced this. Do you >> have any idea? > > Resetting to v2020.10, patman works again with the above 2 commands. > > Note the latest patman also throws an exception about commit tags > while the v2020.10 version did not. > > Traceback (most recent call last): > File "./tools/patman/patman", line 177, in <module> > control.send(args) > File "./tools/patman/control.py", line 177, in send > args.smtp_server) > File "./tools/patman/control.py", line 136, in email_patches > add_maintainers, limit) > File "./tools//patman/series.py", line 264, in MakeCcFile > raise_on_error=raise_on_error) > File "./tools//patman/gitutil.py", line 383, in BuildEmailList > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > File "./tools//patman/gitutil.py", line 588, in LookupEmail > raise ValueError(msg) > ValueError: Alias 'doc' not found I also get this error even with process_tags=False. --Sean > > Regards, > Bin > ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-11 4:32 ` Sean Anderson @ 2020-12-11 4:37 ` Bin Meng 2020-12-11 16:29 ` Simon Glass 0 siblings, 1 reply; 10+ messages in thread From: Bin Meng @ 2020-12-11 4:37 UTC (permalink / raw) To: u-boot On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: > > On 12/10/20 11:27 PM, Bin Meng wrote: > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > >> > >> Hi Simon, > >> > >> The following command no longer works. They used to work. > >> > >> $ ./tools/patman/patman -n -c1 > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > >> {send,test,status} ... > >> patman: error: unrecognized arguments: -n > >> $ ./tools/patman/patman -n -c 1 > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > >> {send,test,status} ... > >> patman: error: argument -c/--count: invalid int value: 'send' > >> > >> I did not run a bisect to locate which commit introduced this. Do you > >> have any idea? > > > > Resetting to v2020.10, patman works again with the above 2 commands. > > > > Note the latest patman also throws an exception about commit tags > > while the v2020.10 version did not. > > > > Traceback (most recent call last): > > File "./tools/patman/patman", line 177, in <module> > > control.send(args) > > File "./tools/patman/control.py", line 177, in send > > args.smtp_server) > > File "./tools/patman/control.py", line 136, in email_patches > > add_maintainers, limit) > > File "./tools//patman/series.py", line 264, in MakeCcFile > > raise_on_error=raise_on_error) > > File "./tools//patman/gitutil.py", line 383, in BuildEmailList > > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > > File "./tools//patman/gitutil.py", line 588, in LookupEmail > > raise ValueError(msg) > > ValueError: Alias 'doc' not found > > I also get this error even with process_tags=False. Yep, here is my patman settings: [settings] ignore_errors: True process_tags: False verbose: True Regards, Bin ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-11 4:37 ` Bin Meng @ 2020-12-11 16:29 ` Simon Glass 2020-12-22 23:51 ` Sean Anderson 2020-12-23 1:25 ` Bin Meng 0 siblings, 2 replies; 10+ messages in thread From: Simon Glass @ 2020-12-11 16:29 UTC (permalink / raw) To: u-boot Hi Bin, On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: > > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: > > > > On 12/10/20 11:27 PM, Bin Meng wrote: > > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > >> > > >> Hi Simon, > > >> > > >> The following command no longer works. They used to work. > > >> > > >> $ ./tools/patman/patman -n -c1 > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > >> {send,test,status} ... > > >> patman: error: unrecognized arguments: -n > > >> $ ./tools/patman/patman -n -c 1 > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > >> {send,test,status} ... > > >> patman: error: argument -c/--count: invalid int value: 'send' > > >> > > >> I did not run a bisect to locate which commit introduced this. Do you > > >> have any idea? > > > > > > Resetting to v2020.10, patman works again with the above 2 commands. > > > > > > Note the latest patman also throws an exception about commit tags > > > while the v2020.10 version did not. > > > > > > Traceback (most recent call last): > > > File "./tools/patman/patman", line 177, in <module> > > > control.send(args) > > > File "./tools/patman/control.py", line 177, in send > > > args.smtp_server) > > > File "./tools/patman/control.py", line 136, in email_patches > > > add_maintainers, limit) > > > File "./tools//patman/series.py", line 264, in MakeCcFile > > > raise_on_error=raise_on_error) > > > File "./tools//patman/gitutil.py", line 383, in BuildEmailList > > > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > > > File "./tools//patman/gitutil.py", line 588, in LookupEmail > > > raise ValueError(msg) > > > ValueError: Alias 'doc' not found > > > > I also get this error even with process_tags=False. > > Yep, here is my patman settings: > > [settings] > ignore_errors: True > process_tags: False > verbose: True That error has always been, or nearly. Use -t to drop it. I have been thinking about changing it to a warning, since even I am not that strict about adding tags to my .patman file these days. Re the problem you reported, I changed patman to accept a subcommand at some point, so you need: patman -c1 send -n I know this is pretty annoying, so if you have any ideas on how to get patman to do the right thing when 'send' is missing, let me know. Regards, Simon ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-11 16:29 ` Simon Glass @ 2020-12-22 23:51 ` Sean Anderson 2020-12-23 0:06 ` Simon Glass 2020-12-23 1:25 ` Bin Meng 1 sibling, 1 reply; 10+ messages in thread From: Sean Anderson @ 2020-12-22 23:51 UTC (permalink / raw) To: u-boot On 12/11/20 11:29 AM, Simon Glass wrote: > Hi Bin, > > On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: >> >> On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: >>> >>> On 12/10/20 11:27 PM, Bin Meng wrote: >>>> On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: >>>>> >>>>> Hi Simon, >>>>> >>>>> The following command no longer works. They used to work. >>>>> >>>>> $ ./tools/patman/patman -n -c1 >>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] >>>>> {send,test,status} ... >>>>> patman: error: unrecognized arguments: -n >>>>> $ ./tools/patman/patman -n -c 1 >>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] >>>>> {send,test,status} ... >>>>> patman: error: argument -c/--count: invalid int value: 'send' >>>>> >>>>> I did not run a bisect to locate which commit introduced this. Do you >>>>> have any idea? >>>> >>>> Resetting to v2020.10, patman works again with the above 2 commands. >>>> >>>> Note the latest patman also throws an exception about commit tags >>>> while the v2020.10 version did not. >>>> >>>> Traceback (most recent call last): >>>> File "./tools/patman/patman", line 177, in <module> >>>> control.send(args) >>>> File "./tools/patman/control.py", line 177, in send >>>> args.smtp_server) >>>> File "./tools/patman/control.py", line 136, in email_patches >>>> add_maintainers, limit) >>>> File "./tools//patman/series.py", line 264, in MakeCcFile >>>> raise_on_error=raise_on_error) >>>> File "./tools//patman/gitutil.py", line 383, in BuildEmailList >>>> raw += LookupEmail(item, alias, raise_on_error=raise_on_error) >>>> File "./tools//patman/gitutil.py", line 588, in LookupEmail >>>> raise ValueError(msg) >>>> ValueError: Alias 'doc' not found >>> >>> I also get this error even with process_tags=False. >> >> Yep, here is my patman settings: >> >> [settings] >> ignore_errors: True >> process_tags: False >> verbose: True > > That error has always been, or nearly. Use -t to drop it. I have been It has not. It was introduced with 4600767d29 ("patman: Refactor how the default subcommand works"). Before: $ ../u-boot2/tools/patman/patman -n Cleaned 1 patch Dry run, so not doing much. But I would do this: Send a total of 1 patch with no cover letter. 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch Cc: Rick Chen <rickchen36@gmail.com> To: u-boot at lists.denx.de Cc: Jagan Teki <jagan@amarulasolutions.com> Cc: Marek Vasut <marex@denx.de> Version: 1 Prefix: None Git command: git send-email --annotate --to "u-boot at lists.denx.de" --cc "Jagan Teki <jagan@amarulasolutions.com>" --cc "Marek Vasut <marex@denx.de>" --cc-cmd "../u-boot2/tools/patman/patman --cc-cmd /tmp/patman.130803" 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch After: $ ../u-boot2/tools/patman/patman -n WARNING: Unknown setting process_tags WARNING: Unknown setting add_maintainers Cleaned 1 patch ValueError: Alias 'riscv' not found This is very annoying, since there was previously no error, and now there is. --Sean > thinking about changing it to a warning, since even I am not that > strict about adding tags to my .patman file these days. > > Re the problem you reported, I changed patman to accept a subcommand > at some point, so you need: > > patman -c1 send -n > > I know this is pretty annoying, so if you have any ideas on how to get > patman to do the right thing when 'send' is missing, let me know. > > Regards, > Simon > ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-22 23:51 ` Sean Anderson @ 2020-12-23 0:06 ` Simon Glass 2020-12-23 0:38 ` Sean Anderson 0 siblings, 1 reply; 10+ messages in thread From: Simon Glass @ 2020-12-23 0:06 UTC (permalink / raw) To: u-boot Hi Sean, On Tue, 22 Dec 2020 at 16:51, Sean Anderson <seanga2@gmail.com> wrote: > > On 12/11/20 11:29 AM, Simon Glass wrote: > > Hi Bin, > > > > On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: > >> > >> On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: > >>> > >>> On 12/10/20 11:27 PM, Bin Meng wrote: > >>>> On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > >>>>> > >>>>> Hi Simon, > >>>>> > >>>>> The following command no longer works. They used to work. > >>>>> > >>>>> $ ./tools/patman/patman -n -c1 > >>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > >>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] > >>>>> {send,test,status} ... > >>>>> patman: error: unrecognized arguments: -n > >>>>> $ ./tools/patman/patman -n -c 1 > >>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > >>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] > >>>>> {send,test,status} ... > >>>>> patman: error: argument -c/--count: invalid int value: 'send' > >>>>> > >>>>> I did not run a bisect to locate which commit introduced this. Do you > >>>>> have any idea? > >>>> > >>>> Resetting to v2020.10, patman works again with the above 2 commands. > >>>> > >>>> Note the latest patman also throws an exception about commit tags > >>>> while the v2020.10 version did not. > >>>> > >>>> Traceback (most recent call last): > >>>> File "./tools/patman/patman", line 177, in <module> > >>>> control.send(args) > >>>> File "./tools/patman/control.py", line 177, in send > >>>> args.smtp_server) > >>>> File "./tools/patman/control.py", line 136, in email_patches > >>>> add_maintainers, limit) > >>>> File "./tools//patman/series.py", line 264, in MakeCcFile > >>>> raise_on_error=raise_on_error) > >>>> File "./tools//patman/gitutil.py", line 383, in BuildEmailList > >>>> raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > >>>> File "./tools//patman/gitutil.py", line 588, in LookupEmail > >>>> raise ValueError(msg) > >>>> ValueError: Alias 'doc' not found > >>> > >>> I also get this error even with process_tags=False. > >> > >> Yep, here is my patman settings: > >> > >> [settings] > >> ignore_errors: True > >> process_tags: False > >> verbose: True > > > > That error has always been, or nearly. Use -t to drop it. I have been > > It has not. It was introduced with 4600767d29 ("patman: Refactor how the > default subcommand works"). Before: > > $ ../u-boot2/tools/patman/patman -n > Cleaned 1 patch > Dry run, so not doing much. But I would do this: > > Send a total of 1 patch with no cover letter. > 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch > Cc: Rick Chen <rickchen36@gmail.com> > To: u-boot at lists.denx.de > Cc: Jagan Teki <jagan@amarulasolutions.com> > Cc: Marek Vasut <marex@denx.de> > Version: 1 > Prefix: None > Git command: git send-email --annotate --to "u-boot at lists.denx.de" --cc "Jagan Teki <jagan@amarulasolutions.com>" --cc "Marek Vasut <marex@denx.de>" --cc-cmd "../u-boot2/tools/patman/patman --cc-cmd /tmp/patman.130803" 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch > > After: > > $ ../u-boot2/tools/patman/patman -n > WARNING: Unknown setting process_tags > WARNING: Unknown setting add_maintainers > Cleaned 1 patch > ValueError: Alias 'riscv' not found > > This is very annoying, since there was previously no error, and now > there is. I think you can still use -t But can you try u-boot/next ? I suspect it has been fixed there (i.e. not for this release). We still have time to get a fix in for the upcoming release though. Regards, Simon ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-23 0:06 ` Simon Glass @ 2020-12-23 0:38 ` Sean Anderson 0 siblings, 0 replies; 10+ messages in thread From: Sean Anderson @ 2020-12-23 0:38 UTC (permalink / raw) To: u-boot On 12/22/20 7:06 PM, Simon Glass wrote: > Hi Sean, > > On Tue, 22 Dec 2020 at 16:51, Sean Anderson <seanga2@gmail.com> wrote: >> >> On 12/11/20 11:29 AM, Simon Glass wrote: >>> Hi Bin, >>> >>> On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: >>>> >>>> On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: >>>>> >>>>> On 12/10/20 11:27 PM, Bin Meng wrote: >>>>>> On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: >>>>>>> >>>>>>> Hi Simon, >>>>>>> >>>>>>> The following command no longer works. They used to work. >>>>>>> >>>>>>> $ ./tools/patman/patman -n -c1 >>>>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >>>>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] >>>>>>> {send,test,status} ... >>>>>>> patman: error: unrecognized arguments: -n >>>>>>> $ ./tools/patman/patman -n -c 1 >>>>>>> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] >>>>>>> [-P PATCHWORK_URL] [-s START] [-v] [-H] >>>>>>> {send,test,status} ... >>>>>>> patman: error: argument -c/--count: invalid int value: 'send' >>>>>>> >>>>>>> I did not run a bisect to locate which commit introduced this. Do you >>>>>>> have any idea? >>>>>> >>>>>> Resetting to v2020.10, patman works again with the above 2 commands. >>>>>> >>>>>> Note the latest patman also throws an exception about commit tags >>>>>> while the v2020.10 version did not. >>>>>> >>>>>> Traceback (most recent call last): >>>>>> File "./tools/patman/patman", line 177, in <module> >>>>>> control.send(args) >>>>>> File "./tools/patman/control.py", line 177, in send >>>>>> args.smtp_server) >>>>>> File "./tools/patman/control.py", line 136, in email_patches >>>>>> add_maintainers, limit) >>>>>> File "./tools//patman/series.py", line 264, in MakeCcFile >>>>>> raise_on_error=raise_on_error) >>>>>> File "./tools//patman/gitutil.py", line 383, in BuildEmailList >>>>>> raw += LookupEmail(item, alias, raise_on_error=raise_on_error) >>>>>> File "./tools//patman/gitutil.py", line 588, in LookupEmail >>>>>> raise ValueError(msg) >>>>>> ValueError: Alias 'doc' not found >>>>> >>>>> I also get this error even with process_tags=False. >>>> >>>> Yep, here is my patman settings: >>>> >>>> [settings] >>>> ignore_errors: True >>>> process_tags: False >>>> verbose: True >>> >>> That error has always been, or nearly. Use -t to drop it. I have been >> >> It has not. It was introduced with 4600767d29 ("patman: Refactor how the >> default subcommand works"). Before: >> >> $ ../u-boot2/tools/patman/patman -n >> Cleaned 1 patch >> Dry run, so not doing much. But I would do this: >> >> Send a total of 1 patch with no cover letter. >> 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch >> Cc: Rick Chen <rickchen36@gmail.com> >> To: u-boot at lists.denx.de >> Cc: Jagan Teki <jagan@amarulasolutions.com> >> Cc: Marek Vasut <marex@denx.de> >> Version: 1 >> Prefix: None >> Git command: git send-email --annotate --to "u-boot at lists.denx.de" --cc "Jagan Teki <jagan@amarulasolutions.com>" --cc "Marek Vasut <marex@denx.de>" --cc-cmd "../u-boot2/tools/patman/patman --cc-cmd /tmp/patman.130803" 0001-riscv-Add-support-for-SPI-on-Kendryte-K210.patch >> >> After: >> >> $ ../u-boot2/tools/patman/patman -n >> WARNING: Unknown setting process_tags >> WARNING: Unknown setting add_maintainers >> Cleaned 1 patch >> ValueError: Alias 'riscv' not found >> >> This is very annoying, since there was previously no error, and now >> there is. > > I think you can still use -t > > But can you try u-boot/next ? I suspect it has been fixed there (i.e. > not for this release). It has not been fixed there. --Sean > > We still have time to get a fix in for the upcoming release though. > > Regards, > Simon > ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-11 16:29 ` Simon Glass 2020-12-22 23:51 ` Sean Anderson @ 2020-12-23 1:25 ` Bin Meng 2020-12-23 3:03 ` Simon Glass 1 sibling, 1 reply; 10+ messages in thread From: Bin Meng @ 2020-12-23 1:25 UTC (permalink / raw) To: u-boot Hi Simon, On Sat, Dec 12, 2020 at 12:29 AM Simon Glass <sjg@chromium.org> wrote: > > Hi Bin, > > On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: > > > > > > On 12/10/20 11:27 PM, Bin Meng wrote: > > > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > >> > > > >> Hi Simon, > > > >> > > > >> The following command no longer works. They used to work. > > > >> > > > >> $ ./tools/patman/patman -n -c1 > > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > > >> {send,test,status} ... > > > >> patman: error: unrecognized arguments: -n > > > >> $ ./tools/patman/patman -n -c 1 > > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > > >> {send,test,status} ... > > > >> patman: error: argument -c/--count: invalid int value: 'send' > > > >> > > > >> I did not run a bisect to locate which commit introduced this. Do you > > > >> have any idea? > > > > > > > > Resetting to v2020.10, patman works again with the above 2 commands. > > > > > > > > Note the latest patman also throws an exception about commit tags > > > > while the v2020.10 version did not. > > > > > > > > Traceback (most recent call last): > > > > File "./tools/patman/patman", line 177, in <module> > > > > control.send(args) > > > > File "./tools/patman/control.py", line 177, in send > > > > args.smtp_server) > > > > File "./tools/patman/control.py", line 136, in email_patches > > > > add_maintainers, limit) > > > > File "./tools//patman/series.py", line 264, in MakeCcFile > > > > raise_on_error=raise_on_error) > > > > File "./tools//patman/gitutil.py", line 383, in BuildEmailList > > > > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > > > > File "./tools//patman/gitutil.py", line 588, in LookupEmail > > > > raise ValueError(msg) > > > > ValueError: Alias 'doc' not found > > > > > > I also get this error even with process_tags=False. > > > > Yep, here is my patman settings: > > > > [settings] > > ignore_errors: True > > process_tags: False > > verbose: True > > That error has always been, or nearly. Use -t to drop it. I have been No, it was not in v2020.10 release. > thinking about changing it to a warning, since even I am not that > strict about adding tags to my .patman file these days. > > Re the problem you reported, I changed patman to accept a subcommand > at some point, so you need: > > patman -c1 send -n If "send" is omitted, the behavior should be like what was like before in v2020.10, instead of error messages. > I know this is pretty annoying, so if you have any ideas on how to get > patman to do the right thing when 'send' is missing, let me know. If changing the logic is hard, the patman documentation should be corrected to match the latest command line options. Regards, Bin ^ permalink raw reply [flat|nested] 10+ messages in thread
* patman regression? 2020-12-23 1:25 ` Bin Meng @ 2020-12-23 3:03 ` Simon Glass 0 siblings, 0 replies; 10+ messages in thread From: Simon Glass @ 2020-12-23 3:03 UTC (permalink / raw) To: u-boot Hi, On Tue, 22 Dec 2020 at 18:25, Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Sat, Dec 12, 2020 at 12:29 AM Simon Glass <sjg@chromium.org> wrote: > > > > Hi Bin, > > > > On Thu, 10 Dec 2020 at 21:37, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > > > On Fri, Dec 11, 2020 at 12:32 PM Sean Anderson <seanga2@gmail.com> wrote: > > > > > > > > On 12/10/20 11:27 PM, Bin Meng wrote: > > > > > On Fri, Dec 11, 2020 at 12:08 PM Bin Meng <bmeng.cn@gmail.com> wrote: > > > > >> > > > > >> Hi Simon, > > > > >> > > > > >> The following command no longer works. They used to work. > > > > >> > > > > >> $ ./tools/patman/patman -n -c1 > > > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > > > >> {send,test,status} ... > > > > >> patman: error: unrecognized arguments: -n > > > > >> $ ./tools/patman/patman -n -c 1 > > > > >> usage: patman [-h] [-b BRANCH] [-c COUNT] [-e END] [-D] [-p PROJECT] > > > > >> [-P PATCHWORK_URL] [-s START] [-v] [-H] > > > > >> {send,test,status} ... > > > > >> patman: error: argument -c/--count: invalid int value: 'send' > > > > >> > > > > >> I did not run a bisect to locate which commit introduced this. Do you > > > > >> have any idea? > > > > > > > > > > Resetting to v2020.10, patman works again with the above 2 commands. > > > > > > > > > > Note the latest patman also throws an exception about commit tags > > > > > while the v2020.10 version did not. > > > > > > > > > > Traceback (most recent call last): > > > > > File "./tools/patman/patman", line 177, in <module> > > > > > control.send(args) > > > > > File "./tools/patman/control.py", line 177, in send > > > > > args.smtp_server) > > > > > File "./tools/patman/control.py", line 136, in email_patches > > > > > add_maintainers, limit) > > > > > File "./tools//patman/series.py", line 264, in MakeCcFile > > > > > raise_on_error=raise_on_error) > > > > > File "./tools//patman/gitutil.py", line 383, in BuildEmailList > > > > > raw += LookupEmail(item, alias, raise_on_error=raise_on_error) > > > > > File "./tools//patman/gitutil.py", line 588, in LookupEmail > > > > > raise ValueError(msg) > > > > > ValueError: Alias 'doc' not found > > > > > > > > I also get this error even with process_tags=False. > > > > > > Yep, here is my patman settings: > > > > > > [settings] > > > ignore_errors: True > > > process_tags: False > > > verbose: True > > > > That error has always been, or nearly. Use -t to drop it. I have been > > No, it was not in v2020.10 release. > > > thinking about changing it to a warning, since even I am not that > > strict about adding tags to my .patman file these days. > > > > Re the problem you reported, I changed patman to accept a subcommand > > at some point, so you need: > > > > patman -c1 send -n > > If "send" is omitted, the behavior should be like what was like before > in v2020.10, instead of error messages. > > > I know this is pretty annoying, so if you have any ideas on how to get > > patman to do the right thing when 'send' is missing, let me know. > > If changing the logic is hard, the patman documentation should be > corrected to match the latest command line options. Despite my efforts I'm not sure of a good way to keep the old behaviour. I'll send a patch to update the docs. Regards, Simon ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-12-23 3:03 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-12-11 4:08 patman regression? Bin Meng 2020-12-11 4:27 ` Bin Meng 2020-12-11 4:32 ` Sean Anderson 2020-12-11 4:37 ` Bin Meng 2020-12-11 16:29 ` Simon Glass 2020-12-22 23:51 ` Sean Anderson 2020-12-23 0:06 ` Simon Glass 2020-12-23 0:38 ` Sean Anderson 2020-12-23 1:25 ` Bin Meng 2020-12-23 3:03 ` Simon Glass
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.