All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] btrfs-progs: convert: add missing types header
@ 2017-10-31 12:57 Baruch Siach
  2017-11-09 17:09 ` David Sterba
  0 siblings, 1 reply; 2+ messages in thread
From: Baruch Siach @ 2017-10-31 12:57 UTC (permalink / raw)
  To: linux-btrfs; +Cc: Baruch Siach

Build with musl libc needs the sys/types.h header for the dev_t type,
since this header is not included indirectly. This fixes the following
build failure:

In file included from convert/source-fs.c:23:0:
./convert/source-fs.h:112:1: error: unknown type name ‘dev_t’
 dev_t decode_dev(u32 dev);
 ^~~~~
convert/source-fs.c:31:1: error: unknown type name ‘dev_t’
 dev_t decode_dev(u32 dev)
 ^~~~~

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 convert/source-fs.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/convert/source-fs.h b/convert/source-fs.h
index 23f33567b42d..4e5babefe6a2 100644
--- a/convert/source-fs.h
+++ b/convert/source-fs.h
@@ -19,6 +19,7 @@
 
 #include "kerncompat.h"
 #include <linux/kdev_t.h>
+#include <sys/types.h>
 #include <pthread.h>
 
 #define CONV_IMAGE_SUBVOL_OBJECTID BTRFS_FIRST_FREE_OBJECTID
-- 
2.14.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] btrfs-progs: convert: add missing types header
  2017-10-31 12:57 [PATCH] btrfs-progs: convert: add missing types header Baruch Siach
@ 2017-11-09 17:09 ` David Sterba
  0 siblings, 0 replies; 2+ messages in thread
From: David Sterba @ 2017-11-09 17:09 UTC (permalink / raw)
  To: Baruch Siach; +Cc: linux-btrfs

On Tue, Oct 31, 2017 at 02:57:54PM +0200, Baruch Siach wrote:
> Build with musl libc needs the sys/types.h header for the dev_t type,
> since this header is not included indirectly. This fixes the following
> build failure:
> 
> In file included from convert/source-fs.c:23:0:
> ./convert/source-fs.h:112:1: error: unknown type name ‘dev_t’
>  dev_t decode_dev(u32 dev);
>  ^~~~~
> convert/source-fs.c:31:1: error: unknown type name ‘dev_t’
>  dev_t decode_dev(u32 dev)
>  ^~~~~
> 
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>

Applied, thanks.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-11-09 17:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-31 12:57 [PATCH] btrfs-progs: convert: add missing types header Baruch Siach
2017-11-09 17:09 ` David Sterba

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.