All of lore.kernel.org
 help / color / mirror / Atom feed
From: "NOMURA JUNICHI(野村　淳一)" <junichi.nomura@nec.com>
To: Yang Shi <shy828301@gmail.com>, Shakeel Butt <shakeelb@google.com>
Cc: "NOMURA JUNICHI(野村　淳一)" <junichi.nomura@nec.com>,
	"Tejun Heo" <tj@kernel.org>, "Zefan Li" <lizefan.x@bytedance.com>,
	"Johannes Weiner" <hannes@cmpxchg.org>,
	"Andrew Morton" <akpm@linux-foundation.org>,
	Cgroups <cgroups@vger.kernel.org>,
	"Linux MM" <linux-mm@kvack.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: ##freemail## Re: [PATCH] cgroup: disable controllers at parse time
Date: Tue, 18 May 2021 23:28:19 +0000	[thread overview]
Message-ID: <dee7912f-c797-963c-909e-4f7681433a32@nec.com> (raw)
In-Reply-To: <CAHbLzkqziUEUz-4nxBs4H5z4pZS3y+ceKciKYt8KVN34Gw8egw@mail.gmail.com>

On 2021/05/19 4:54, Yang Shi wrote:
> On Tue, May 18, 2021 at 11:13 AM Shakeel Butt <shakeelb@google.com> wrote:
>>
>> On Wed, May 12, 2021 at 1:19 PM Shakeel Butt <shakeelb@google.com> wrote:
>>>
>>> This patch effectively reverts the commit a3e72739b7a7 ("cgroup: fix
>>> too early usage of static_branch_disable()"). The commit 6041186a3258
>>> ("init: initialize jump labels before command line option parsing") has
>>> moved the jump_label_init() before parse_args() which has made the
>>> commit a3e72739b7a7 unnecessary. On the other hand there are
>>> consequences of disabling the controllers later as there are subsystems
>>> doing the controller checks for different decisions. One such incident
>>> is reported [1] regarding the memory controller and its impact on memory
>>> reclaim code.
>>>
>>> [1] https://lore.kernel.org/linux-mm/921e53f3-4b13-aab8-4a9e-e83ff15371e4@nec.com
>>>
>>> Signed-off-by: Shakeel Butt <shakeelb@google.com>
>>> Reported-by: NOMURA JUNICHI(野村　淳一) <junichi.nomura@nec.com>
>>
>> Nomura, I think you have already tested this patch, so, can you please
>> add your tested-by tag?

Sure, I have confirmed the problem still occurs with v5.13-rc2 and it
disappeared with your patch.

So,
Tested-by: Jun'ichi Nomura <junichi.nomura@nec.com>

-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

WARNING: multiple messages have this Message-ID (diff)
From: "NOMURA JUNICHI(野村　淳一)" <junichi.nomura-YMj9X0ASwKA@public.gmane.org>
To: Yang Shi <shy828301-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
Cc: "NOMURA JUNICHI(野村　淳一)"
	<junichi.nomura-YMj9X0ASwKA@public.gmane.org>,
	"Tejun Heo" <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	"Zefan Li" <lizefan.x-EC8Uxl6Npydl57MIdRCFDg@public.gmane.org>,
	"Johannes Weiner"
	<hannes-druUgvl0LCNAfugRpC6u6w@public.gmane.org>,
	"Andrew Morton"
	<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
	Cgroups <cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"Linux MM" <linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org>,
	LKML <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: ##freemail## Re: [PATCH] cgroup: disable controllers at parse time
Date: Tue, 18 May 2021 23:28:19 +0000	[thread overview]
Message-ID: <dee7912f-c797-963c-909e-4f7681433a32@nec.com> (raw)
In-Reply-To: <CAHbLzkqziUEUz-4nxBs4H5z4pZS3y+ceKciKYt8KVN34Gw8egw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On 2021/05/19 4:54, Yang Shi wrote:
> On Tue, May 18, 2021 at 11:13 AM Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>>
>> On Wed, May 12, 2021 at 1:19 PM Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> wrote:
>>>
>>> This patch effectively reverts the commit a3e72739b7a7 ("cgroup: fix
>>> too early usage of static_branch_disable()"). The commit 6041186a3258
>>> ("init: initialize jump labels before command line option parsing") has
>>> moved the jump_label_init() before parse_args() which has made the
>>> commit a3e72739b7a7 unnecessary. On the other hand there are
>>> consequences of disabling the controllers later as there are subsystems
>>> doing the controller checks for different decisions. One such incident
>>> is reported [1] regarding the memory controller and its impact on memory
>>> reclaim code.
>>>
>>> [1] https://lore.kernel.org/linux-mm/921e53f3-4b13-aab8-4a9e-e83ff15371e4-YMj9X0ASwKA@public.gmane.org
>>>
>>> Signed-off-by: Shakeel Butt <shakeelb-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
>>> Reported-by: NOMURA JUNICHI(野村　淳一) <junichi.nomura@nec.com>
>>
>> Nomura, I think you have already tested this patch, so, can you please
>> add your tested-by tag?

Sure, I have confirmed the problem still occurs with v5.13-rc2 and it
disappeared with your patch.

So,
Tested-by: Jun'ichi Nomura <junichi.nomura-YMj9X0ASwKA@public.gmane.org>

-- 
Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd.

  reply	other threads:[~2021-05-18 23:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-12 20:19 [PATCH] cgroup: disable controllers at parse time Shakeel Butt
2021-05-12 20:19 ` Shakeel Butt
2021-05-18 18:13 ` Shakeel Butt
2021-05-18 18:13   ` Shakeel Butt
2021-05-18 19:54   ` Yang Shi
2021-05-18 23:28     ` NOMURA JUNICHI(野村　淳一) [this message]
2021-05-18 23:28       ` ##freemail## " NOMURA JUNICHI(野村　淳一)
2021-05-20 16:30 ` Tejun Heo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=dee7912f-c797-963c-909e-4f7681433a32@nec.com \
    --to=junichi.nomura@nec.com \
    --cc=akpm@linux-foundation.org \
    --cc=cgroups@vger.kernel.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizefan.x@bytedance.com \
    --cc=shakeelb@google.com \
    --cc=shy828301@gmail.com \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.