* [PATCH] x86/speculation: Remove redundant arch_smt_update() call in sysfs SMT control
@ 2019-01-17 10:10 Zhenzhong Duan
2019-01-29 21:24 ` [tip:smp/urgent] x86/speculation: Remove redundant arch_smt_update() invocation tip-bot for Zhenzhong Duan
0 siblings, 1 reply; 2+ messages in thread
From: Zhenzhong Duan @ 2019-01-17 10:10 UTC (permalink / raw)
To: linux-kernel
Cc: mingo, konrad.wilk, tglx, dwmw, bp, srinivas.eeda, peterz, hpa
With commit a74cfffb03b7 ("x86/speculation: Rework SMT state change"),
arch_smt_update() is invoked from each individual CPU hotplug function.
Then the extra arch_smt_update() call in the sysfs SMT control is
redundant.
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
---
kernel/cpu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 91d5c38..c0c7f64 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2090,10 +2090,8 @@ static int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval)
*/
cpuhp_offline_cpu_device(cpu);
}
- if (!ret) {
+ if (!ret)
cpu_smt_control = ctrlval;
- arch_smt_update();
- }
cpu_maps_update_done();
return ret;
}
@@ -2104,7 +2102,6 @@ static int cpuhp_smt_enable(void)
cpu_maps_update_begin();
cpu_smt_control = CPU_SMT_ENABLED;
- arch_smt_update();
for_each_present_cpu(cpu) {
/* Skip online CPUs and CPUs on offline nodes */
if (cpu_online(cpu) || !node_online(cpu_to_node(cpu)))
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [tip:smp/urgent] x86/speculation: Remove redundant arch_smt_update() invocation
2019-01-17 10:10 [PATCH] x86/speculation: Remove redundant arch_smt_update() call in sysfs SMT control Zhenzhong Duan
@ 2019-01-29 21:24 ` tip-bot for Zhenzhong Duan
0 siblings, 0 replies; 2+ messages in thread
From: tip-bot for Zhenzhong Duan @ 2019-01-29 21:24 UTC (permalink / raw)
To: linux-tip-commits
Cc: peterz, srinivas.eeda, tglx, dwmw, zhenzhong.duan, linux-kernel,
mingo, konrad.wilk, hpa, bp
Commit-ID: 34d66caf251df91ff27b24a3a786810d29989eca
Gitweb: https://git.kernel.org/tip/34d66caf251df91ff27b24a3a786810d29989eca
Author: Zhenzhong Duan <zhenzhong.duan@oracle.com>
AuthorDate: Thu, 17 Jan 2019 02:10:59 -0800
Committer: Thomas Gleixner <tglx@linutronix.de>
CommitDate: Tue, 29 Jan 2019 22:20:24 +0100
x86/speculation: Remove redundant arch_smt_update() invocation
With commit a74cfffb03b7 ("x86/speculation: Rework SMT state change"),
arch_smt_update() is invoked from each individual CPU hotplug function.
Therefore the extra arch_smt_update() call in the sysfs SMT control is
redundant.
Fixes: a74cfffb03b7 ("x86/speculation: Rework SMT state change")
Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: <konrad.wilk@oracle.com>
Cc: <dwmw@amazon.co.uk>
Cc: <bp@suse.de>
Cc: <srinivas.eeda@oracle.com>
Cc: <peterz@infradead.org>
Cc: <hpa@zytor.com>
Link: https://lkml.kernel.org/r/e2e064f2-e8ef-42ca-bf4f-76b612964752@default
---
kernel/cpu.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 91d5c38eb7e5..c0c7f64573ed 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2090,10 +2090,8 @@ static int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval)
*/
cpuhp_offline_cpu_device(cpu);
}
- if (!ret) {
+ if (!ret)
cpu_smt_control = ctrlval;
- arch_smt_update();
- }
cpu_maps_update_done();
return ret;
}
@@ -2104,7 +2102,6 @@ static int cpuhp_smt_enable(void)
cpu_maps_update_begin();
cpu_smt_control = CPU_SMT_ENABLED;
- arch_smt_update();
for_each_present_cpu(cpu) {
/* Skip online CPUs and CPUs on offline nodes */
if (cpu_online(cpu) || !node_online(cpu_to_node(cpu)))
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-01-29 21:25 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-17 10:10 [PATCH] x86/speculation: Remove redundant arch_smt_update() call in sysfs SMT control Zhenzhong Duan
2019-01-29 21:24 ` [tip:smp/urgent] x86/speculation: Remove redundant arch_smt_update() invocation tip-bot for Zhenzhong Duan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.