From: Guodong Liu <guodong.liu@mediatek.com> To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: Re: [PATCH v1 2/4] pinctrl: add drive for I2C related pins on mt8192 Date: Fri, 24 Jun 2022 21:41:35 +0800 [thread overview] Message-ID: <e2f9f60f2ab7a18e9326845a95ccea28a02c39a9.camel@mediatek.com> (raw) In-Reply-To: <20220609182537.zbqk7gqsyscayv7b@notapiano> -----Original Message----- From: Nícolas F. R. A. Prado <nfraprado@collabora.com> To: Guodong Liu <guodong.liu@mediatek.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring < robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 2/4] pinctrl: add drive for I2C related pins on mt8192 Date: Thu, 9 Jun 2022 14:25:37 -0400 Hi Guodong, thank you for the patch. Please see some suggestions below. On Wed, Jun 08, 2022 at 01:39:07PM +0800, Guodong Liu wrote: > This patch provides the advanced drive raw data setting version > for I2C used pins on mt8192 Please add "mediatek:" on the commit title for this patch and patch 1, like you did for 3 and 4. will fix it in next version,thanks! > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> > --- > drivers/pinctrl/mediatek/pinctrl-mt8192.c | 31 > +++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > index 9faf7001369d..d11ff5519e1e 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > @@ -1259,6 +1259,32 @@ static const struct mtk_pin_field_calc > mt8192_pin_r1_range[] = { > PIN_FIELD_BASE(205, 205, 8, 0x0070, 0x10, 5, 1), > }; > > +static const struct mtk_pin_field_calc mt8192_pin_drv_adv_range[] = > { > + PIN_FIELD_BASE(89, 89, 2, 0x0040, 0x10, 0, 5), > + PIN_FIELD_BASE(90, 90, 2, 0x0040, 0x10, 5, 5), > + > + PIN_FIELD_BASE(118, 118, 4, 0x0040, 0x10, 0, 3), > + PIN_FIELD_BASE(119, 119, 4, 0x0040, 0x10, 18, 3), > + PIN_FIELD_BASE(120, 120, 4, 0x0040, 0x10, 15, 3), > + PIN_FIELD_BASE(121, 121, 4, 0x0050, 0x10, 3, 3), > + PIN_FIELD_BASE(122, 122, 4, 0x0040, 0x10, 12, 3), > + PIN_FIELD_BASE(123, 123, 4, 0x0050, 0x10, 0, 3), > + PIN_FIELD_BASE(124, 124, 4, 0x0040, 0x10, 9, 3), > + PIN_FIELD_BASE(125, 125, 4, 0x0040, 0x10, 27, 3), > + PIN_FIELD_BASE(139, 139, 4, 0x0040, 0x10, 6, 3), > + PIN_FIELD_BASE(140, 140, 4, 0x0040, 0x10, 24, 3), > + PIN_FIELD_BASE(141, 141, 4, 0x0040, 0x10, 3, 3), > + PIN_FIELD_BASE(142, 142, 4, 0x0040, 0x10, 21, 3), > + PIN_FIELD_BASE(160, 160, 7, 0x0030, 0x10, 0, 3), > + PIN_FIELD_BASE(161, 161, 7, 0x0030, 0x10, 3, 3), > + PIN_FIELD_BASE(200, 200, 8, 0x0010, 0x10, 3, 3), > + PIN_FIELD_BASE(201, 201, 8, 0x0010, 0x10, 9, 3), > + PIN_FIELD_BASE(202, 202, 5, 0x0020, 0x10, 0, 3), > + PIN_FIELD_BASE(203, 203, 5, 0x0020, 0x10, 3, 3), > + PIN_FIELD_BASE(204, 204, 8, 0x0010, 0x10, 0, 3), > + PIN_FIELD_BASE(205, 205, 8, 0x0010, 0x10, 6, 3), > +}; > + > static const struct mtk_pin_field_calc mt8192_pin_e1e0en_range[] = { > PIN_FIELD_BASE(118, 118, 4, 0x0040, 0x10, 0, 1), > PIN_FIELD_BASE(119, 119, 4, 0x0040, 0x10, 18, 1), > @@ -1357,6 +1383,7 @@ static const struct mtk_pin_reg_calc > mt8192_reg_cals[PINCTRL_PIN_REG_MAX] = { > [PINCTRL_PIN_REG_R1] = MTK_RANGE(mt8192_pin_r1_range), > [PINCTRL_PIN_REG_DRV_EN] = MTK_RANGE(mt8192_pin_e1e0en_range), > [PINCTRL_PIN_REG_DRV_E0] = MTK_RANGE(mt8192_pin_e0_range), > + [PINCTRL_PIN_REG_DRV_ADV] = > MTK_RANGE(mt8192_pin_drv_adv_range), Nit: use space instead of tab before the =. will fix it in next version,thanks! Thanks, Nícolas > [PINCTRL_PIN_REG_DRV_E1] = MTK_RANGE(mt8192_pin_e1_range), > }; > > @@ -1376,8 +1403,8 @@ static const struct mtk_pin_soc mt8192_data = { > .drive_get = mtk_pinconf_drive_get_rev1, > .adv_pull_get = mtk_pinconf_adv_pull_get, > .adv_pull_set = mtk_pinconf_adv_pull_set, > - .adv_drive_get = mtk_pinconf_adv_drive_get, > - .adv_drive_set = mtk_pinconf_adv_drive_set, > + .adv_drive_get = mtk_pinconf_adv_drive_get_raw, > + .adv_drive_set = mtk_pinconf_adv_drive_set_raw, > }; > > static const struct of_device_id mt8192_pinctrl_of_match[] = { > -- > 2.25.5 >
WARNING: multiple messages have this Message-ID (diff)
From: Guodong Liu <guodong.liu@mediatek.com> To: "Nícolas F. R. A. Prado" <nfraprado@collabora.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring <robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, <linux-gpio@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: Re: [PATCH v1 2/4] pinctrl: add drive for I2C related pins on mt8192 Date: Fri, 24 Jun 2022 21:41:35 +0800 [thread overview] Message-ID: <e2f9f60f2ab7a18e9326845a95ccea28a02c39a9.camel@mediatek.com> (raw) In-Reply-To: <20220609182537.zbqk7gqsyscayv7b@notapiano> -----Original Message----- From: Nícolas F. R. A. Prado <nfraprado@collabora.com> To: Guodong Liu <guodong.liu@mediatek.com> Cc: Linus Walleij <linus.walleij@linaro.org>, Rob Herring < robh+dt@kernel.org>, Matthias Brugger <matthias.bgg@gmail.com>, Sean Wang <sean.wang@kernel.org>, Sean Wang <sean.wang@mediatek.com>, Zhiyong Tao <zhiyong.tao@mediatek.com>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com Subject: Re: [PATCH v1 2/4] pinctrl: add drive for I2C related pins on mt8192 Date: Thu, 9 Jun 2022 14:25:37 -0400 Hi Guodong, thank you for the patch. Please see some suggestions below. On Wed, Jun 08, 2022 at 01:39:07PM +0800, Guodong Liu wrote: > This patch provides the advanced drive raw data setting version > for I2C used pins on mt8192 Please add "mediatek:" on the commit title for this patch and patch 1, like you did for 3 and 4. will fix it in next version,thanks! > > Signed-off-by: Guodong Liu <guodong.liu@mediatek.com> > --- > drivers/pinctrl/mediatek/pinctrl-mt8192.c | 31 > +++++++++++++++++++++-- > 1 file changed, 29 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > index 9faf7001369d..d11ff5519e1e 100644 > --- a/drivers/pinctrl/mediatek/pinctrl-mt8192.c > +++ b/drivers/pinctrl/mediatek/pinctrl-mt8192.c > @@ -1259,6 +1259,32 @@ static const struct mtk_pin_field_calc > mt8192_pin_r1_range[] = { > PIN_FIELD_BASE(205, 205, 8, 0x0070, 0x10, 5, 1), > }; > > +static const struct mtk_pin_field_calc mt8192_pin_drv_adv_range[] = > { > + PIN_FIELD_BASE(89, 89, 2, 0x0040, 0x10, 0, 5), > + PIN_FIELD_BASE(90, 90, 2, 0x0040, 0x10, 5, 5), > + > + PIN_FIELD_BASE(118, 118, 4, 0x0040, 0x10, 0, 3), > + PIN_FIELD_BASE(119, 119, 4, 0x0040, 0x10, 18, 3), > + PIN_FIELD_BASE(120, 120, 4, 0x0040, 0x10, 15, 3), > + PIN_FIELD_BASE(121, 121, 4, 0x0050, 0x10, 3, 3), > + PIN_FIELD_BASE(122, 122, 4, 0x0040, 0x10, 12, 3), > + PIN_FIELD_BASE(123, 123, 4, 0x0050, 0x10, 0, 3), > + PIN_FIELD_BASE(124, 124, 4, 0x0040, 0x10, 9, 3), > + PIN_FIELD_BASE(125, 125, 4, 0x0040, 0x10, 27, 3), > + PIN_FIELD_BASE(139, 139, 4, 0x0040, 0x10, 6, 3), > + PIN_FIELD_BASE(140, 140, 4, 0x0040, 0x10, 24, 3), > + PIN_FIELD_BASE(141, 141, 4, 0x0040, 0x10, 3, 3), > + PIN_FIELD_BASE(142, 142, 4, 0x0040, 0x10, 21, 3), > + PIN_FIELD_BASE(160, 160, 7, 0x0030, 0x10, 0, 3), > + PIN_FIELD_BASE(161, 161, 7, 0x0030, 0x10, 3, 3), > + PIN_FIELD_BASE(200, 200, 8, 0x0010, 0x10, 3, 3), > + PIN_FIELD_BASE(201, 201, 8, 0x0010, 0x10, 9, 3), > + PIN_FIELD_BASE(202, 202, 5, 0x0020, 0x10, 0, 3), > + PIN_FIELD_BASE(203, 203, 5, 0x0020, 0x10, 3, 3), > + PIN_FIELD_BASE(204, 204, 8, 0x0010, 0x10, 0, 3), > + PIN_FIELD_BASE(205, 205, 8, 0x0010, 0x10, 6, 3), > +}; > + > static const struct mtk_pin_field_calc mt8192_pin_e1e0en_range[] = { > PIN_FIELD_BASE(118, 118, 4, 0x0040, 0x10, 0, 1), > PIN_FIELD_BASE(119, 119, 4, 0x0040, 0x10, 18, 1), > @@ -1357,6 +1383,7 @@ static const struct mtk_pin_reg_calc > mt8192_reg_cals[PINCTRL_PIN_REG_MAX] = { > [PINCTRL_PIN_REG_R1] = MTK_RANGE(mt8192_pin_r1_range), > [PINCTRL_PIN_REG_DRV_EN] = MTK_RANGE(mt8192_pin_e1e0en_range), > [PINCTRL_PIN_REG_DRV_E0] = MTK_RANGE(mt8192_pin_e0_range), > + [PINCTRL_PIN_REG_DRV_ADV] = > MTK_RANGE(mt8192_pin_drv_adv_range), Nit: use space instead of tab before the =. will fix it in next version,thanks! Thanks, Nícolas > [PINCTRL_PIN_REG_DRV_E1] = MTK_RANGE(mt8192_pin_e1_range), > }; > > @@ -1376,8 +1403,8 @@ static const struct mtk_pin_soc mt8192_data = { > .drive_get = mtk_pinconf_drive_get_rev1, > .adv_pull_get = mtk_pinconf_adv_pull_get, > .adv_pull_set = mtk_pinconf_adv_pull_set, > - .adv_drive_get = mtk_pinconf_adv_drive_get, > - .adv_drive_set = mtk_pinconf_adv_drive_set, > + .adv_drive_get = mtk_pinconf_adv_drive_get_raw, > + .adv_drive_set = mtk_pinconf_adv_drive_set_raw, > }; > > static const struct of_device_id mt8192_pinctrl_of_match[] = { > -- > 2.25.5 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-06-24 13:41 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-06-08 5:39 [PATCH v1 0/4] pinctrl: mediatek: add driver support driving and resistance property on mt8192 Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` [PATCH v1 1/4] pinctrl: add generic driving setup " Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-09 18:16 ` Nícolas F. R. A. Prado 2022-06-09 18:16 ` Nícolas F. R. A. Prado 2022-06-09 18:16 ` Nícolas F. R. A. Prado 2022-06-24 13:42 ` Guodong Liu 2022-06-24 13:42 ` Guodong Liu 2022-06-08 5:39 ` [PATCH v1 2/4] pinctrl: add drive for I2C related pins " Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-09 18:25 ` Nícolas F. R. A. Prado 2022-06-09 18:25 ` Nícolas F. R. A. Prado 2022-06-09 18:25 ` Nícolas F. R. A. Prado 2022-06-24 13:41 ` Guodong Liu [this message] 2022-06-24 13:41 ` Guodong Liu 2022-06-08 5:39 ` [PATCH v1 3/4] pinctrl: mediatek: add rsel setting " Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-09 18:47 ` Nícolas F. R. A. Prado 2022-06-09 18:47 ` Nícolas F. R. A. Prado 2022-06-09 18:47 ` Nícolas F. R. A. Prado 2022-06-24 13:40 ` Guodong Liu 2022-06-24 13:40 ` Guodong Liu 2022-06-08 5:39 ` [PATCH v1 4/4] pinctrl: mediatek: fix the pinconf definition of some GPIO pins Guodong Liu 2022-06-08 5:39 ` Guodong Liu 2022-06-08 5:39 ` Guodong Liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e2f9f60f2ab7a18e9326845a95ccea28a02c39a9.camel@mediatek.com \ --to=guodong.liu@mediatek.com \ --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \ --cc=devicetree@vger.kernel.org \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=matthias.bgg@gmail.com \ --cc=nfraprado@collabora.com \ --cc=robh+dt@kernel.org \ --cc=sean.wang@kernel.org \ --cc=sean.wang@mediatek.com \ --cc=zhiyong.tao@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.