* [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 13:41 ` Jeremy Cline
0 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 13:41 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Julien Thierry, Suzuki K Poulose
Cc: linux-arm-kernel, kvmarm, linux-kernel, Jeremy Cline
Fedora kernel builds on armv7hl began failing recently because
kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
trace.h. Add the missing include.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
I've not dug very deeply into what exactly changed between commit
b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
handling").
Fedora's build config is available at
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
virt/kvm/arm/trace.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
index 204d210d01c2..cc94ccc68821 100644
--- a/virt/kvm/arm/trace.h
+++ b/virt/kvm/arm/trace.h
@@ -4,6 +4,7 @@
#include <kvm/arm_arch_timer.h>
#include <linux/tracepoint.h>
+#include <asm/kvm_arm.h>
#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvm
--
2.24.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 13:41 ` Jeremy Cline
0 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 13:41 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Julien Thierry, Suzuki K Poulose
Cc: Jeremy Cline, kvmarm, linux-arm-kernel, linux-kernel
Fedora kernel builds on armv7hl began failing recently because
kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
trace.h. Add the missing include.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
I've not dug very deeply into what exactly changed between commit
b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
handling").
Fedora's build config is available at
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
virt/kvm/arm/trace.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
index 204d210d01c2..cc94ccc68821 100644
--- a/virt/kvm/arm/trace.h
+++ b/virt/kvm/arm/trace.h
@@ -4,6 +4,7 @@
#include <kvm/arm_arch_timer.h>
#include <linux/tracepoint.h>
+#include <asm/kvm_arm.h>
#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvm
--
2.24.1
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 13:41 ` Jeremy Cline
0 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 13:41 UTC (permalink / raw)
To: Marc Zyngier, James Morse, Julien Thierry, Suzuki K Poulose
Cc: Jeremy Cline, kvmarm, linux-arm-kernel, linux-kernel
Fedora kernel builds on armv7hl began failing recently because
kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
trace.h. Add the missing include.
Signed-off-by: Jeremy Cline <jcline@redhat.com>
---
I've not dug very deeply into what exactly changed between commit
b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
handling").
Fedora's build config is available at
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
virt/kvm/arm/trace.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
index 204d210d01c2..cc94ccc68821 100644
--- a/virt/kvm/arm/trace.h
+++ b/virt/kvm/arm/trace.h
@@ -4,6 +4,7 @@
#include <kvm/arm_arch_timer.h>
#include <linux/tracepoint.h>
+#include <asm/kvm_arm.h>
#undef TRACE_SYSTEM
#define TRACE_SYSTEM kvm
--
2.24.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
2020-02-05 13:41 ` Jeremy Cline
(?)
@ 2020-02-05 15:18 ` Marc Zyngier
-1 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-02-05 15:18 UTC (permalink / raw)
To: Jeremy Cline
Cc: James Morse, Julien Thierry, Suzuki K Poulose, linux-arm-kernel,
kvmarm, linux-kernel
On 2020-02-05 13:41, Jeremy Cline wrote:
> Fedora kernel builds on armv7hl began failing recently because
> kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> trace.h. Add the missing include.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
>
> I've not dug very deeply into what exactly changed between commit
> b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> handling").
>
> Fedora's build config is available at
> https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
This config doesn't have KVM enabled.
>
> virt/kvm/arm/trace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> index 204d210d01c2..cc94ccc68821 100644
> --- a/virt/kvm/arm/trace.h
> +++ b/virt/kvm/arm/trace.h
> @@ -4,6 +4,7 @@
>
> #include <kvm/arm_arch_timer.h>
> #include <linux/tracepoint.h>
> +#include <asm/kvm_arm.h>
>
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM kvm
After enabling KVM in the above config (which requires LPAE), I've
managed to reproduce
the problem.
Fix now queued, thanks.
M.
--
Jazz is not dead. It just smells funny...
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 15:18 ` Marc Zyngier
0 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-02-05 15:18 UTC (permalink / raw)
To: Jeremy Cline; +Cc: linux-kernel, kvmarm, linux-arm-kernel
On 2020-02-05 13:41, Jeremy Cline wrote:
> Fedora kernel builds on armv7hl began failing recently because
> kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> trace.h. Add the missing include.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
>
> I've not dug very deeply into what exactly changed between commit
> b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> handling").
>
> Fedora's build config is available at
> https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
This config doesn't have KVM enabled.
>
> virt/kvm/arm/trace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> index 204d210d01c2..cc94ccc68821 100644
> --- a/virt/kvm/arm/trace.h
> +++ b/virt/kvm/arm/trace.h
> @@ -4,6 +4,7 @@
>
> #include <kvm/arm_arch_timer.h>
> #include <linux/tracepoint.h>
> +#include <asm/kvm_arm.h>
>
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM kvm
After enabling KVM in the above config (which requires LPAE), I've
managed to reproduce
the problem.
Fix now queued, thanks.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 15:18 ` Marc Zyngier
0 siblings, 0 replies; 9+ messages in thread
From: Marc Zyngier @ 2020-02-05 15:18 UTC (permalink / raw)
To: Jeremy Cline
Cc: Suzuki K Poulose, linux-kernel, James Morse, Julien Thierry,
kvmarm, linux-arm-kernel
On 2020-02-05 13:41, Jeremy Cline wrote:
> Fedora kernel builds on armv7hl began failing recently because
> kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> trace.h. Add the missing include.
>
> Signed-off-by: Jeremy Cline <jcline@redhat.com>
> ---
>
> I've not dug very deeply into what exactly changed between commit
> b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> handling").
>
> Fedora's build config is available at
> https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
This config doesn't have KVM enabled.
>
> virt/kvm/arm/trace.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> index 204d210d01c2..cc94ccc68821 100644
> --- a/virt/kvm/arm/trace.h
> +++ b/virt/kvm/arm/trace.h
> @@ -4,6 +4,7 @@
>
> #include <kvm/arm_arch_timer.h>
> #include <linux/tracepoint.h>
> +#include <asm/kvm_arm.h>
>
> #undef TRACE_SYSTEM
> #define TRACE_SYSTEM kvm
After enabling KVM in the above config (which requires LPAE), I've
managed to reproduce
the problem.
Fix now queued, thanks.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
2020-02-05 15:18 ` Marc Zyngier
(?)
@ 2020-02-05 15:46 ` Jeremy Cline
-1 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 15:46 UTC (permalink / raw)
To: Marc Zyngier
Cc: James Morse, Julien Thierry, Suzuki K Poulose, linux-arm-kernel,
kvmarm, linux-kernel
On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote:
> On 2020-02-05 13:41, Jeremy Cline wrote:
> > Fedora kernel builds on armv7hl began failing recently because
> > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> > trace.h. Add the missing include.
> >
> > Signed-off-by: Jeremy Cline <jcline@redhat.com>
> > ---
> >
> > I've not dug very deeply into what exactly changed between commit
> > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> > handling").
> >
> > Fedora's build config is available at
> > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
>
> This config doesn't have KVM enabled.
>
Whoops, I did indeed mean
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config.
Sorry about that.
> >
> > virt/kvm/arm/trace.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> > index 204d210d01c2..cc94ccc68821 100644
> > --- a/virt/kvm/arm/trace.h
> > +++ b/virt/kvm/arm/trace.h
> > @@ -4,6 +4,7 @@
> >
> > #include <kvm/arm_arch_timer.h>
> > #include <linux/tracepoint.h>
> > +#include <asm/kvm_arm.h>
> >
> > #undef TRACE_SYSTEM
> > #define TRACE_SYSTEM kvm
>
> After enabling KVM in the above config (which requires LPAE), I've managed
> to reproduce
> the problem.
>
> Fix now queued, thanks.
>
Thanks!
- Jeremy
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 15:46 ` Jeremy Cline
0 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 15:46 UTC (permalink / raw)
To: Marc Zyngier; +Cc: linux-kernel, kvmarm, linux-arm-kernel
On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote:
> On 2020-02-05 13:41, Jeremy Cline wrote:
> > Fedora kernel builds on armv7hl began failing recently because
> > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> > trace.h. Add the missing include.
> >
> > Signed-off-by: Jeremy Cline <jcline@redhat.com>
> > ---
> >
> > I've not dug very deeply into what exactly changed between commit
> > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> > handling").
> >
> > Fedora's build config is available at
> > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
>
> This config doesn't have KVM enabled.
>
Whoops, I did indeed mean
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config.
Sorry about that.
> >
> > virt/kvm/arm/trace.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> > index 204d210d01c2..cc94ccc68821 100644
> > --- a/virt/kvm/arm/trace.h
> > +++ b/virt/kvm/arm/trace.h
> > @@ -4,6 +4,7 @@
> >
> > #include <kvm/arm_arch_timer.h>
> > #include <linux/tracepoint.h>
> > +#include <asm/kvm_arm.h>
> >
> > #undef TRACE_SYSTEM
> > #define TRACE_SYSTEM kvm
>
> After enabling KVM in the above config (which requires LPAE), I've managed
> to reproduce
> the problem.
>
> Fix now queued, thanks.
>
Thanks!
- Jeremy
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] KVM: arm/arm64: Fix up includes for trace.h
@ 2020-02-05 15:46 ` Jeremy Cline
0 siblings, 0 replies; 9+ messages in thread
From: Jeremy Cline @ 2020-02-05 15:46 UTC (permalink / raw)
To: Marc Zyngier
Cc: Suzuki K Poulose, linux-kernel, James Morse, Julien Thierry,
kvmarm, linux-arm-kernel
On Wed, Feb 05, 2020 at 03:18:05PM +0000, Marc Zyngier wrote:
> On 2020-02-05 13:41, Jeremy Cline wrote:
> > Fedora kernel builds on armv7hl began failing recently because
> > kvm_arm_exception_type and kvm_arm_exception_class were undeclared in
> > trace.h. Add the missing include.
> >
> > Signed-off-by: Jeremy Cline <jcline@redhat.com>
> > ---
> >
> > I've not dug very deeply into what exactly changed between commit
> > b3a608222336 (the last build that succeeded) and commit 14cd0bd04907,
> > but my guess was commit 0e20f5e25556 ("KVM: arm/arm64: Cleanup MMIO
> > handling").
> >
> > Fedora's build config is available at
> > https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-fedora.config
>
> This config doesn't have KVM enabled.
>
Whoops, I did indeed mean
https://src.fedoraproject.org/rpms/kernel/blob/master/f/kernel-armv7hl-lpae-fedora.config.
Sorry about that.
> >
> > virt/kvm/arm/trace.h | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/virt/kvm/arm/trace.h b/virt/kvm/arm/trace.h
> > index 204d210d01c2..cc94ccc68821 100644
> > --- a/virt/kvm/arm/trace.h
> > +++ b/virt/kvm/arm/trace.h
> > @@ -4,6 +4,7 @@
> >
> > #include <kvm/arm_arch_timer.h>
> > #include <linux/tracepoint.h>
> > +#include <asm/kvm_arm.h>
> >
> > #undef TRACE_SYSTEM
> > #define TRACE_SYSTEM kvm
>
> After enabling KVM in the above config (which requires LPAE), I've managed
> to reproduce
> the problem.
>
> Fix now queued, thanks.
>
Thanks!
- Jeremy
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2020-02-05 17:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-05 13:41 [PATCH] KVM: arm/arm64: Fix up includes for trace.h Jeremy Cline
2020-02-05 13:41 ` Jeremy Cline
2020-02-05 13:41 ` Jeremy Cline
2020-02-05 15:18 ` Marc Zyngier
2020-02-05 15:18 ` Marc Zyngier
2020-02-05 15:18 ` Marc Zyngier
2020-02-05 15:46 ` Jeremy Cline
2020-02-05 15:46 ` Jeremy Cline
2020-02-05 15:46 ` Jeremy Cline
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.