All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Peter Wang <peter.wang@mediatek.com>,
	stanley.chu@mediatek.com, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com, avri.altman@wdc.com,
	alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
	chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
	cc.chou@mediatek.com, chaotian.jing@mediatek.com,
	jiajie.hao@mediatek.com, powen.kao@mediatek.com,
	jonathan.hsu@mediatek.com, qilin.tan@mediatek.com,
	lin.gui@mediatek.com
Subject: Re: [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version
Date: Tue, 31 Aug 2021 19:55:56 -0700	[thread overview]
Message-ID: <e3f14336-2cc6-3985-fd52-ead795737417@acm.org> (raw)
In-Reply-To: <da0ebaf6bb6e556eeb2f6fe4037d891bafc79ecd.camel@mediatek.com>

On 8/31/21 19:29, Peter Wang wrote:
> REG_UFS_MTK_HW_VER is a read only mediatek dedicated register.
> So, hw_ver will get a const value for mediatek to decide how to use
> debug select. It only need read once, no need multi-threads protected.

Hi Peter,

The above can be concluded easily by a human but not by software. If 
this code is analyzed with KCSAN then KCSAN will probably complain. See 
also Documentation/dev-tools/kcsan.rst.

Anyway, I'm fine with this patch.

Thanks,

Bart.

WARNING: multiple messages have this Message-ID (diff)
From: Bart Van Assche <bvanassche@acm.org>
To: Peter Wang <peter.wang@mediatek.com>,
	stanley.chu@mediatek.com, linux-scsi@vger.kernel.org,
	martin.petersen@oracle.com, avri.altman@wdc.com,
	alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: wsd_upstream@mediatek.com, linux-mediatek@lists.infradead.org,
	chun-hung.wu@mediatek.com, alice.chao@mediatek.com,
	cc.chou@mediatek.com, chaotian.jing@mediatek.com,
	jiajie.hao@mediatek.com, powen.kao@mediatek.com,
	jonathan.hsu@mediatek.com, qilin.tan@mediatek.com,
	lin.gui@mediatek.com
Subject: Re: [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version
Date: Tue, 31 Aug 2021 19:55:56 -0700	[thread overview]
Message-ID: <e3f14336-2cc6-3985-fd52-ead795737417@acm.org> (raw)
In-Reply-To: <da0ebaf6bb6e556eeb2f6fe4037d891bafc79ecd.camel@mediatek.com>

On 8/31/21 19:29, Peter Wang wrote:
> REG_UFS_MTK_HW_VER is a read only mediatek dedicated register.
> So, hw_ver will get a const value for mediatek to decide how to use
> debug select. It only need read once, no need multi-threads protected.

Hi Peter,

The above can be concluded easily by a human but not by software. If 
this code is analyzed with KCSAN then KCSAN will probably complain. See 
also Documentation/dev-tools/kcsan.rst.

Anyway, I'm fine with this patch.

Thanks,

Bart.

_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

  reply	other threads:[~2021-09-01  2:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30 12:11 [PATCH v1] scsi: ufs: ufs-mediatek: Change dbg select by check hw version peter.wang
2021-08-30 12:11 ` peter.wang
2021-08-31  2:47 ` Bart Van Assche
2021-08-31  2:47   ` Bart Van Assche
2021-09-01  2:29   ` Peter Wang
2021-09-01  2:29     ` Peter Wang
2021-09-01  2:55     ` Bart Van Assche [this message]
2021-09-01  2:55       ` Bart Van Assche
2021-09-01  5:45       ` Peter Wang
2021-09-01  5:45         ` Peter Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e3f14336-2cc6-3985-fd52-ead795737417@acm.org \
    --to=bvanassche@acm.org \
    --cc=alice.chao@mediatek.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=cc.chou@mediatek.com \
    --cc=chaotian.jing@mediatek.com \
    --cc=chun-hung.wu@mediatek.com \
    --cc=jejb@linux.ibm.com \
    --cc=jiajie.hao@mediatek.com \
    --cc=jonathan.hsu@mediatek.com \
    --cc=lin.gui@mediatek.com \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=peter.wang@mediatek.com \
    --cc=powen.kao@mediatek.com \
    --cc=qilin.tan@mediatek.com \
    --cc=stanley.chu@mediatek.com \
    --cc=wsd_upstream@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.