Re: [PATCH v3 01/10] dpp-util: fix dpp_point_from_asn1

Re: [PATCH v3 01/10] dpp-util: fix dpp_point_from_asn1

[Denis Kenzior]

[-- Attachment #1: Type: text/plain, Size: 307 bytes --]

Hi James,

On 2/14/22 15:48, James Prestwood wrote:
> This got merged without a few additional fixes, in particular an
> over 80 character line and incorrect length check.
> ---
>   src/dpp-util.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

Applied, thanks.

Regards,
-Denis

[PATCH v3 01/10] dpp-util: fix dpp_point_from_asn1

[James Prestwood]

[-- Attachment #1: Type: text/plain, Size: 1077 bytes --]

This got merged without a few additional fixes, in particular an
over 80 character line and incorrect length check.
---
 src/dpp-util.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/dpp-util.c b/src/dpp-util.c
index 4a5bd046..5199d0ae 100644
--- a/src/dpp-util.c
+++ b/src/dpp-util.c
@@ -828,7 +828,8 @@ struct l_ecc_point *dpp_point_from_asn1(const uint8_t *asn1, size_t len)
 		return NULL;
 
 	/* SEQUENCE */
-	inner_seq = asn1_der_find_elem(outer_seq, outer_len, 0, &tag, &inner_len);
+	inner_seq = asn1_der_find_elem(outer_seq, outer_len, 0, &tag,
+					&inner_len);
 	if (!inner_seq || tag != ASN1_ID_SEQUENCE)
 		return NULL;
 
@@ -859,7 +860,7 @@ struct l_ecc_point *dpp_point_from_asn1(const uint8_t *asn1, size_t len)
 
 	/* BITSTRING */
 	key_data = asn1_der_find_elem(outer_seq, outer_len, 1, &tag, &elen);
-	if (!key_data || tag != ASN1_ID_BIT_STRING || elen > 2)
+	if (!key_data || tag != ASN1_ID_BIT_STRING || elen < 2)
 		return NULL;
 
 	return l_ecc_point_from_data(curve, key_data[1],
-- 
2.34.1