From: Tom Rix <trix@redhat.com> To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu Cc: Cezary Rojewski <cezary.rojewski@intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Jie Yang <yang.jie@linux.intel.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, Julia Lawall <Julia.Lawall@inria.fr>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm_trigger Date: Mon, 15 Feb 2021 07:28:30 -0800 [thread overview] Message-ID: <e53684a9-afda-8c06-1b54-7327e95b0b01@redhat.com> (raw) In-Reply-To: <20210215151356.15252-1-dinghao.liu@zju.edu.cn> On 2/15/21 7:13 AM, Dinghao Liu wrote: > When cmd == SNDRV_PCM_TRIGGER_STOP, we should also check > the return value of skl_decoupled_trigger() just like what > we have done in case SNDRV_PCM_TRIGGER_PAUSE_RELEASE. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > sound/soc/intel/skylake/skl-pcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c > index b1ca64d2f7ea..a5b1f333a500 100644 > --- a/sound/soc/intel/skylake/skl-pcm.c > +++ b/sound/soc/intel/skylake/skl-pcm.c > @@ -516,6 +516,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd, > return ret; Is there any additional error handling to be done for the skl_stop_pipe that just happened ? Tom > > ret = skl_decoupled_trigger(substream, cmd); > + if (ret < 0) > + return ret; > + > if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) { > /* save the dpib and lpib positions */ > stream->dpib = readl(bus->remap_addr +
WARNING: multiple messages have this Message-ID (diff)
From: Tom Rix <trix@redhat.com> To: Dinghao Liu <dinghao.liu@zju.edu.cn>, kjlu@umn.edu Cc: Julia Lawall <Julia.Lawall@inria.fr>, Cezary Rojewski <cezary.rojewski@intel.com>, "Gustavo A. R. Silva" <gustavoars@kernel.org>, Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>, linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>, Jie Yang <yang.jie@linux.intel.com>, Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>, Liam Girdwood <liam.r.girdwood@linux.intel.com>, Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org Subject: Re: [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm_trigger Date: Mon, 15 Feb 2021 07:28:30 -0800 [thread overview] Message-ID: <e53684a9-afda-8c06-1b54-7327e95b0b01@redhat.com> (raw) In-Reply-To: <20210215151356.15252-1-dinghao.liu@zju.edu.cn> On 2/15/21 7:13 AM, Dinghao Liu wrote: > When cmd == SNDRV_PCM_TRIGGER_STOP, we should also check > the return value of skl_decoupled_trigger() just like what > we have done in case SNDRV_PCM_TRIGGER_PAUSE_RELEASE. > > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn> > --- > sound/soc/intel/skylake/skl-pcm.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c > index b1ca64d2f7ea..a5b1f333a500 100644 > --- a/sound/soc/intel/skylake/skl-pcm.c > +++ b/sound/soc/intel/skylake/skl-pcm.c > @@ -516,6 +516,9 @@ static int skl_pcm_trigger(struct snd_pcm_substream *substream, int cmd, > return ret; Is there any additional error handling to be done for the skl_stop_pipe that just happened ? Tom > > ret = skl_decoupled_trigger(substream, cmd); > + if (ret < 0) > + return ret; > + > if ((cmd == SNDRV_PCM_TRIGGER_SUSPEND) && !w->ignore_suspend) { > /* save the dpib and lpib positions */ > stream->dpib = readl(bus->remap_addr +
next prev parent reply other threads:[~2021-02-15 15:43 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-02-15 15:13 [PATCH] ASoC: Intel: Skylake: Fix missing check in skl_pcm_trigger Dinghao Liu 2021-02-15 15:13 ` Dinghao Liu 2021-02-15 15:28 ` Tom Rix [this message] 2021-02-15 15:28 ` Tom Rix 2021-02-19 5:18 ` dinghao.liu 2021-02-19 5:18 ` dinghao.liu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e53684a9-afda-8c06-1b54-7327e95b0b01@redhat.com \ --to=trix@redhat.com \ --cc=Julia.Lawall@inria.fr \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=cezary.rojewski@intel.com \ --cc=dinghao.liu@zju.edu.cn \ --cc=gustavoars@kernel.org \ --cc=kjlu@umn.edu \ --cc=kuninori.morimoto.gx@renesas.com \ --cc=liam.r.girdwood@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=perex@perex.cz \ --cc=pierre-louis.bossart@linux.intel.com \ --cc=tiwai@suse.com \ --cc=yang.jie@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.