From: Sinan Kaya <okaya@codeaurora.org> To: Vinod Koul <vinod.koul@intel.com> Cc: "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "timur@codeaurora.org" <timur@codeaurora.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "cov@codeaurora.org" <cov@codeaurora.org>, "jcm@redhat.com" <jcm@redhat.com>, "eric.auger@linaro.org" <eric.auger@linaro.org>, "agross@codeaurora.org" <agross@codeaurora.org>, "arnd@arndb.de" <arnd@arndb.de>, "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "Williams, Dan J" <dan.j.williams@intel.com>, Andy Shevchenko <andy.shevchenko@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: Re: [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Date: Sun, 24 Jul 2016 10:38:11 -0400 [thread overview] Message-ID: <e6560c8b-e18e-9e32-5b51-c1c12d8551ce@codeaurora.org> (raw) In-Reply-To: <20160724064256.GA9681@localhost> Hi Vinod, On 7/24/2016 2:42 AM, Vinod Koul wrote: > On Tue, Jul 19, 2016 at 12:09:37AM +0530, Sinan Kaya wrote: > >> @@ -567,6 +578,98 @@ static int hidma_create_sysfs_entry(struct hidma_dev *dev, char *name, >> return device_create_file(dev->ddev.dev, attrs); >> } >> >> +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN > > This can be true on machine with your older HW, so I would be bit more > careful here.. Correct, I tested the patch with new and old HW. The old HW won't attempt calling this function since msi flag will be false. > >> + if (rc) >> + dev_warn(&pdev->dev, >> + "failed to request MSI irq, falling back to wired IRQ\n"); >> + return rc; >> +#else >> + return -EINVAL; > > -EINVAL doesnt sound apt here.. What should I use? -ENOENT ? > >> + struct acpi_device *adev = ACPI_COMPANION(dev); >> + const char *of_compat; >> + int ret; >> + >> + if (!adev || acpi_disabled) { >> + ret = device_property_read_string(dev, "compatible", >> + &of_compat); >> + if (ret) >> + return false; >> + >> + ret = strcmp(of_compat, "qcom,hidma-1.1"); >> + } else { >> + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); > > Okay if you ahve a device ID then why do we need new binding? This device as > you said implies the support for MSI interrupts. Yes, I do have a new device ID for platforms with MSI capability. Which new binding are you referring to? > > Thanks > Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
WARNING: multiple messages have this Message-ID (diff)
From: okaya@codeaurora.org (Sinan Kaya) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Date: Sun, 24 Jul 2016 10:38:11 -0400 [thread overview] Message-ID: <e6560c8b-e18e-9e32-5b51-c1c12d8551ce@codeaurora.org> (raw) In-Reply-To: <20160724064256.GA9681@localhost> Hi Vinod, On 7/24/2016 2:42 AM, Vinod Koul wrote: > On Tue, Jul 19, 2016 at 12:09:37AM +0530, Sinan Kaya wrote: > >> @@ -567,6 +578,98 @@ static int hidma_create_sysfs_entry(struct hidma_dev *dev, char *name, >> return device_create_file(dev->ddev.dev, attrs); >> } >> >> +#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN > > This can be true on machine with your older HW, so I would be bit more > careful here.. Correct, I tested the patch with new and old HW. The old HW won't attempt calling this function since msi flag will be false. > >> + if (rc) >> + dev_warn(&pdev->dev, >> + "failed to request MSI irq, falling back to wired IRQ\n"); >> + return rc; >> +#else >> + return -EINVAL; > > -EINVAL doesnt sound apt here.. What should I use? -ENOENT ? > >> + struct acpi_device *adev = ACPI_COMPANION(dev); >> + const char *of_compat; >> + int ret; >> + >> + if (!adev || acpi_disabled) { >> + ret = device_property_read_string(dev, "compatible", >> + &of_compat); >> + if (ret) >> + return false; >> + >> + ret = strcmp(of_compat, "qcom,hidma-1.1"); >> + } else { >> + ret = strcmp(acpi_device_hid(adev), "QCOM8062"); > > Okay if you ahve a device ID then why do we need new binding? This device as > you said implies the support for MSI interrupts. Yes, I do have a new device ID for platforms with MSI capability. Which new binding are you referring to? > > Thanks > Sinan -- Sinan Kaya Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2016-07-24 14:38 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-07-18 18:39 [PATCH 00/10] dmaengine: qcom_hidma: add MSI interrupt support Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 02/10] Documentation: DT: qcom_hidma: correct spelling mistakes Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-20 1:16 ` Rob Herring 2016-07-20 1:16 ` Rob Herring 2016-07-18 18:39 ` [PATCH 03/10] of: irq: make of_msi_configure accessible from modules Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya [not found] ` <1468867177-15007-4-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-07-18 21:24 ` Rob Herring 2016-07-18 21:24 ` Rob Herring 2016-07-18 21:24 ` Rob Herring 2016-07-19 21:40 ` Sinan Kaya 2016-07-19 21:40 ` Sinan Kaya 2016-07-19 21:40 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 04/10] dmaending: qcom_hidma: configure DMA and MSI for OF Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-24 6:33 ` Vinod Koul 2016-07-24 6:33 ` Vinod Koul 2016-07-24 6:33 ` Vinod Koul 2016-07-24 14:40 ` Sinan Kaya 2016-07-24 14:40 ` Sinan Kaya 2016-07-24 14:40 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 05/10] dmaengine: qcom_hidma: make pending_tre_count atomic Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 06/10] dmaengine: qcom_hidma: make error and success path common Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 07/10] dmaengine: qcom_hidma: eliminate processed variables Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 08/10] dmaengine: qcom_hidma: bring out interrupt cause Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 09/10] dmaengine: qcom_hidma: add a common API to setup the interrupt Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya [not found] ` <1468867177-15007-1-git-send-email-okaya-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-07-18 18:39 ` [PATCH 01/10] Documentation: DT: qcom_hidma: update binding for MSI Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-19 10:37 ` Mark Rutland 2016-07-19 10:37 ` Mark Rutland 2016-07-19 12:42 ` Sinan Kaya 2016-07-19 12:42 ` Sinan Kaya 2016-07-18 18:39 ` [PATCH 10/10] dmaengine: qcom_hidma: add MSI support for interrupts Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-18 18:39 ` Sinan Kaya 2016-07-24 6:42 ` Vinod Koul 2016-07-24 6:42 ` Vinod Koul 2016-07-24 6:42 ` Vinod Koul 2016-07-24 14:38 ` Sinan Kaya [this message] 2016-07-24 14:38 ` Sinan Kaya 2016-07-24 14:38 ` Sinan Kaya 2016-08-04 12:46 ` Vinod Koul 2016-08-04 12:46 ` Vinod Koul 2016-08-04 12:46 ` Vinod Koul 2016-08-04 13:59 ` Sinan Kaya 2016-08-04 13:59 ` Sinan Kaya 2016-08-04 13:59 ` Sinan Kaya [not found] ` <497ddb6c-0233-657f-72c6-b844b798ff11-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org> 2016-08-08 8:14 ` Vinod Koul 2016-08-08 8:14 ` Vinod Koul 2016-08-08 8:14 ` Vinod Koul 2016-08-08 11:48 ` okaya 2016-08-08 11:48 ` okaya at codeaurora.org
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e6560c8b-e18e-9e32-5b51-c1c12d8551ce@codeaurora.org \ --to=okaya@codeaurora.org \ --cc=agross@codeaurora.org \ --cc=andy.shevchenko@gmail.com \ --cc=arnd@arndb.de \ --cc=cov@codeaurora.org \ --cc=dan.j.williams@intel.com \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=eric.auger@linaro.org \ --cc=jcm@redhat.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=timur@codeaurora.org \ --cc=vinod.koul@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.