From: Paolo Bonzini <pbonzini@redhat.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: peter.maydell@linaro.org, groug@kaod.org, qemu-devel@nongnu.org, Stefano Stabellini <stefano@aporeto.com>, stefanha@redhat.com, xen-devel@lists.xenproject.org, anthony.perard@citrix.com, rth@twiddle.net Subject: Re: [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Date: Wed, 15 Mar 2017 08:41:50 +0100 [thread overview] Message-ID: <e8cec3ca-7056-f7d4-add8-6b2f81e71184@redhat.com> (raw) In-Reply-To: <alpine.DEB.2.10.1703141318470.4807@sstabellini-ThinkPad-X260> On 14/03/2017 21:23, Stefano Stabellini wrote: > On Tue, 14 Mar 2017, Stefano Stabellini wrote: >>> Then you add to Makefile: >>> >>> CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y) >>> CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y) >>> +CONFIG_XEN := $(CONFIG_XEN_BACKEND) >>> CONFIG_ALL=y >>> -include config-all-devices.mak >>> -include config-all-disas.mak >>> >>> The Makefile change ensures that they are built before descending in the >>> target-specific directories. >> >> But I don't understand this. Please correct me if I am wrong, but this >> change looks like it would end up setting CONFIG_XEN every time that >> CONFIG_XEN_BACKEND is set. Without the configure change at the top, it >> would end up setting CONFIG_XEN whenever the host supports Xen, even for >> non-x86 and non-ARM targets. What am I missing? This CONFIG_XEN assignment applies to the toplevel only, i.e. to files that are built once. Targets will still take CONFIG_XEN from config-target.mak, and it will not be set for non-x86/non-ARM targets. This CONFIG_XEN assignment applies to files that are compiled once. The issue you reported here: > LINK aarch64-softmmu/qemu-system-aarch64 > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:387: undefined reference to `xenstore_write_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:388: undefined reference to `xenstore_write_be_int' is because you need this in patch 9: -common-obj-$(CONFIG_XEN_BACKEND) += xen-9p-backend.o +common-obj-$(CONFIG_XEN) += xen-9p-backend.o > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_connect': > /local/qemu/hw/9pfs/xen-9p-backend.c:292: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:313: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:357: undefined reference to `xen_pv_printf' > /local/qemu/hw/9pfs/xen-9p-backend.c:307: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:362: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:363: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:366: undefined reference to `xenstore_read_fe_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:353: undefined reference to `xen_pv_printf' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:389: undefined reference to `xenstore_write_be_int' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-arm] Error 1 > make: *** [subdir-arm-softmmu] Error 2 > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:387: undefined reference to `xenstore_write_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:388: undefined reference to `xenstore_write_be_int' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_connect': > /local/qemu/hw/9pfs/xen-9p-backend.c:292: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:313: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:357: undefined reference to `xen_pv_printf' > /local/qemu/hw/9pfs/xen-9p-backend.c:307: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:362: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:363: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:366: undefined reference to `xenstore_read_fe_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:353: undefined reference to `xen_pv_printf' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:389: undefined reference to `xenstore_write_be_int' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-aarch64] Error 1 > make: *** [subdir-aarch64-softmmu] Error 2 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel >
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com> To: Stefano Stabellini <sstabellini@kernel.org> Cc: peter.maydell@linaro.org, groug@kaod.org, qemu-devel@nongnu.org, Stefano Stabellini <stefano@aporeto.com>, stefanha@redhat.com, anthony.perard@citrix.com, xen-devel@lists.xenproject.org, rth@twiddle.net Subject: Re: [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Date: Wed, 15 Mar 2017 08:41:50 +0100 [thread overview] Message-ID: <e8cec3ca-7056-f7d4-add8-6b2f81e71184@redhat.com> (raw) In-Reply-To: <alpine.DEB.2.10.1703141318470.4807@sstabellini-ThinkPad-X260> On 14/03/2017 21:23, Stefano Stabellini wrote: > On Tue, 14 Mar 2017, Stefano Stabellini wrote: >>> Then you add to Makefile: >>> >>> CONFIG_SOFTMMU := $(if $(filter %-softmmu,$(TARGET_DIRS)),y) >>> CONFIG_USER_ONLY := $(if $(filter %-user,$(TARGET_DIRS)),y) >>> +CONFIG_XEN := $(CONFIG_XEN_BACKEND) >>> CONFIG_ALL=y >>> -include config-all-devices.mak >>> -include config-all-disas.mak >>> >>> The Makefile change ensures that they are built before descending in the >>> target-specific directories. >> >> But I don't understand this. Please correct me if I am wrong, but this >> change looks like it would end up setting CONFIG_XEN every time that >> CONFIG_XEN_BACKEND is set. Without the configure change at the top, it >> would end up setting CONFIG_XEN whenever the host supports Xen, even for >> non-x86 and non-ARM targets. What am I missing? This CONFIG_XEN assignment applies to the toplevel only, i.e. to files that are built once. Targets will still take CONFIG_XEN from config-target.mak, and it will not be set for non-x86/non-ARM targets. This CONFIG_XEN assignment applies to files that are compiled once. The issue you reported here: > LINK aarch64-softmmu/qemu-system-aarch64 > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:387: undefined reference to `xenstore_write_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:388: undefined reference to `xenstore_write_be_int' is because you need this in patch 9: -common-obj-$(CONFIG_XEN_BACKEND) += xen-9p-backend.o +common-obj-$(CONFIG_XEN) += xen-9p-backend.o > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_connect': > /local/qemu/hw/9pfs/xen-9p-backend.c:292: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:313: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:357: undefined reference to `xen_pv_printf' > /local/qemu/hw/9pfs/xen-9p-backend.c:307: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:362: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:363: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:366: undefined reference to `xenstore_read_fe_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:353: undefined reference to `xen_pv_printf' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:389: undefined reference to `xenstore_write_be_int' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-arm] Error 1 > make: *** [subdir-arm-softmmu] Error 2 > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:387: undefined reference to `xenstore_write_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:388: undefined reference to `xenstore_write_be_int' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_connect': > /local/qemu/hw/9pfs/xen-9p-backend.c:292: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:313: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:357: undefined reference to `xen_pv_printf' > /local/qemu/hw/9pfs/xen-9p-backend.c:307: undefined reference to `xenstore_read_fe_int' > /local/qemu/hw/9pfs/xen-9p-backend.c:362: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:363: undefined reference to `xenstore_read_be_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:366: undefined reference to `xenstore_read_fe_str' > /local/qemu/hw/9pfs/xen-9p-backend.c:353: undefined reference to `xen_pv_printf' > ../hw/9pfs/xen-9p-backend.o: In function `xen_9pfs_alloc': > /local/qemu/hw/9pfs/xen-9p-backend.c:389: undefined reference to `xenstore_write_be_int' > collect2: error: ld returned 1 exit status > make[1]: *** [qemu-system-aarch64] Error 1 > make: *** [subdir-aarch64-softmmu] Error 2 > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel > _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-03-15 7:42 UTC|newest] Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-03-13 23:55 [Qemu-devel] [PATCH v2 0/9] xen/9pfs: introduce the Xen 9pfs backend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 2/9] xen: import ring.h from xen Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 8:00 ` [Qemu-devel] " Greg Kurz 2017-03-15 8:00 ` Greg Kurz 2017-03-15 18:36 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 18:36 ` Stefano Stabellini 2017-03-15 19:00 ` [Qemu-devel] " Greg Kurz 2017-03-15 19:00 ` Greg Kurz 2017-03-15 19:04 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 19:04 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 3/9] xen: introduce the header file for the Xen 9pfs transport protocol Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 9:06 ` [Qemu-devel] " Greg Kurz 2017-03-15 9:06 ` Greg Kurz 2017-03-15 19:02 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 19:02 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 4/9] xen/9pfs: introduce Xen 9pfs backend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-14 7:11 ` [Qemu-devel] " Juergen Gross 2017-03-14 7:11 ` Juergen Gross 2017-03-14 20:07 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:07 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 5/9] xen/9pfs: connect to the frontend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-14 7:17 ` [Qemu-devel] " Juergen Gross 2017-03-14 7:17 ` Juergen Gross 2017-03-14 20:14 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:14 ` Stefano Stabellini 2017-03-15 9:48 ` [Qemu-devel] " Greg Kurz 2017-03-15 9:48 ` Greg Kurz 2017-03-15 21:30 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:30 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 6/9] xen/9pfs: receive requests from " Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:51 ` [Qemu-devel] " Greg Kurz 2017-03-15 10:51 ` Greg Kurz 2017-03-15 21:56 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:56 ` Stefano Stabellini 2017-03-15 11:53 ` Greg Kurz 2017-03-15 11:53 ` Greg Kurz 2017-03-15 22:03 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 22:03 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 7/9] xen/9pfs: implement in/out_iov_from_pdu and vmarshal/vunmarshal Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:58 ` [Qemu-devel] " Greg Kurz 2017-03-15 10:58 ` Greg Kurz 2017-03-15 21:58 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:58 ` Stefano Stabellini 2017-03-13 23:55 ` [Qemu-devel] [PATCH v2 8/9] xen/9pfs: send responses back to the frontend Stefano Stabellini 2017-03-13 23:55 ` Stefano Stabellini 2017-03-15 10:59 ` [Qemu-devel] " Greg Kurz 2017-03-15 10:59 ` Greg Kurz 2017-03-15 21:59 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 21:59 ` Stefano Stabellini 2017-03-13 23:56 ` [Qemu-devel] [PATCH v2 9/9] xen/9pfs: build and register Xen 9pfs backend Stefano Stabellini 2017-03-13 23:56 ` Stefano Stabellini 2017-03-14 10:02 ` [Qemu-devel] [PATCH v2 1/9] configure: change CONFIG_XEN_BACKEND to be a target property Paolo Bonzini 2017-03-14 10:02 ` Paolo Bonzini 2017-03-14 19:07 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 19:07 ` Stefano Stabellini 2017-03-14 20:23 ` [Qemu-devel] " Stefano Stabellini 2017-03-14 20:23 ` Stefano Stabellini 2017-03-15 1:03 ` [Qemu-devel] " Greg Kurz 2017-03-15 1:03 ` Greg Kurz 2017-03-15 7:41 ` Paolo Bonzini [this message] 2017-03-15 7:41 ` Paolo Bonzini 2017-03-15 18:42 ` [Qemu-devel] " Stefano Stabellini 2017-03-15 18:42 ` Stefano Stabellini
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e8cec3ca-7056-f7d4-add8-6b2f81e71184@redhat.com \ --to=pbonzini@redhat.com \ --cc=anthony.perard@citrix.com \ --cc=groug@kaod.org \ --cc=peter.maydell@linaro.org \ --cc=qemu-devel@nongnu.org \ --cc=rth@twiddle.net \ --cc=sstabellini@kernel.org \ --cc=stefanha@redhat.com \ --cc=stefano@aporeto.com \ --cc=xen-devel@lists.xenproject.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.