From: Jan Hoffmann <jan@3e8.eu> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Daniel Kestrel <kestrelseventyfour@gmail.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting Date: Fri, 17 Sep 2021 19:45:33 +0200 [thread overview] Message-ID: <e9dd0653-139f-749b-c088-e756ee2d2132@3e8.eu> (raw) In-Reply-To: <20210917190154.76203a9a@xps13> Hi Miquèl, > I am not sure to understand your message as answer to this thread. > There are two problems here: > 1/ The DT values not being taken into account This is the issue I'm referring to. > 1/ Has already been fixed (at least that is what I think) This is not fixed in kernel 5.10. And unless I am missing something there also doesn't seem be a fix in more recent kernels. I am aware of commit 33d974e76e21 ("mtd: rawnand: xway: Do not force a particular software ECC engine"), but that only fixes the ECC algorithm. The ECC engine type is still hard-coded in xway_attach_chip. Thanks, Jan
WARNING: multiple messages have this Message-ID (diff)
From: Jan Hoffmann <jan@3e8.eu> To: Miquel Raynal <miquel.raynal@bootlin.com> Cc: Daniel Kestrel <kestrelseventyfour@gmail.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting Date: Fri, 17 Sep 2021 19:45:33 +0200 [thread overview] Message-ID: <e9dd0653-139f-749b-c088-e756ee2d2132@3e8.eu> (raw) In-Reply-To: <20210917190154.76203a9a@xps13> Hi Miquèl, > I am not sure to understand your message as answer to this thread. > There are two problems here: > 1/ The DT values not being taken into account This is the issue I'm referring to. > 1/ Has already been fixed (at least that is what I think) This is not fixed in kernel 5.10. And unless I am missing something there also doesn't seem be a fix in more recent kernels. I am aware of commit 33d974e76e21 ("mtd: rawnand: xway: Do not force a particular software ECC engine"), but that only fixes the ECC algorithm. The ECC engine type is still hard-coded in xway_attach_chip. Thanks, Jan ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2021-09-17 17:45 UTC|newest] Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-08-08 7:26 [PATCH v2] mtd: rawnand: xway: No hardcoded ECC engine, use device tree setting Daniel Kestrel 2021-08-08 7:26 ` Daniel Kestrel 2021-08-16 7:31 ` Miquel Raynal 2021-08-16 7:31 ` Miquel Raynal 2021-08-19 7:21 ` Kestrel seventyfour 2021-08-19 7:21 ` Kestrel seventyfour 2021-08-19 8:03 ` Miquel Raynal 2021-08-19 8:03 ` Miquel Raynal 2021-08-23 11:19 ` Kestrel seventyfour 2021-08-23 11:19 ` Kestrel seventyfour 2021-08-23 15:24 ` Miquel Raynal 2021-08-23 15:24 ` Miquel Raynal 2021-08-24 7:15 ` Kestrel seventyfour 2021-08-24 7:15 ` Kestrel seventyfour 2021-08-24 17:22 ` Miquel Raynal 2021-08-24 17:22 ` Miquel Raynal 2021-08-25 8:47 ` Kestrel seventyfour 2021-08-25 8:47 ` Kestrel seventyfour 2021-08-25 8:51 ` Miquel Raynal 2021-08-25 8:51 ` Miquel Raynal 2021-08-25 14:07 ` Kestrel seventyfour 2021-08-25 14:07 ` Kestrel seventyfour 2021-08-25 15:31 ` Miquel Raynal 2021-08-25 15:31 ` Miquel Raynal 2021-08-26 5:27 ` Kestrel seventyfour 2021-08-26 5:27 ` Kestrel seventyfour 2021-09-16 19:38 ` Jan Hoffmann 2021-09-16 19:38 ` Jan Hoffmann 2021-09-17 17:01 ` Miquel Raynal 2021-09-17 17:01 ` Miquel Raynal 2021-09-17 17:45 ` Jan Hoffmann [this message] 2021-09-17 17:45 ` Jan Hoffmann 2021-09-17 19:32 ` Miquel Raynal 2021-09-17 19:32 ` Miquel Raynal 2021-09-18 21:26 ` Jan Hoffmann 2021-09-18 21:26 ` Jan Hoffmann 2021-09-27 16:31 ` Miquel Raynal 2021-09-27 16:31 ` Miquel Raynal 2021-09-27 20:32 ` Jan Hoffmann 2021-09-27 20:32 ` Jan Hoffmann 2021-09-28 8:49 ` Miquel Raynal 2021-09-28 8:49 ` Miquel Raynal
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=e9dd0653-139f-749b-c088-e756ee2d2132@3e8.eu \ --to=jan@3e8.eu \ --cc=kestrelseventyfour@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=richard@nod.at \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.