From: Mauro Carvalho Chehab <mchehab@redhat.com> Cc: linux-acpi@vger.kernel.org, Huang Ying <ying.huang@intel.com>, Tony Luck <tony.luck@intel.com>, Mauro Carvalho Chehab <mchehab@redhat.com>, Linux Edac Mailing List <linux-edac@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH EDAC 10/13] edac: better report error conditions in debug mode Date: Fri, 15 Feb 2013 10:44:58 -0200 [thread overview] Message-ID: <eabec3c83459107b7cba0b5f6e5ae425a2edad81.1360931635.git.mchehab@redhat.com> (raw) In-Reply-To: <cover.1360931635.git.mchehab@redhat.com> It is hard to find what's wrong without a proper error report. Improve it, in debug mode. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> --- drivers/edac/edac_mc_sysfs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 0ca1ca7..9c58da6 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -429,8 +429,12 @@ static int edac_create_csrow_objects(struct mem_ctl_info *mci) if (!nr_pages_per_csrow(csrow)) continue; err = edac_create_csrow_object(mci, mci->csrows[i], i); - if (err < 0) + if (err < 0) { + edac_dbg(1, + "failure: create csrow objects for csrow %d\n", + i); goto error; + } } return 0; @@ -1007,6 +1011,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci) edac_dbg(0, "creating device %s\n", dev_name(&mci->dev)); err = device_add(&mci->dev); if (err < 0) { + edac_dbg(1, "failure: create device %s\n", dev_name(&mci->dev)); bus_unregister(&mci->bus); kfree(mci->bus.name); return err; -- 1.8.1.2
WARNING: multiple messages have this Message-ID (diff)
From: Mauro Carvalho Chehab <mchehab@redhat.com> To: unlisted-recipients:; (no To-header on input) Cc: linux-acpi@vger.kernel.org, Huang Ying <ying.huang@intel.com>, Tony Luck <tony.luck@intel.com>, Mauro Carvalho Chehab <mchehab@redhat.com>, Linux Edac Mailing List <linux-edac@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH EDAC 10/13] edac: better report error conditions in debug mode Date: Fri, 15 Feb 2013 10:44:58 -0200 [thread overview] Message-ID: <eabec3c83459107b7cba0b5f6e5ae425a2edad81.1360931635.git.mchehab@redhat.com> (raw) In-Reply-To: <cover.1360931635.git.mchehab@redhat.com> It is hard to find what's wrong without a proper error report. Improve it, in debug mode. Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com> --- drivers/edac/edac_mc_sysfs.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/edac/edac_mc_sysfs.c b/drivers/edac/edac_mc_sysfs.c index 0ca1ca7..9c58da6 100644 --- a/drivers/edac/edac_mc_sysfs.c +++ b/drivers/edac/edac_mc_sysfs.c @@ -429,8 +429,12 @@ static int edac_create_csrow_objects(struct mem_ctl_info *mci) if (!nr_pages_per_csrow(csrow)) continue; err = edac_create_csrow_object(mci, mci->csrows[i], i); - if (err < 0) + if (err < 0) { + edac_dbg(1, + "failure: create csrow objects for csrow %d\n", + i); goto error; + } } return 0; @@ -1007,6 +1011,7 @@ int edac_create_sysfs_mci_device(struct mem_ctl_info *mci) edac_dbg(0, "creating device %s\n", dev_name(&mci->dev)); err = device_add(&mci->dev); if (err < 0) { + edac_dbg(1, "failure: create device %s\n", dev_name(&mci->dev)); bus_unregister(&mci->bus); kfree(mci->bus.name); return err; -- 1.8.1.2
next prev parent reply other threads:[~2013-02-15 12:44 UTC|newest] Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top 2013-02-15 12:44 [PATCH EDAC 00/13] Add a driver to report Firmware first errors (via GHES) Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 01/13] edac: lock module owner to avoid error report conflicts Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 02/13] ghes: move structures/enum to a header file Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 03/13] ghes: add the needed hooks for EDAC error report Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-21 1:26 ` Huang Ying 2013-02-21 12:04 ` Mauro Carvalho Chehab 2013-02-22 0:45 ` Huang Ying 2013-02-22 8:50 ` Mauro Carvalho Chehab 2013-02-22 8:57 ` Mauro Carvalho Chehab 2013-02-25 0:25 ` Huang Ying 2013-02-15 12:44 ` [PATCH EDAC 04/13] edac: add a new memory layer type Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 05/13] ghes_edac: Register at EDAC core the BIOS report Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 06/13] ghes_edac: Allow registering more than once Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 07/13] edac: add support for raw error reports Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 14:13 ` Borislav Petkov 2013-02-15 15:25 ` Mauro Carvalho Chehab 2013-02-15 15:41 ` Borislav Petkov 2013-02-15 15:49 ` Mauro Carvalho Chehab 2013-02-15 16:02 ` Borislav Petkov 2013-02-15 18:20 ` Mauro Carvalho Chehab 2013-02-16 16:57 ` Borislav Petkov 2013-02-16 16:57 ` Borislav Petkov 2013-02-17 10:44 ` Mauro Carvalho Chehab 2013-02-17 10:44 ` Mauro Carvalho Chehab 2013-02-18 13:52 ` Borislav Petkov 2013-02-18 15:24 ` Mauro Carvalho Chehab 2013-02-19 11:56 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 08/13] ghes_edac: add support for reporting errors via EDAC Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 09/13] ghes_edac: do a better job of filling EDAC DIMM info Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab [this message] 2013-02-15 12:44 ` [PATCH EDAC 10/13] edac: better report error conditions in debug mode Mauro Carvalho Chehab 2013-02-15 12:44 ` [PATCH EDAC 11/13] edac: initialize the core earlier Mauro Carvalho Chehab 2013-02-15 12:44 ` Mauro Carvalho Chehab 2013-02-15 12:45 ` [PATCH EDAC 12/13] ghes_edac.c: Don't credit the same memory dimm twice Mauro Carvalho Chehab 2013-02-15 12:45 ` Mauro Carvalho Chehab 2013-02-15 12:45 ` [PATCH EDAC 13/13] ghes_edac: Improve driver's printk messages Mauro Carvalho Chehab 2013-02-15 12:45 ` Mauro Carvalho Chehab 2013-02-15 16:38 ` Joe Perches 2013-02-15 17:33 ` Mauro Carvalho Chehab
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=eabec3c83459107b7cba0b5f6e5ae425a2edad81.1360931635.git.mchehab@redhat.com \ --to=mchehab@redhat.com \ --cc=linux-acpi@vger.kernel.org \ --cc=linux-edac@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tony.luck@intel.com \ --cc=ying.huang@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.