* [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static
@ 2022-06-10 2:07 Wang Jingjin
2022-06-13 5:09 ` Greg Ungerer
0 siblings, 1 reply; 2+ messages in thread
From: Wang Jingjin @ 2022-06-10 2:07 UTC (permalink / raw)
To: gerg, geert, linux-m68k, linux-kernel; +Cc: zhengbin13, gaochao49
Fix sparse warnings:
arch/m68k/coldfire/m523x.c:31:19: sparse: sparse: symbol 'm523x_clk_lookup' was not declared. Should it be static?
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Jingjin <wangjingjin1@huawei.com>
---
arch/m68k/coldfire/m523x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/m68k/coldfire/m523x.c b/arch/m68k/coldfire/m523x.c
index 193c178162c1..83a997313393 100644
--- a/arch/m68k/coldfire/m523x.c
+++ b/arch/m68k/coldfire/m523x.c
@@ -28,7 +28,7 @@
DEFINE_CLK(pll, "pll.0", MCF_CLK);
DEFINE_CLK(sys, "sys.0", MCF_BUSCLK);
-struct clk_lookup m523x_clk_lookup[] = {
+static struct clk_lookup m523x_clk_lookup[] = {
CLKDEV_INIT(NULL, "pll.0", &clk_pll),
CLKDEV_INIT(NULL, "sys.0", &clk_sys),
CLKDEV_INIT("mcfpit.0", NULL, &clk_pll),
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static
2022-06-10 2:07 [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static Wang Jingjin
@ 2022-06-13 5:09 ` Greg Ungerer
0 siblings, 0 replies; 2+ messages in thread
From: Greg Ungerer @ 2022-06-13 5:09 UTC (permalink / raw)
To: Wang Jingjin, geert, linux-m68k, linux-kernel; +Cc: zhengbin13, gaochao49
Hi Wang,
On 10/6/22 12:07, Wang Jingjin wrote:
> Fix sparse warnings:
>
> arch/m68k/coldfire/m523x.c:31:19: sparse: sparse: symbol 'm523x_clk_lookup' was not declared. Should it be static?
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wang Jingjin <wangjingjin1@huawei.com>
Thanks. Added to the m68knommu git tree, for-next branch.
Regards
Greg
> ---
> arch/m68k/coldfire/m523x.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/coldfire/m523x.c b/arch/m68k/coldfire/m523x.c
> index 193c178162c1..83a997313393 100644
> --- a/arch/m68k/coldfire/m523x.c
> +++ b/arch/m68k/coldfire/m523x.c
> @@ -28,7 +28,7 @@
> DEFINE_CLK(pll, "pll.0", MCF_CLK);
> DEFINE_CLK(sys, "sys.0", MCF_BUSCLK);
>
> -struct clk_lookup m523x_clk_lookup[] = {
> +static struct clk_lookup m523x_clk_lookup[] = {
> CLKDEV_INIT(NULL, "pll.0", &clk_pll),
> CLKDEV_INIT(NULL, "sys.0", &clk_sys),
> CLKDEV_INIT("mcfpit.0", NULL, &clk_pll),
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-06-13 5:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 2:07 [PATCH -next] m68k: coldfire: make symbol m523x_clk_lookup static Wang Jingjin
2022-06-13 5:09 ` Greg Ungerer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.