From: rajeevny@codeaurora.org To: Rob Herring <robh@kernel.org> Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, sean@poorly.run, robdclark@gmail.com, abhinavk@codeaurora.org, kalyan_t@codeaurora.org, mkrishn@codeaurora.org, jonathan@marek.ca Subject: Re: [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY Date: Thu, 03 Jun 2021 01:32:09 +0530 [thread overview] Message-ID: <ec1bcb4e734b784ab17c4fc558a5fab9@codeaurora.org> (raw) In-Reply-To: <20210601205848.GA1025498@robh.at.kernel.org> On 02-06-2021 02:28, Rob Herring wrote: > On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: >> + >> +properties: >> + compatible: >> + oneOf: >> + - const: qcom,dsi-phy-7nm > > When would one use this? This is for SM8250. > >> + - const: qcom,dsi-phy-7nm-7280 >> + - const: qcom,dsi-phy-7nm-8150 > > These don't look like full SoC names (sm8150?) and it's > <vendor>,<soc>-<block>. Thanks, Rob, for the review. I just took the `compatible` property currently used in the DSI PHY driver (drivers/gpu/drm/msm/dsi/phy/dsi_phy.c), and added a new entry for sc7280. A similar pattern of `compatible` names are used in other variants of the DSI PHY driver e.g. qcom,qcom,dsi-phy-10nm-8998, qcom,dsi-phy-14nm-660 etc. The existing compatible names "qcom,dsi-phy-7nm-8150" (SoC at the end) make some sense, if we look at the organization of the dsi phy driver code. I am new to this and don't know the reason behind the current code organization and this naming. Yes, I agree with you, we should use full SoC names. Adding the SoC name at the end does not feel very convincing, so I will change this to the suggested format e.g. "qcom,sm8250-dsi-phy-7nm", and will rename the occurrences in the driver and device tree accordingly. Do I need to make changes for 10nm, 14nm, 20nm, and 28nm DSI PHY too? Bindings doc for these PHYs recently got merged to msm-next [1] [1] https://gitlab.freedesktop.org/drm/msm/-/commit/8fc939e72ff80116c090aaf03952253a124d2a8e Thanks, Rajeev
WARNING: multiple messages have this Message-ID (diff)
From: rajeevny@codeaurora.org To: Rob Herring <robh@kernel.org> Cc: freedreno@lists.freedesktop.org, mkrishn@codeaurora.org, jonathan@marek.ca, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, abhinavk@codeaurora.org, kalyan_t@codeaurora.org, sean@poorly.run Subject: Re: [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY Date: Thu, 03 Jun 2021 01:32:09 +0530 [thread overview] Message-ID: <ec1bcb4e734b784ab17c4fc558a5fab9@codeaurora.org> (raw) In-Reply-To: <20210601205848.GA1025498@robh.at.kernel.org> On 02-06-2021 02:28, Rob Herring wrote: > On Mon, May 31, 2021 at 07:03:53PM +0530, Rajeev Nandan wrote: >> + >> +properties: >> + compatible: >> + oneOf: >> + - const: qcom,dsi-phy-7nm > > When would one use this? This is for SM8250. > >> + - const: qcom,dsi-phy-7nm-7280 >> + - const: qcom,dsi-phy-7nm-8150 > > These don't look like full SoC names (sm8150?) and it's > <vendor>,<soc>-<block>. Thanks, Rob, for the review. I just took the `compatible` property currently used in the DSI PHY driver (drivers/gpu/drm/msm/dsi/phy/dsi_phy.c), and added a new entry for sc7280. A similar pattern of `compatible` names are used in other variants of the DSI PHY driver e.g. qcom,qcom,dsi-phy-10nm-8998, qcom,dsi-phy-14nm-660 etc. The existing compatible names "qcom,dsi-phy-7nm-8150" (SoC at the end) make some sense, if we look at the organization of the dsi phy driver code. I am new to this and don't know the reason behind the current code organization and this naming. Yes, I agree with you, we should use full SoC names. Adding the SoC name at the end does not feel very convincing, so I will change this to the suggested format e.g. "qcom,sm8250-dsi-phy-7nm", and will rename the occurrences in the driver and device tree accordingly. Do I need to make changes for 10nm, 14nm, 20nm, and 28nm DSI PHY too? Bindings doc for these PHYs recently got merged to msm-next [1] [1] https://gitlab.freedesktop.org/drm/msm/-/commit/8fc939e72ff80116c090aaf03952253a124d2a8e Thanks, Rajeev
next prev parent reply other threads:[~2021-06-02 20:02 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-05-31 13:33 [v1 0/3] drm/msm/dsi: Add display DSI support for SC7280 target Rajeev Nandan 2021-05-31 13:33 ` Rajeev Nandan 2021-05-31 13:33 ` [v1 1/3] dt-bindings: msm/dsi: Add yaml schema for 7nm DSI PHY Rajeev Nandan 2021-05-31 13:33 ` Rajeev Nandan 2021-06-01 13:32 ` Rob Herring 2021-06-01 13:32 ` Rob Herring 2021-06-01 20:58 ` Rob Herring 2021-06-01 20:58 ` Rob Herring 2021-06-02 20:02 ` rajeevny [this message] 2021-06-02 20:02 ` rajeevny 2021-06-16 5:50 ` rajeevny 2021-06-16 5:50 ` rajeevny 2021-06-17 15:07 ` Jonathan Marek 2021-06-17 15:07 ` Jonathan Marek 2021-06-18 10:39 ` rajeevny 2021-06-18 10:39 ` rajeevny 2021-05-31 13:33 ` [v1 2/3] drm/msm/dsi: Add PHY configuration for SC7280 Rajeev Nandan 2021-05-31 13:33 ` Rajeev Nandan 2021-05-31 17:57 ` Dmitry Baryshkov 2021-05-31 17:57 ` Dmitry Baryshkov 2021-06-01 12:22 ` rajeevny 2021-06-01 12:22 ` rajeevny 2021-05-31 13:33 ` [v1 3/3] drm/msm/dsi: Add DSI support " Rajeev Nandan 2021-05-31 13:33 ` Rajeev Nandan 2021-05-31 17:57 ` Dmitry Baryshkov 2021-05-31 17:57 ` Dmitry Baryshkov
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=ec1bcb4e734b784ab17c4fc558a5fab9@codeaurora.org \ --to=rajeevny@codeaurora.org \ --cc=abhinavk@codeaurora.org \ --cc=devicetree@vger.kernel.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=jonathan@marek.ca \ --cc=kalyan_t@codeaurora.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mkrishn@codeaurora.org \ --cc=robdclark@gmail.com \ --cc=robh@kernel.org \ --cc=sean@poorly.run \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.