[PATCH] drm/amd/display: Replace list_for_each with list_for_each_entry

[PATCH] drm/amd/display: Replace list_for_each with list_for_each_entry

[Nachammai Karuppiah]

Replace use of list_for_each with list_for_each_entry to simplify the
code and remove variables that are used only in list_for_each.
Fixed using coccinelle.

Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>
---
 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 18 ++++--------------
 1 file changed, 4 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
index fa5d503..06a54fc 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
@@ -111,17 +111,12 @@ static void init_handler_common_data(struct amdgpu_dm_irq_handler_data *hcd,
  */
 static void dm_irq_work_func(struct work_struct *work)
 {
-	struct list_head *entry;
 	struct irq_list_head *irq_list_head =
 		container_of(work, struct irq_list_head, work);
 	struct list_head *handler_list = &irq_list_head->head;
 	struct amdgpu_dm_irq_handler_data *handler_data;
 
-	list_for_each(entry, handler_list) {
-		handler_data = list_entry(entry,
-					  struct amdgpu_dm_irq_handler_data,
-					  list);
-
+	list_for_each_entry(handler_data, handler_list, list) {
 		DRM_DEBUG_KMS("DM_IRQ: work_func: for dal_src=%d\n",
 				handler_data->irq_source);
 
@@ -528,18 +523,13 @@ static void amdgpu_dm_irq_immediate_work(struct amdgpu_device *adev,
 					 enum dc_irq_source irq_source)
 {
 	struct amdgpu_dm_irq_handler_data *handler_data;
-	struct list_head *entry;
 	unsigned long irq_table_flags;
 
 	DM_IRQ_TABLE_LOCK(adev, irq_table_flags);
 
-	list_for_each(
-		entry,
-		&adev->dm.irq_handler_list_high_tab[irq_source]) {
-
-		handler_data = list_entry(entry,
-					  struct amdgpu_dm_irq_handler_data,
-					  list);
+	list_for_each_entry(handler_data,
+			    &adev->dm.irq_handler_list_high_tab[irq_source],
+			    list) {
 
 		/* Call a subcomponent which registered for immediate
 		 * interrupt notification */
-- 
2.7.4

Re: [PATCH] drm/amd/display: Replace list_for_each with list_for_each_entry

[Harry Wentland]

On 2019-11-05 1:18 a.m., Nachammai Karuppiah wrote:
> Replace use of list_for_each with list_for_each_entry to simplify the
> code and remove variables that are used only in list_for_each.
> Fixed using coccinelle.
> 
> Signed-off-by: Nachammai Karuppiah <nachukannan@gmail.com>

Reviewed-by: Harry Wentland <harry.wentland@amd.com>

Harry

> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c | 18 ++++--------------
>  1 file changed, 4 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> index fa5d503..06a54fc 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq.c
> @@ -111,17 +111,12 @@ static void init_handler_common_data(struct amdgpu_dm_irq_handler_data *hcd,
>   */
>  static void dm_irq_work_func(struct work_struct *work)
>  {
> -	struct list_head *entry;
>  	struct irq_list_head *irq_list_head =
>  		container_of(work, struct irq_list_head, work);
>  	struct list_head *handler_list = &irq_list_head->head;
>  	struct amdgpu_dm_irq_handler_data *handler_data;
>  
> -	list_for_each(entry, handler_list) {
> -		handler_data = list_entry(entry,
> -					  struct amdgpu_dm_irq_handler_data,
> -					  list);
> -
> +	list_for_each_entry(handler_data, handler_list, list) {
>  		DRM_DEBUG_KMS("DM_IRQ: work_func: for dal_src=%d\n",
>  				handler_data->irq_source);
>  
> @@ -528,18 +523,13 @@ static void amdgpu_dm_irq_immediate_work(struct amdgpu_device *adev,
>  					 enum dc_irq_source irq_source)
>  {
>  	struct amdgpu_dm_irq_handler_data *handler_data;
> -	struct list_head *entry;
>  	unsigned long irq_table_flags;
>  
>  	DM_IRQ_TABLE_LOCK(adev, irq_table_flags);
>  
> -	list_for_each(
> -		entry,
> -		&adev->dm.irq_handler_list_high_tab[irq_source]) {
> -
> -		handler_data = list_entry(entry,
> -					  struct amdgpu_dm_irq_handler_data,
> -					  list);
> +	list_for_each_entry(handler_data,
> +			    &adev->dm.irq_handler_list_high_tab[irq_source],
> +			    list) {
>  
>  		/* Call a subcomponent which registered for immediate
>  		 * interrupt notification */
>