From: Hari Bathini <hbathini@linux.ibm.com> To: Thiago Jung Bauermann <bauerman@linux.ibm.com> Cc: Pingfan Liu <piliu@redhat.com>, Petr Tesarik <ptesarik@suse.cz>, Nayna Jain <nayna@linux.ibm.com>, Kexec-ml <kexec@lists.infradead.org>, Mahesh J Salgaonkar <mahesh@linux.ibm.com>, Mimi Zohar <zohar@linux.ibm.com>, lkml <linux-kernel@vger.kernel.org>, linuxppc-dev <linuxppc-dev@ozlabs.org>, Sourabh Jain <sourabhjain@linux.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, Dave Young <dyoung@redhat.com>, Vivek Goyal <vgoyal@redhat.com>, Eric Biederman <ebiederm@xmission.com> Subject: Re: [PATCH v3 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel Date: Fri, 17 Jul 2020 09:47:25 +0530 [thread overview] Message-ID: <f1e6f1d4-5052-ce6a-747f-bb821987b75a@linux.ibm.com> (raw) In-Reply-To: <875zance3n.fsf@morokweng.localdomain> On 17/07/20 3:33 am, Thiago Jung Bauermann wrote: > > Hari Bathini <hbathini@linux.ibm.com> writes: > >> On 16/07/20 4:22 am, Thiago Jung Bauermann wrote: >>> >>> Hari Bathini <hbathini@linux.ibm.com> writes: >>> <snip> >>>> + * each representing a memory range. >>>> + */ >>>> + ranges = (len >> 2) / (n_mem_addr_cells + n_mem_size_cells); >>>> + >>>> + for (i = 0; i < ranges; i++) { >>>> + base = of_read_number(prop, n_mem_addr_cells); >>>> + prop += n_mem_addr_cells; >>>> + end = base + of_read_number(prop, n_mem_size_cells) - 1; >> >> prop is not used after the above. >> >>> You need to `prop += n_mem_size_cells` here. >> >> But yeah, adding it would make it look complete in some sense.. > > Isn't it used in the next iteration of the loop? Memory@XXX/reg typically has only one range. I was looking at it from that perspective which is not right. Will update. Thanks Hari
WARNING: multiple messages have this Message-ID (diff)
From: Hari Bathini <hbathini@linux.ibm.com> To: Thiago Jung Bauermann <bauerman@linux.ibm.com> Cc: Pingfan Liu <piliu@redhat.com>, Petr Tesarik <ptesarik@suse.cz>, Nayna Jain <nayna@linux.ibm.com>, Kexec-ml <kexec@lists.infradead.org>, Mahesh J Salgaonkar <mahesh@linux.ibm.com>, Mimi Zohar <zohar@linux.ibm.com>, lkml <linux-kernel@vger.kernel.org>, linuxppc-dev <linuxppc-dev@ozlabs.org>, Sourabh Jain <sourabhjain@linux.ibm.com>, Andrew Morton <akpm@linux-foundation.org>, Dave Young <dyoung@redhat.com>, Vivek Goyal <vgoyal@redhat.com>, Eric Biederman <ebiederm@xmission.com> Subject: Re: [PATCH v3 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel Date: Fri, 17 Jul 2020 09:47:25 +0530 [thread overview] Message-ID: <f1e6f1d4-5052-ce6a-747f-bb821987b75a@linux.ibm.com> (raw) In-Reply-To: <875zance3n.fsf@morokweng.localdomain> On 17/07/20 3:33 am, Thiago Jung Bauermann wrote: > > Hari Bathini <hbathini@linux.ibm.com> writes: > >> On 16/07/20 4:22 am, Thiago Jung Bauermann wrote: >>> >>> Hari Bathini <hbathini@linux.ibm.com> writes: >>> <snip> >>>> + * each representing a memory range. >>>> + */ >>>> + ranges = (len >> 2) / (n_mem_addr_cells + n_mem_size_cells); >>>> + >>>> + for (i = 0; i < ranges; i++) { >>>> + base = of_read_number(prop, n_mem_addr_cells); >>>> + prop += n_mem_addr_cells; >>>> + end = base + of_read_number(prop, n_mem_size_cells) - 1; >> >> prop is not used after the above. >> >>> You need to `prop += n_mem_size_cells` here. >> >> But yeah, adding it would make it look complete in some sense.. > > Isn't it used in the next iteration of the loop? Memory@XXX/reg typically has only one range. I was looking at it from that perspective which is not right. Will update. Thanks Hari _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-07-17 4:18 UTC|newest] Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-13 17:20 [PATCH v3 00/12] ppc64: enable kdump support for kexec_file_load syscall Hari Bathini 2020-07-13 17:20 ` Hari Bathini 2020-07-13 17:20 ` Hari Bathini 2020-07-13 17:20 ` [PATCH v3 01/12] kexec_file: allow archs to handle special regions while locating memory hole Hari Bathini 2020-07-13 17:20 ` Hari Bathini 2020-07-13 17:20 ` Hari Bathini 2020-07-14 21:00 ` Thiago Jung Bauermann 2020-07-14 21:00 ` Thiago Jung Bauermann 2020-07-14 21:00 ` Thiago Jung Bauermann 2020-07-13 17:21 ` [PATCH v3 02/12] powerpc/kexec_file: mark PPC64 specific code Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-16 1:49 ` Thiago Jung Bauermann 2020-07-16 1:49 ` Thiago Jung Bauermann 2020-07-16 1:49 ` Thiago Jung Bauermann 2020-07-17 4:46 ` Hari Bathini 2020-07-17 4:46 ` Hari Bathini 2020-07-17 4:46 ` Hari Bathini 2020-07-17 18:34 ` Thiago Jung Bauermann 2020-07-17 18:34 ` Thiago Jung Bauermann 2020-07-13 17:21 ` [PATCH v3 03/12] powerpc/kexec_file: add helper functions for getting memory ranges Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-14 23:49 ` Thiago Jung Bauermann 2020-07-14 23:49 ` Thiago Jung Bauermann 2020-07-14 23:49 ` Thiago Jung Bauermann 2020-07-16 21:08 ` Hari Bathini 2020-07-16 21:08 ` Hari Bathini 2020-07-17 4:32 ` Hari Bathini 2020-07-17 4:32 ` Hari Bathini 2020-07-17 4:32 ` Hari Bathini 2020-07-17 20:00 ` Hari Bathini 2020-07-17 20:00 ` Hari Bathini 2020-07-13 17:21 ` [PATCH v3 04/12] ppc64/kexec_file: avoid stomping memory used by special regions Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-15 2:39 ` Thiago Jung Bauermann 2020-07-15 2:39 ` Thiago Jung Bauermann 2020-07-15 2:39 ` Thiago Jung Bauermann 2020-07-16 5:58 ` Thiago Jung Bauermann 2020-07-16 5:58 ` Thiago Jung Bauermann 2020-07-16 5:58 ` Thiago Jung Bauermann 2020-07-16 21:09 ` Hari Bathini 2020-07-16 21:09 ` Hari Bathini 2020-07-16 21:59 ` Thiago Jung Bauermann 2020-07-16 21:59 ` Thiago Jung Bauermann 2020-07-16 21:59 ` Thiago Jung Bauermann 2020-07-13 17:21 ` [PATCH v3 05/12] powerpc/drmem: make lmb walk a bit more flexible Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-13 17:21 ` Hari Bathini 2020-07-15 3:50 ` Thiago Jung Bauermann 2020-07-15 3:50 ` Thiago Jung Bauermann 2020-07-15 3:50 ` Thiago Jung Bauermann 2020-07-16 21:09 ` Hari Bathini 2020-07-16 21:09 ` Hari Bathini 2020-07-16 22:01 ` Thiago Jung Bauermann 2020-07-16 22:01 ` Thiago Jung Bauermann 2020-07-16 22:01 ` Thiago Jung Bauermann 2020-07-13 17:22 ` [PATCH v3 06/12] ppc64/kexec_file: restrict memory usage of kdump kernel Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-15 22:52 ` Thiago Jung Bauermann 2020-07-15 22:52 ` Thiago Jung Bauermann 2020-07-15 22:52 ` Thiago Jung Bauermann 2020-07-16 21:10 ` Hari Bathini 2020-07-16 21:10 ` Hari Bathini 2020-07-16 22:03 ` Thiago Jung Bauermann 2020-07-16 22:03 ` Thiago Jung Bauermann 2020-07-16 22:03 ` Thiago Jung Bauermann 2020-07-17 4:17 ` Hari Bathini [this message] 2020-07-17 4:17 ` Hari Bathini 2020-07-13 17:22 ` [PATCH v3 07/12] ppc64/kexec_file: add support to relocate purgatory Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-16 0:20 ` Thiago Jung Bauermann 2020-07-16 0:20 ` Thiago Jung Bauermann 2020-07-16 0:20 ` Thiago Jung Bauermann 2020-07-16 21:11 ` Hari Bathini 2020-07-16 21:11 ` Hari Bathini 2020-07-16 22:12 ` Thiago Jung Bauermann 2020-07-16 22:12 ` Thiago Jung Bauermann 2020-07-16 22:12 ` Thiago Jung Bauermann 2020-07-13 17:22 ` [PATCH v3 08/12] ppc64/kexec_file: setup the stack for purgatory Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-16 0:35 ` Thiago Jung Bauermann 2020-07-16 0:35 ` Thiago Jung Bauermann 2020-07-16 0:35 ` Thiago Jung Bauermann 2020-07-16 1:40 ` Thiago Jung Bauermann 2020-07-16 1:40 ` Thiago Jung Bauermann 2020-07-16 1:40 ` Thiago Jung Bauermann 2020-07-13 17:22 ` [PATCH v3 09/12] ppc64/kexec_file: setup backup region for kdump kernel Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-13 17:22 ` Hari Bathini 2020-07-16 1:38 ` Thiago Jung Bauermann 2020-07-16 1:38 ` Thiago Jung Bauermann 2020-07-16 1:38 ` Thiago Jung Bauermann 2020-07-16 21:10 ` Hari Bathini 2020-07-16 21:10 ` Hari Bathini 2020-07-16 22:06 ` Thiago Jung Bauermann 2020-07-16 22:06 ` Thiago Jung Bauermann 2020-07-16 22:06 ` Thiago Jung Bauermann 2020-07-13 17:23 ` [PATCH v3 10/12] ppc64/kexec_file: prepare elfcore header for crashing kernel Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-16 2:22 ` Thiago Jung Bauermann 2020-07-16 2:22 ` Thiago Jung Bauermann 2020-07-16 2:22 ` Thiago Jung Bauermann 2020-07-16 21:07 ` Hari Bathini 2020-07-16 21:07 ` Hari Bathini 2020-07-16 21:57 ` Thiago Jung Bauermann 2020-07-16 21:57 ` Thiago Jung Bauermann 2020-07-16 21:57 ` Thiago Jung Bauermann 2020-07-13 17:23 ` [PATCH v3 11/12] ppc64/kexec_file: add appropriate regions for memory reserve map Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-16 2:27 ` Thiago Jung Bauermann 2020-07-16 2:27 ` Thiago Jung Bauermann 2020-07-16 2:27 ` Thiago Jung Bauermann 2020-07-13 17:23 ` [PATCH v3 12/12] ppc64/kexec_file: fix kexec load failure with lack of memory hole Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-13 17:23 ` Hari Bathini 2020-07-16 5:43 ` Thiago Jung Bauermann 2020-07-16 5:43 ` Thiago Jung Bauermann 2020-07-16 5:43 ` Thiago Jung Bauermann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f1e6f1d4-5052-ce6a-747f-bb821987b75a@linux.ibm.com \ --to=hbathini@linux.ibm.com \ --cc=akpm@linux-foundation.org \ --cc=bauerman@linux.ibm.com \ --cc=dyoung@redhat.com \ --cc=ebiederm@xmission.com \ --cc=kexec@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linuxppc-dev@ozlabs.org \ --cc=mahesh@linux.ibm.com \ --cc=nayna@linux.ibm.com \ --cc=piliu@redhat.com \ --cc=ptesarik@suse.cz \ --cc=sourabhjain@linux.ibm.com \ --cc=vgoyal@redhat.com \ --cc=zohar@linux.ibm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.