From: Michael Walle <michael@walle.cc> To: Tudor Ambarus <tudor.ambarus@microchip.com> Cc: p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com Subject: Re: [PATCH v2 2/8] mtd: spi-nor: Introduce spi_nor_match_id() Date: Mon, 21 Mar 2022 23:15:36 +0100 [thread overview] Message-ID: <f270ae65e7bf42b6aa8521c6a0db4784@walle.cc> (raw) In-Reply-To: <20220228111712.111737-3-tudor.ambarus@microchip.com> Am 2022-02-28 12:17, schrieb Tudor Ambarus: > Similar to spi_nor_match_name() extend the search of flash_info through > all the manufacturers, this time doing the match by ID. There's no > reason > to limit the search per manufacturer yet, do it globally, search the > flash > in all the parts of all manufacturers in a single method. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Reviewed-by: Michael Walle <michael@walle.cc> > --- > drivers/mtd/spi-nor/core.c | 40 ++++++++++++++++++-------------------- > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index f3c359d03163..f87cb7d3daab 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -1629,16 +1629,21 @@ static const struct spi_nor_manufacturer > *manufacturers[] = { > &spi_nor_xmc, > }; > > -static const struct flash_info * > -spi_nor_search_part_by_id(const struct flash_info *parts, unsigned int > nparts, > - const u8 *id) > +static const struct flash_info *spi_nor_match_id(struct spi_nor *nor, > + const u8 *id) > { > - unsigned int i; > + const struct flash_info *part; > + unsigned int i, j; > > - for (i = 0; i < nparts; i++) { > - if (parts[i].id_len && > - !memcmp(parts[i].id, id, parts[i].id_len)) > - return &parts[i]; > + for (i = 0; i < ARRAY_SIZE(manufacturers); i++) { > + for (j = 0; j < manufacturers[i]->nparts; j++) { > + part = &manufacturers[i]->parts[j]; > + if (part->id_len && > + !memcmp(part->id, id, part->id_len)) { > + nor->manufacturer = manufacturers[i]; > + return part; > + } > + } > } > > return NULL; > @@ -1648,7 +1653,6 @@ static const struct flash_info > *spi_nor_read_id(struct spi_nor *nor) > { > const struct flash_info *info; > u8 *id = nor->bouncebuf; > - unsigned int i; > int ret; > > if (nor->spimem) { > @@ -1668,19 +1672,13 @@ static const struct flash_info > *spi_nor_read_id(struct spi_nor *nor) > return ERR_PTR(ret); > } > > - for (i = 0; i < ARRAY_SIZE(manufacturers); i++) { > - info = spi_nor_search_part_by_id(manufacturers[i]->parts, > - manufacturers[i]->nparts, > - id); > - if (info) { > - nor->manufacturer = manufacturers[i]; > - return info; > - } > + info = spi_nor_match_id(nor, id); > + if (!info) { > + dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", > + SPI_NOR_MAX_ID_LEN, id); > + return ERR_PTR(-ENODEV); > } > - > - dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", > - SPI_NOR_MAX_ID_LEN, id); > - return ERR_PTR(-ENODEV); > + return info; > } > > static int spi_nor_read(struct mtd_info *mtd, loff_t from, size_t len, -- -michael ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Michael Walle <michael@walle.cc> To: Tudor Ambarus <tudor.ambarus@microchip.com> Cc: p.yadav@ti.com, miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, nicolas.ferre@microchip.com Subject: Re: [PATCH v2 2/8] mtd: spi-nor: Introduce spi_nor_match_id() Date: Mon, 21 Mar 2022 23:15:36 +0100 [thread overview] Message-ID: <f270ae65e7bf42b6aa8521c6a0db4784@walle.cc> (raw) In-Reply-To: <20220228111712.111737-3-tudor.ambarus@microchip.com> Am 2022-02-28 12:17, schrieb Tudor Ambarus: > Similar to spi_nor_match_name() extend the search of flash_info through > all the manufacturers, this time doing the match by ID. There's no > reason > to limit the search per manufacturer yet, do it globally, search the > flash > in all the parts of all manufacturers in a single method. > > Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com> Reviewed-by: Michael Walle <michael@walle.cc> > --- > drivers/mtd/spi-nor/core.c | 40 ++++++++++++++++++-------------------- > 1 file changed, 19 insertions(+), 21 deletions(-) > > diff --git a/drivers/mtd/spi-nor/core.c b/drivers/mtd/spi-nor/core.c > index f3c359d03163..f87cb7d3daab 100644 > --- a/drivers/mtd/spi-nor/core.c > +++ b/drivers/mtd/spi-nor/core.c > @@ -1629,16 +1629,21 @@ static const struct spi_nor_manufacturer > *manufacturers[] = { > &spi_nor_xmc, > }; > > -static const struct flash_info * > -spi_nor_search_part_by_id(const struct flash_info *parts, unsigned int > nparts, > - const u8 *id) > +static const struct flash_info *spi_nor_match_id(struct spi_nor *nor, > + const u8 *id) > { > - unsigned int i; > + const struct flash_info *part; > + unsigned int i, j; > > - for (i = 0; i < nparts; i++) { > - if (parts[i].id_len && > - !memcmp(parts[i].id, id, parts[i].id_len)) > - return &parts[i]; > + for (i = 0; i < ARRAY_SIZE(manufacturers); i++) { > + for (j = 0; j < manufacturers[i]->nparts; j++) { > + part = &manufacturers[i]->parts[j]; > + if (part->id_len && > + !memcmp(part->id, id, part->id_len)) { > + nor->manufacturer = manufacturers[i]; > + return part; > + } > + } > } > > return NULL; > @@ -1648,7 +1653,6 @@ static const struct flash_info > *spi_nor_read_id(struct spi_nor *nor) > { > const struct flash_info *info; > u8 *id = nor->bouncebuf; > - unsigned int i; > int ret; > > if (nor->spimem) { > @@ -1668,19 +1672,13 @@ static const struct flash_info > *spi_nor_read_id(struct spi_nor *nor) > return ERR_PTR(ret); > } > > - for (i = 0; i < ARRAY_SIZE(manufacturers); i++) { > - info = spi_nor_search_part_by_id(manufacturers[i]->parts, > - manufacturers[i]->nparts, > - id); > - if (info) { > - nor->manufacturer = manufacturers[i]; > - return info; > - } > + info = spi_nor_match_id(nor, id); > + if (!info) { > + dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", > + SPI_NOR_MAX_ID_LEN, id); > + return ERR_PTR(-ENODEV); > } > - > - dev_err(nor->dev, "unrecognized JEDEC id bytes: %*ph\n", > - SPI_NOR_MAX_ID_LEN, id); > - return ERR_PTR(-ENODEV); > + return info; > } > > static int spi_nor_read(struct mtd_info *mtd, loff_t from, size_t len, -- -michael
next prev parent reply other threads:[~2022-03-21 22:15 UTC|newest] Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-02-28 11:17 [PATCH v2 0/8] mtd: spi-nor: Rework Octal DTR methods Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-02-28 11:17 ` [PATCH v2 1/8] mtd: spi-nor: Rename method, s/spi_nor_match_id/spi_nor_match_name Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 11:57 ` Pratyush Yadav 2022-03-21 11:57 ` Pratyush Yadav 2022-03-21 22:14 ` Michael Walle 2022-03-21 22:14 ` Michael Walle 2022-02-28 11:17 ` [PATCH v2 2/8] mtd: spi-nor: Introduce spi_nor_match_id() Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:00 ` Pratyush Yadav 2022-03-21 12:00 ` Pratyush Yadav 2022-03-21 22:15 ` Michael Walle [this message] 2022-03-21 22:15 ` Michael Walle 2022-02-28 11:17 ` [PATCH v2 3/8] mtd: spi-nor: core: Use auto-detection only once Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:14 ` Pratyush Yadav 2022-03-21 12:14 ` Pratyush Yadav 2022-03-21 12:50 ` Tudor.Ambarus 2022-03-21 12:50 ` Tudor.Ambarus 2022-03-21 17:42 ` Pratyush Yadav 2022-03-21 17:42 ` Pratyush Yadav 2022-03-21 22:38 ` Michael Walle 2022-03-21 22:38 ` Michael Walle 2022-03-30 18:50 ` Pratyush Yadav 2022-03-30 18:50 ` Pratyush Yadav 2022-02-28 11:17 ` [PATCH v2 4/8] mtd: spi-nor: core: Introduce method for RDID op Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:21 ` Pratyush Yadav 2022-03-21 12:21 ` Pratyush Yadav 2022-03-21 13:18 ` Tudor.Ambarus 2022-03-21 13:18 ` Tudor.Ambarus 2022-03-21 17:39 ` Pratyush Yadav 2022-03-21 17:39 ` Pratyush Yadav 2022-03-30 6:53 ` Tudor.Ambarus 2022-03-30 6:53 ` Tudor.Ambarus 2022-03-30 18:49 ` Pratyush Yadav 2022-03-30 18:49 ` Pratyush Yadav 2022-03-21 22:56 ` Michael Walle 2022-03-21 22:56 ` Michael Walle 2022-03-22 7:32 ` Pratyush Yadav 2022-03-22 7:32 ` Pratyush Yadav 2022-03-22 8:19 ` Michael Walle 2022-03-22 8:19 ` Michael Walle 2022-02-28 11:17 ` [PATCH v2 5/8] mtd: spi-nor: manufacturers: Use spi_nor_read_id() core method Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:27 ` Pratyush Yadav 2022-03-21 12:27 ` Pratyush Yadav 2022-02-28 11:17 ` [PATCH v2 6/8] mtd: spi-nor: core: Add helpers to read/write any register Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 23:13 ` Michael Walle 2022-03-21 23:13 ` Michael Walle 2022-04-11 7:29 ` Tudor.Ambarus 2022-04-11 7:29 ` Tudor.Ambarus 2022-02-28 11:17 ` [PATCH v2 7/8] mtd: spi-nor: micron-st: Rework spi_nor_micron_octal_dtr_enable() Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:33 ` Pratyush Yadav 2022-03-21 12:33 ` Pratyush Yadav 2022-02-28 11:17 ` [PATCH v2 8/8] mtd: spi-nor: spansion: Rework spi_nor_cypress_octal_dtr_enable() Tudor Ambarus 2022-02-28 11:17 ` Tudor Ambarus 2022-03-21 12:34 ` Pratyush Yadav 2022-03-21 12:34 ` Pratyush Yadav 2022-03-21 13:19 ` Tudor.Ambarus 2022-03-21 13:19 ` Tudor.Ambarus
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=f270ae65e7bf42b6aa8521c6a0db4784@walle.cc \ --to=michael@walle.cc \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mtd@lists.infradead.org \ --cc=miquel.raynal@bootlin.com \ --cc=nicolas.ferre@microchip.com \ --cc=p.yadav@ti.com \ --cc=richard@nod.at \ --cc=tudor.ambarus@microchip.com \ --cc=vigneshr@ti.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.